)]}'
{"tempest/scenario/manager.py":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"c0066055682652074ce8c8e1bb3da0c88adeced4","unresolved":false,"context_lines":[{"line_number":784,"context_line":""},{"line_number":785,"context_line":"        # if port is in \u0027BUILD\u0027 status, we should wait for it to become"},{"line_number":786,"context_line":"        # \u0027ACTIVE\u0027 or \u0027DOWN\u0027."},{"line_number":787,"context_line":"        def wait_for_port_finish_building():"},{"line_number":788,"context_line":"            ports \u003d self._list_ports(device_id\u003dserver[\u0027id\u0027], fixed_ip\u003dip_addr)"},{"line_number":789,"context_line":"            return not [p for p in ports if p[\u0027status\u0027] not in p_status]"},{"line_number":790,"context_line":"        tempest.test.call_until_true(wait_for_port_finish_building,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a8bc5a2_27e368da","line":787,"updated":"2016-09-27 04:14:36.000000000","message":"This method is not for waiting for something. So, I think it\u0027s better to change the name to has_build_status() or something like that. And I also think why don\u0027t you checking only \u0027BUILD\u0027 status here?\nI\u0027m concerning wheather the statuses are really only \u0027ACTIVE\u0027,\u0027DOWN\u0027,\u0027BUILD\u0027? If we have \u0027ERROR\u0027, this waits for build_timeout. So, I think it\u0027s better to wait only when the status is \u0027BUILD\u0027. And I also think it makes very explicit and simple logic here.\nDo I miss something?","commit_id":"e775e4cd19220772dea3e5f549222450aac4af06"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"1e3f354891d15ea2b697f8fc4740c72ca9abe7a4","unresolved":false,"context_lines":[{"line_number":784,"context_line":""},{"line_number":785,"context_line":"        # if port is in \u0027BUILD\u0027 status, we should wait for it to become"},{"line_number":786,"context_line":"        # \u0027ACTIVE\u0027 or \u0027DOWN\u0027."},{"line_number":787,"context_line":"        def wait_for_port_finish_building():"},{"line_number":788,"context_line":"            ports \u003d self._list_ports(device_id\u003dserver[\u0027id\u0027], fixed_ip\u003dip_addr)"},{"line_number":789,"context_line":"            return not [p for p in ports if p[\u0027status\u0027] not in p_status]"},{"line_number":790,"context_line":"        tempest.test.call_until_true(wait_for_port_finish_building,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a8bc5a2_08d3d960","line":787,"in_reply_to":"5a8bc5a2_27e368da","updated":"2016-09-27 06:10:30.000000000","message":"In IRC chat, I found my misunderstanding. I forgot the Ironic case.","commit_id":"e775e4cd19220772dea3e5f549222450aac4af06"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"c0066055682652074ce8c8e1bb3da0c88adeced4","unresolved":false,"context_lines":[{"line_number":786,"context_line":"        # \u0027ACTIVE\u0027 or \u0027DOWN\u0027."},{"line_number":787,"context_line":"        def wait_for_port_finish_building():"},{"line_number":788,"context_line":"            ports \u003d self._list_ports(device_id\u003dserver[\u0027id\u0027], fixed_ip\u003dip_addr)"},{"line_number":789,"context_line":"            return not [p for p in ports if p[\u0027status\u0027] not in p_status]"},{"line_number":790,"context_line":"        tempest.test.call_until_true(wait_for_port_finish_building,"},{"line_number":791,"context_line":"                                     CONF.network.build_timeout,"},{"line_number":792,"context_line":"                                     CONF.network.build_interval)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a8bc5a2_47e6b4e8","line":789,"updated":"2016-09-27 04:14:36.000000000","message":"like this?\n\n  return [p for p in ports if p[\u0027status\u0027] in \u0027BUILD\u0027]","commit_id":"e775e4cd19220772dea3e5f549222450aac4af06"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"1e3f354891d15ea2b697f8fc4740c72ca9abe7a4","unresolved":false,"context_lines":[{"line_number":786,"context_line":"        # \u0027ACTIVE\u0027 or \u0027DOWN\u0027."},{"line_number":787,"context_line":"        def wait_for_port_finish_building():"},{"line_number":788,"context_line":"            ports \u003d self._list_ports(device_id\u003dserver[\u0027id\u0027], fixed_ip\u003dip_addr)"},{"line_number":789,"context_line":"            return not [p for p in ports if p[\u0027status\u0027] not in p_status]"},{"line_number":790,"context_line":"        tempest.test.call_until_true(wait_for_port_finish_building,"},{"line_number":791,"context_line":"                                     CONF.network.build_timeout,"},{"line_number":792,"context_line":"                                     CONF.network.build_interval)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a8bc5a2_48f24107","line":789,"in_reply_to":"5a8bc5a2_47e6b4e8","updated":"2016-09-27 06:10:30.000000000","message":"ditto","commit_id":"e775e4cd19220772dea3e5f549222450aac4af06"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"1e3f354891d15ea2b697f8fc4740c72ca9abe7a4","unresolved":false,"context_lines":[{"line_number":799,"context_line":"                    and p[\u0027status\u0027] in p_status]"},{"line_number":800,"context_line":"        inactive \u003d [p for p in ports if p[\u0027status\u0027] !\u003d \u0027ACTIVE\u0027]"},{"line_number":801,"context_line":"        if inactive:"},{"line_number":802,"context_line":"            LOG.warning(\"Instance has ports that are not ACTIVE: %s\", inactive)"},{"line_number":803,"context_line":""},{"line_number":804,"context_line":"        self.assertNotEqual(0, len(port_map),"},{"line_number":805,"context_line":"                            \"No IPv4 addresses found in: %s\" % ports)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a8bc5a2_08ecb928","line":802,"updated":"2016-09-27 06:10:30.000000000","message":"hmm, in Ironic case, is this warning always logged? I feel it\u0027s not healthy if so.","commit_id":"e775e4cd19220772dea3e5f549222450aac4af06"}]}