)]}'
{"tempest/lib/services/compute/servers_client.py":[{"author":{"_account_id":17716,"name":"Luz Cazares","email":"luz.cazares@intel.com","username":"luzcazares"},"change_message_id":"e76da93483b1108e279a2d7b95972d2d83b40af8","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    def create_server(self, **kwargs):"},{"line_number":48,"context_line":"        \"\"\"Create server."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        The following params are usefull on this method:"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        :param name: Server name"},{"line_number":53,"context_line":"        :param imageRef: Image reference (UUID or full URL)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_2593fffb","line":50,"range":{"start_line":50,"start_character":33,"end_line":50,"end_character":40},"updated":"2016-09-09 18:51:57.000000000","message":"s/usefull/useful/g","commit_id":"d0e57bf948d9c6c22191b9e25d0dc599e325bb3e"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"0cf81eb871f395e8dd2015a167a0e513c59fa7c1","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    def create_server(self, **kwargs):"},{"line_number":48,"context_line":"        \"\"\"Create server."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        The following params are usefull on this method:"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        :param name: Server name"},{"line_number":53,"context_line":"        :param imageRef: Image reference (UUID or full URL)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_c0396143","line":50,"range":{"start_line":50,"start_character":33,"end_line":50,"end_character":40},"in_reply_to":"9a89bdaa_2593fffb","updated":"2016-09-09 19:12:23.000000000","message":"oh, nice catch.","commit_id":"d0e57bf948d9c6c22191b9e25d0dc599e325bb3e"},{"author":{"_account_id":17716,"name":"Luz Cazares","email":"luz.cazares@intel.com","username":"luzcazares"},"change_message_id":"e76da93483b1108e279a2d7b95972d2d83b40af8","unresolved":false,"context_lines":[{"line_number":202,"context_line":"        \"\"\""},{"line_number":203,"context_line":"        return self.action(server_id, \u0027changePassword\u0027, **kwargs)"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"    def show_password(self, server_id):"},{"line_number":206,"context_line":"        resp, body \u003d self.get(\"servers/%s/os-server-password\" %"},{"line_number":207,"context_line":"                              server_id)"},{"line_number":208,"context_line":"        body \u003d json.loads(body)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_e5af5729","line":205,"range":{"start_line":205,"start_character":8,"end_line":205,"end_character":39},"updated":"2016-09-09 18:51:57.000000000","message":"this can use some docstring too","commit_id":"d0e57bf948d9c6c22191b9e25d0dc599e325bb3e"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"0cf81eb871f395e8dd2015a167a0e513c59fa7c1","unresolved":false,"context_lines":[{"line_number":202,"context_line":"        \"\"\""},{"line_number":203,"context_line":"        return self.action(server_id, \u0027changePassword\u0027, **kwargs)"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"    def show_password(self, server_id):"},{"line_number":206,"context_line":"        resp, body \u003d self.get(\"servers/%s/os-server-password\" %"},{"line_number":207,"context_line":"                              server_id)"},{"line_number":208,"context_line":"        body \u003d json.loads(body)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_20f20d9b","line":205,"range":{"start_line":205,"start_character":8,"end_line":205,"end_character":39},"in_reply_to":"9a89bdaa_e5af5729","updated":"2016-09-09 19:12:23.000000000","message":"no, that is out of scope from this patch.\nIn addition, this method doesn\u0027t have any params. just server_id..","commit_id":"d0e57bf948d9c6c22191b9e25d0dc599e325bb3e"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"7e63fceb7b4b54f3c85795145fac43f181494fb5","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    def create_server(self, **kwargs):"},{"line_number":48,"context_line":"        \"\"\"Create server."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        The following params are useful on this method:"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        :param name: Server name"},{"line_number":53,"context_line":"        :param imageRef: Image reference (UUID or full URL)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a89bdaa_a05538c7","line":50,"updated":"2016-09-09 21:16:14.000000000","message":"I would drop this sentence completely.","commit_id":"ef6e56a2623be114579942153e889c997c542941"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"7e63fceb7b4b54f3c85795145fac43f181494fb5","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        :param imageRef: Image reference (UUID or full URL)"},{"line_number":54,"context_line":"        :param flavorRef: Flavor reference (UUID or full URL)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        Please see the following link to know other params:"},{"line_number":57,"context_line":"        http://developer.openstack.org/api-ref-compute-v2.1.html#createServer"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"        Most parameters except the following are passed to the API without"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a89bdaa_8046741f","line":56,"updated":"2016-09-09 21:16:14.000000000","message":"I would move this block to L50 and reword it to read:\n\n  For a full list of available parameters please refer to the official API reference:","commit_id":"ef6e56a2623be114579942153e889c997c542941"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e629b6a4d754ed6170cbbb80fea03ca686de22dd","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        For a full list of available parameters, please refer to the official"},{"line_number":51,"context_line":"        API reference:"},{"line_number":52,"context_line":"        http://developer.openstack.org/api-ref-compute-v2.1.html#createServer"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        :param name: Server name"},{"line_number":55,"context_line":"        :param imageRef: Image reference (UUID or full URL)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a8ec9b2_a0ba72be","line":52,"range":{"start_line":52,"start_character":8,"end_line":52,"end_character":77},"updated":"2016-09-15 07:49:54.000000000","message":"new link should be mentioned here, this seems old one which shows ImageRef as full url.\n\nhttp://developer.openstack.org/api-ref/compute/#create-server","commit_id":"df3a9566a7cfc43a46f56846b460e04ca2398e25"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e629b6a4d754ed6170cbbb80fea03ca686de22dd","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        http://developer.openstack.org/api-ref-compute-v2.1.html#createServer"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        :param name: Server name"},{"line_number":55,"context_line":"        :param imageRef: Image reference (UUID or full URL)"},{"line_number":56,"context_line":"        :param flavorRef: Flavor reference (UUID or full URL)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        Most parameters except the following are passed to the API without"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a8ec9b2_00a5e6a0","line":55,"range":{"start_line":55,"start_character":50,"end_line":55,"end_character":58},"updated":"2016-09-15 07:49:54.000000000","message":"this is not correct not. As you know we fixed ImageRef bug and it is always UUID on nova side.\n\nhttp://developer.openstack.org/api-ref/compute/#create-server","commit_id":"df3a9566a7cfc43a46f56846b460e04ca2398e25"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"eec87d4550359cbd4d2803e3fcd5d98db9925aa8","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        http://developer.openstack.org/api-ref/compute/#create-server"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        :param name: Server name"},{"line_number":55,"context_line":"        :param imageRef: Image reference (UUID)"},{"line_number":56,"context_line":"        :param flavorRef: Flavor reference (UUID or full URL)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        Most parameters except the following are passed to the API without"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a8ec9b2_0d121a57","line":55,"updated":"2016-09-16 20:05:36.000000000","message":"No URL on the imageRef?","commit_id":"d9bafc065862f88ab79f560ce52bff023519ba1c"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"67f1d9446ffe53e47ccc7dba1c42b515abbdabc9","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        http://developer.openstack.org/api-ref/compute/#create-server"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        :param name: Server name"},{"line_number":55,"context_line":"        :param imageRef: Image reference (UUID)"},{"line_number":56,"context_line":"        :param flavorRef: Flavor reference (UUID or full URL)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        Most parameters except the following are passed to the API without"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a8ec9b2_860b67d5","line":55,"in_reply_to":"7a8ec9b2_0d121a57","updated":"2016-09-16 21:45:01.000000000","message":"Yep, that was my wrong.\nNova denies URL of imageRef like https://github.com/openstack/nova/blob/master/nova/api/validation/parameter_types.py#L267","commit_id":"d9bafc065862f88ab79f560ce52bff023519ba1c"}]}