)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"84495de45aa68846b11304ecf7badc0553c538d6","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2016-09-26 05:36:14 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adding testcases for metadata def properties"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ic10f6967dc11424f447e74e3ed2aedba90c8a6b2"},{"line_number":10,"context_line":"Partial-bug: #1606533"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"5a8bc5a2_bf613c07","line":8,"updated":"2016-09-27 07:35:04.000000000","message":"Can you add some extra 2-3 lines description here?","commit_id":"2df63e6257126f7414a1bd5dfe533161db378126"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"2a11dcd086440f904d51a58180a4f7c706db96fb","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2016-09-27 04:06:38 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adding testcases for glance metadata def properties"},{"line_number":8,"context_line":"This commit contains testcases for"},{"line_number":9,"context_line":"      - add_metadata_def_namespace_properties"},{"line_number":10,"context_line":"      - get_metadata_def_namespace_properties"},{"line_number":11,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"5a8bc5a2_0b11dc5d","line":8,"updated":"2016-09-28 00:29:09.000000000","message":"A blank line is necessary between a title and its message.","commit_id":"6f5bc555d6048c8cbfccef43f0c826a60bb4fa69"}],"tempest/api/image/v2/test_images_metadefs_namespaces_properties.py":[{"author":{"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},"change_message_id":"33f7355b29e7752c0ad6c188c05c238b507bfaae","unresolved":false,"context_lines":[{"line_number":55,"context_line":"            ]"},{"line_number":56,"context_line":"        }"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        body \u003d self.namespaces_client.add_md_namespace_properties("},{"line_number":59,"context_line":"            namespace_name, property_name, params)"},{"line_number":60,"context_line":"        self.assertEqual(property_name, body[\u0027name\u0027])"},{"line_number":61,"context_line":"        body_prop \u003d self.namespaces_client.get_md_namespace_properties("}],"source_content_type":"text/x-python","patch_set":11,"id":"da6895a0_6e2a0980","line":58,"range":{"start_line":58,"start_character":38,"end_line":58,"end_character":41},"updated":"2016-10-25 19:30:31.000000000","message":"This should be \"create\" (since add was renamed to create in an earlier patchset).","commit_id":"265307c13eb5aea1fbeea9832e03b2adc14f1ab9"}],"tempest/lib/services/image/v2/namespaces_client.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"5b8b9e7bcea419f10cc53e5e26f6276dd5e52b28","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        url \u003d \u0027metadefs/namespaces/%s/properties\u0027 % namespace"},{"line_number":78,"context_line":"        description \u003d (\"The hypervisor type. It may be used \""},{"line_number":79,"context_line":"                       \"by the host properties filter for scheduling.\")"},{"line_number":80,"context_line":"        params \u003d {"},{"line_number":81,"context_line":"            \"description\": description,"},{"line_number":82,"context_line":"            \"name\": property_name,"},{"line_number":83,"context_line":"            \"title\": \"Hypervisor Type\","}],"source_content_type":"text/x-python","patch_set":4,"id":"7a8ec9b2_00f03866","line":80,"updated":"2016-09-16 12:43:02.000000000","message":"This is a generic client, you can\"t have specific values in there.\n\nYou should remove the \u0027params\u0027 dict from here, and have it in your test case instead.","commit_id":"c7373719c16b2db6a9151e0c9eebc1295d533528"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"2a11dcd086440f904d51a58180a4f7c706db96fb","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        self.expected_success(204, resp.status)"},{"line_number":74,"context_line":"        return rest_client.ResponseBody(resp)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def add_md_namespace_properties(self, namespace, property_name,"},{"line_number":77,"context_line":"                                    params, **kwargs):"},{"line_number":78,"context_line":"        url \u003d \u0027metadefs/namespaces/%s/properties\u0027 % namespace"},{"line_number":79,"context_line":"        for option in kwargs:"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a8bc5a2_8b0fab2d","line":76,"range":{"start_line":76,"start_character":53,"end_line":76,"end_character":66},"updated":"2016-09-28 00:29:09.000000000","message":"property_name is not used in this method, so it is not necessary.","commit_id":"6f5bc555d6048c8cbfccef43f0c826a60bb4fa69"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"2a11dcd086440f904d51a58180a4f7c706db96fb","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        self.expected_success(204, resp.status)"},{"line_number":74,"context_line":"        return rest_client.ResponseBody(resp)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def add_md_namespace_properties(self, namespace, property_name,"},{"line_number":77,"context_line":"                                    params, **kwargs):"},{"line_number":78,"context_line":"        url \u003d \u0027metadefs/namespaces/%s/properties\u0027 % namespace"},{"line_number":79,"context_line":"        for option in kwargs:"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a8bc5a2_cb30d3eb","line":76,"range":{"start_line":76,"start_character":8,"end_line":76,"end_character":11},"updated":"2016-09-28 00:29:09.000000000","message":"s/add/create/","commit_id":"6f5bc555d6048c8cbfccef43f0c826a60bb4fa69"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"2a11dcd086440f904d51a58180a4f7c706db96fb","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        return rest_client.ResponseBody(resp)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def add_md_namespace_properties(self, namespace, property_name,"},{"line_number":77,"context_line":"                                    params, **kwargs):"},{"line_number":78,"context_line":"        url \u003d \u0027metadefs/namespaces/%s/properties\u0027 % namespace"},{"line_number":79,"context_line":"        for option in kwargs:"},{"line_number":80,"context_line":"            value \u003d kwargs.get(option)"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a8bc5a2_ab4aa753","line":77,"range":{"start_line":77,"start_character":36,"end_line":77,"end_character":43},"updated":"2016-09-28 00:29:09.000000000","message":"How about using kwargs only without params?\n\nMost service clients(which are under tempest/lib/services) do that.","commit_id":"6f5bc555d6048c8cbfccef43f0c826a60bb4fa69"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"2a11dcd086440f904d51a58180a4f7c706db96fb","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        self.expected_success(201, resp.status)"},{"line_number":88,"context_line":"        return rest_client.ResponseBody(resp, json.loads(body))"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    def get_md_namespace_properties(self, namespace_id):"},{"line_number":91,"context_line":"        url \u003d \u0027metadefs/namespaces/%s/properties\u0027 % namespace_id"},{"line_number":92,"context_line":"        resp, body \u003d self.get(url)"},{"line_number":93,"context_line":"        self.expected_success(200, resp.status)"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a8bc5a2_2b569706","line":90,"range":{"start_line":90,"start_character":8,"end_line":90,"end_character":11},"updated":"2016-09-28 00:29:09.000000000","message":"s/get/list/","commit_id":"6f5bc555d6048c8cbfccef43f0c826a60bb4fa69"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"2a11dcd086440f904d51a58180a4f7c706db96fb","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        body \u003d json.loads(body)"},{"line_number":95,"context_line":"        return rest_client.ResponseBody(resp, body)"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    def get_md_namespace_property(self, namespace_id, property_name):"},{"line_number":98,"context_line":"        url \u003d (\u0027metadefs/namespaces/%s/properties/%s\u0027 %"},{"line_number":99,"context_line":"               (namespace_id, property_name))"},{"line_number":100,"context_line":"        resp, body \u003d self.get(url)"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a8bc5a2_8b3debbd","line":97,"range":{"start_line":97,"start_character":8,"end_line":97,"end_character":11},"updated":"2016-09-28 00:29:09.000000000","message":"s/get/show/","commit_id":"6f5bc555d6048c8cbfccef43f0c826a60bb4fa69"}]}