)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"160d8aa91f7266163ff9a7a09754b11a8cf49917","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Removed shebang inconsistency and added warning messages"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"* Shebang is used in python script to run it as a standalone script."},{"line_number":10,"context_line":"  But the some of script placed with in the tempest package have shebang"},{"line_number":11,"context_line":"  and some have not. It creates an inconsistency in the use of shebang."},{"line_number":12,"context_line":"  Although those scripts are used in setup.cfg to create to entrypoints"},{"line_number":13,"context_line":"  which already setuptools handles the creation of respective executable"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1a1ced50_06d026c8","line":10,"range":{"start_line":10,"start_character":6,"end_line":10,"end_character":24},"updated":"2017-03-23 13:07:09.000000000","message":"some of the scripts","commit_id":"d8cb58ee6717ad635d24da1512486ba6a02c5e2f"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"160d8aa91f7266163ff9a7a09754b11a8cf49917","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"* Shebang is used in python script to run it as a standalone script."},{"line_number":10,"context_line":"  But the some of script placed with in the tempest package have shebang"},{"line_number":11,"context_line":"  and some have not. It creates an inconsistency in the use of shebang."},{"line_number":12,"context_line":"  Although those scripts are used in setup.cfg to create to entrypoints"},{"line_number":13,"context_line":"  which already setuptools handles the creation of respective executable"},{"line_number":14,"context_line":"  scripts by adding shebang in /usr/bin dir. So t think there is no need of"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1a1ced50_3afc52b7","line":11,"range":{"start_line":11,"start_character":21,"end_line":11,"end_character":71},"updated":"2017-03-23 13:07:09.000000000","message":"I think than more than the shebang itself the difference is about implementing the __main__ method or not.\nEven without shebang, if __main__ is there one can still do python \u003cscript_name\u003e.","commit_id":"d8cb58ee6717ad635d24da1512486ba6a02c5e2f"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"160d8aa91f7266163ff9a7a09754b11a8cf49917","unresolved":false,"context_lines":[{"line_number":10,"context_line":"  But the some of script placed with in the tempest package have shebang"},{"line_number":11,"context_line":"  and some have not. It creates an inconsistency in the use of shebang."},{"line_number":12,"context_line":"  Although those scripts are used in setup.cfg to create to entrypoints"},{"line_number":13,"context_line":"  which already setuptools handles the creation of respective executable"},{"line_number":14,"context_line":"  scripts by adding shebang in /usr/bin dir. So t think there is no need of"},{"line_number":15,"context_line":"  placing shebang in these scripts."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"* shebang should be removed from already deprecated scripts."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1a1ced50_7d3324f6","line":14,"range":{"start_line":13,"start_character":16,"end_line":14,"end_character":43},"updated":"2017-03-23 13:07:09.000000000","message":"I\u0027m not entirely sure what this means.\nWe have different entry points:\n- console_sripts: these support executing some commands directly, as verify-tempest-config for instance\n- tempest.cm: these are tempest CLI subcommands, and allow to to execute some of the console scripts via the tempest UI, e.g. tempest verify-config","commit_id":"d8cb58ee6717ad635d24da1512486ba6a02c5e2f"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"f0a334041f8a6329e880fe7bfffb7e381ca0043e","unresolved":false,"context_lines":[{"line_number":11,"context_line":"  and some have not. It creates an inconsistency in the use of shebang."},{"line_number":12,"context_line":"  Although those scripts are used in setup.cfg to create to entrypoints"},{"line_number":13,"context_line":"  which already setuptools handles the creation of respective executable"},{"line_number":14,"context_line":"  scripts by adding shebang in /usr/bin dir. So t think there is no need of"},{"line_number":15,"context_line":"  placing shebang in these scripts."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"* shebang should be removed from already deprecated scripts."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1a1ced50_d5b43136","line":14,"updated":"2017-03-22 08:46:20.000000000","message":"s/So t/So I","commit_id":"d8cb58ee6717ad635d24da1512486ba6a02c5e2f"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"160d8aa91f7266163ff9a7a09754b11a8cf49917","unresolved":false,"context_lines":[{"line_number":14,"context_line":"  scripts by adding shebang in /usr/bin dir. So t think there is no need of"},{"line_number":15,"context_line":"  placing shebang in these scripts."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"* shebang should be removed from already deprecated scripts."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"* Added warning message to existing script having shebang."},{"line_number":20,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1a1ced50_da3c1e95","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":60},"updated":"2017-03-23 13:07:09.000000000","message":"I\u0027m not sure what you mean here? \nI see in the code that you removed the shebang from scripts that do not implement __main__. I agree it does not make much sense to have a shebang there - but why do you say those scripts are deprecated?","commit_id":"d8cb58ee6717ad635d24da1512486ba6a02c5e2f"}],"tempest/cmd/verify_tempest_config.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"c22a91defaea3c7fc85c26550cb57c8145011931","unresolved":false,"context_lines":[{"line_number":428,"context_line":"if __name__ \u003d\u003d \"__main__\":"},{"line_number":429,"context_line":"    print(\"WARNING: tempest/cmd/verify_tempest_config.py script is deprecated\""},{"line_number":430,"context_line":"          \" and will be removed in the near future release. \""},{"line_number":431,"context_line":"          \"Please use to tempest verify-config command.\")"},{"line_number":432,"context_line":"    main()"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a6eadb0_e35d8cea","line":431,"updated":"2016-12-13 14:28:24.000000000","message":"verify_tempest_config.py is not deprecated and there\u0027s no intention to remove it.","commit_id":"42aa6673fe4626a88b2b19baee4e3b8cc2d77ea7"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"a16a93299d07e485e4f89139c5ecddb1a4c9cb93","unresolved":false,"context_lines":[{"line_number":428,"context_line":"if __name__ \u003d\u003d \"__main__\":"},{"line_number":429,"context_line":"    print(\"WARNING: tempest/cmd/verify_tempest_config.py script is deprecated\""},{"line_number":430,"context_line":"          \" and will be removed in the near future release. \""},{"line_number":431,"context_line":"          \"Please use to tempest verify-config command.\")"},{"line_number":432,"context_line":"    main()"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a6eadb0_529d2764","line":431,"in_reply_to":"1a6eadb0_e35d8cea","updated":"2016-12-13 14:59:30.000000000","message":"I have started writting this patch to fix the inconsistency in the use of shebang. Some of the tempest script is used directly. like python tempest/cmd/verify_tempest_config.py.\nFirst we wanted to warn the users that following standalone script will be deprecated before removing the shebang. so that user should shift to actual command \"check-uuid\". I might be wrong in wording. Please correct there.","commit_id":"42aa6673fe4626a88b2b19baee4e3b8cc2d77ea7"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"160d8aa91f7266163ff9a7a09754b11a8cf49917","unresolved":false,"context_lines":[{"line_number":426,"context_line":"            raise"},{"line_number":427,"context_line":""},{"line_number":428,"context_line":"if __name__ \u003d\u003d \"__main__\":"},{"line_number":429,"context_line":"    print(\"WARNING: tempest/cmd/verify_tempest_config.py script is deprecated\""},{"line_number":430,"context_line":"          \" and will be removed in the near future release. \""},{"line_number":431,"context_line":"          \"Please use to tempest verify-config command.\")"},{"line_number":432,"context_line":"    main()"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a1ced50_bd767ca1","line":429,"range":{"start_line":429,"start_character":20,"end_line":429,"end_character":77},"updated":"2017-03-23 13:07:09.000000000","message":"I think this is a bit misleading. The script is not deprecated. Invoking it directly is.","commit_id":"d8cb58ee6717ad635d24da1512486ba6a02c5e2f"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"160d8aa91f7266163ff9a7a09754b11a8cf49917","unresolved":false,"context_lines":[{"line_number":427,"context_line":""},{"line_number":428,"context_line":"if __name__ \u003d\u003d \"__main__\":"},{"line_number":429,"context_line":"    print(\"WARNING: tempest/cmd/verify_tempest_config.py script is deprecated\""},{"line_number":430,"context_line":"          \" and will be removed in the near future release. \""},{"line_number":431,"context_line":"          \"Please use to tempest verify-config command.\")"},{"line_number":432,"context_line":"    main()"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a1ced50_7d75e42f","line":430,"range":{"start_line":430,"start_character":35,"end_line":430,"end_character":43},"updated":"2017-03-23 13:07:09.000000000","message":"a","commit_id":"d8cb58ee6717ad635d24da1512486ba6a02c5e2f"}],"tempest/lib/cmd/check_uuid.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"c22a91defaea3c7fc85c26550cb57c8145011931","unresolved":false,"context_lines":[{"line_number":359,"context_line":"if __name__ \u003d\u003d \u0027__main__\u0027:"},{"line_number":360,"context_line":"    print(\"WARNING: tempest/lib/cmd/check_uuid.py script is deprecated and \""},{"line_number":361,"context_line":"          \"will be removed in the near future release. \""},{"line_number":362,"context_line":"          \"Please migrate to check-uuid command.\")"},{"line_number":363,"context_line":"    run()"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a6eadb0_63189c1e","line":362,"updated":"2016-12-13 14:28:24.000000000","message":"check_uuid.py is not deprecated and there\u0027s no intention to remove it.","commit_id":"42aa6673fe4626a88b2b19baee4e3b8cc2d77ea7"}]}