)]}'
{"tempest/common/utils/net_utils.py":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"6a5909c6fc0025cd3c03a1917d1ee171ea165cc4","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    res \u003d mtu - ip_header - icmp_header"},{"line_number":67,"context_line":"    if res \u003c 0:"},{"line_number":68,"context_line":"        raise lib_exc.BadRequest("},{"line_number":69,"context_line":"            message\u003d\u0027MTU \u003d %(mtu)d is too low for IPv%(ip_version)d\u0027 % {"},{"line_number":70,"context_line":"                \u0027mtu\u0027: mtu,"},{"line_number":71,"context_line":"                \u0027ip_version\u0027: ip_version,"},{"line_number":72,"context_line":"            })"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a8bc5a2_835cd926","line":69,"updated":"2016-09-22 17:38:16.000000000","message":"The minimum MTU for IPv4 is 68 (RFC791), for IPv6 it is 1280 (RFC2460), so it seems strange that we need this check here.","commit_id":"de45d39ff5a764546a820436a9dde97758c206d3"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b5be89f56ab8f131f43967b9b26a50844952313b","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    res \u003d mtu - ip_header - icmp_header"},{"line_number":67,"context_line":"    if res \u003c 0:"},{"line_number":68,"context_line":"        raise lib_exc.BadRequest("},{"line_number":69,"context_line":"            message\u003d\u0027MTU \u003d %(mtu)d is too low for IPv%(ip_version)d\u0027 % {"},{"line_number":70,"context_line":"                \u0027mtu\u0027: mtu,"},{"line_number":71,"context_line":"                \u0027ip_version\u0027: ip_version,"},{"line_number":72,"context_line":"            })"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a8bc5a2_636d0d04","line":69,"in_reply_to":"5a8bc5a2_835cd926","updated":"2016-09-22 17:43:27.000000000","message":"It\u0027s not about RFC, it\u0027s about making the function behave meaningfully (failing) on mtu value passed that would not allow space for icmp headers.\n\nYes, callers will probably not pass bad values here, but it\u0027s not great to rely on callers doing the right thing. Explicitly failing on bad input seems like a safer strategy.","commit_id":"de45d39ff5a764546a820436a9dde97758c206d3"}],"tempest/scenario/manager.py":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"6a5909c6fc0025cd3c03a1917d1ee171ea165cc4","unresolved":false,"context_lines":[{"line_number":917,"context_line":"        :param dest: and IP to ping against"},{"line_number":918,"context_line":"        :param should_succeed: boolean should ping succeed or not"},{"line_number":919,"context_line":"        :param nic: specific network interface to ping from"},{"line_number":920,"context_line":"        :param mtu: specific MTU size used to form the ICMP message"},{"line_number":921,"context_line":"        :returns: boolean -- should_succeed \u003d\u003d ping"},{"line_number":922,"context_line":"        :returns: ping is false if ping failed"},{"line_number":923,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"5a8bc5a2_43bf31d0","line":920,"updated":"2016-09-22 17:38:16.000000000","message":"Adding this description here without adding the parameter to the function looks wrong to me.","commit_id":"de45d39ff5a764546a820436a9dde97758c206d3"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b5be89f56ab8f131f43967b9b26a50844952313b","unresolved":false,"context_lines":[{"line_number":917,"context_line":"        :param dest: and IP to ping against"},{"line_number":918,"context_line":"        :param should_succeed: boolean should ping succeed or not"},{"line_number":919,"context_line":"        :param nic: specific network interface to ping from"},{"line_number":920,"context_line":"        :param mtu: specific MTU size used to form the ICMP message"},{"line_number":921,"context_line":"        :returns: boolean -- should_succeed \u003d\u003d ping"},{"line_number":922,"context_line":"        :returns: ping is false if ping failed"},{"line_number":923,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"5a8bc5a2_43657143","line":920,"in_reply_to":"5a8bc5a2_43bf31d0","updated":"2016-09-22 17:43:27.000000000","message":"Done","commit_id":"de45d39ff5a764546a820436a9dde97758c206d3"}],"tempest/scenario/test_network_basic_ops.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"ba92ef50cb7813560c053efd05c63326b39e75a2","unresolved":false,"context_lines":[{"line_number":411,"context_line":"                                               msg\u003d\"after re-associate \""},{"line_number":412,"context_line":"                                                   \"floating ip\")"},{"line_number":413,"context_line":""},{"line_number":414,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":415,"context_line":"    @test.idempotent_id(\u0027b158ea55-472e-4086-8fa9-c64ac0c6c1d0\u0027)"},{"line_number":416,"context_line":"    @testtools.skipIf(not test.is_extension_enabled(\u0027net-mtu\u0027, \u0027network\u0027),"},{"line_number":417,"context_line":"                      \u0027No way to calculate MTU for networks\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_7972f512","line":414,"updated":"2016-09-20 17:04:12.000000000","message":"56 seconds... Not sure if this qualifies as smoke.","commit_id":"888cdd6a24a2ef01f67c4b7d963ae804644ecc5b"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"c539620057b259b4af168107efa9c53473b03437","unresolved":false,"context_lines":[{"line_number":411,"context_line":"                                               msg\u003d\"after re-associate \""},{"line_number":412,"context_line":"                                                   \"floating ip\")"},{"line_number":413,"context_line":""},{"line_number":414,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":415,"context_line":"    @test.idempotent_id(\u0027b158ea55-472e-4086-8fa9-c64ac0c6c1d0\u0027)"},{"line_number":416,"context_line":"    @testtools.skipIf(not test.is_extension_enabled(\u0027net-mtu\u0027, \u0027network\u0027),"},{"line_number":417,"context_line":"                      \u0027No way to calculate MTU for networks\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_d47e44ae","line":414,"in_reply_to":"7a8ec9b2_7972f512","updated":"2016-09-21 10:48:24.000000000","message":"I will remove the tag. It would be nice to have it as part of grenade runs that afaik trigger just smoke tests, but I guess it is not a too big deal as long as we have a scenario for consumers to validate their setups.","commit_id":"888cdd6a24a2ef01f67c4b7d963ae804644ecc5b"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"ba92ef50cb7813560c053efd05c63326b39e75a2","unresolved":false,"context_lines":[{"line_number":413,"context_line":""},{"line_number":414,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":415,"context_line":"    @test.idempotent_id(\u0027b158ea55-472e-4086-8fa9-c64ac0c6c1d0\u0027)"},{"line_number":416,"context_line":"    @testtools.skipIf(not test.is_extension_enabled(\u0027net-mtu\u0027, \u0027network\u0027),"},{"line_number":417,"context_line":"                      \u0027No way to calculate MTU for networks\u0027)"},{"line_number":418,"context_line":"    @test.services(\u0027compute\u0027, \u0027network\u0027)"},{"line_number":419,"context_line":"    def test_mtu_sized_frames(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_99c6e114","line":416,"updated":"2016-09-20 17:04:12.000000000","message":"Use testtools.skipUnless. It\u0027s a bit clearer than \u0027skip if not\u0027.","commit_id":"888cdd6a24a2ef01f67c4b7d963ae804644ecc5b"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"c539620057b259b4af168107efa9c53473b03437","unresolved":false,"context_lines":[{"line_number":413,"context_line":""},{"line_number":414,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":415,"context_line":"    @test.idempotent_id(\u0027b158ea55-472e-4086-8fa9-c64ac0c6c1d0\u0027)"},{"line_number":416,"context_line":"    @testtools.skipIf(not test.is_extension_enabled(\u0027net-mtu\u0027, \u0027network\u0027),"},{"line_number":417,"context_line":"                      \u0027No way to calculate MTU for networks\u0027)"},{"line_number":418,"context_line":"    @test.services(\u0027compute\u0027, \u0027network\u0027)"},{"line_number":419,"context_line":"    def test_mtu_sized_frames(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_f47b40bc","line":416,"in_reply_to":"7a8ec9b2_99c6e114","updated":"2016-09-21 10:48:24.000000000","message":"Done","commit_id":"888cdd6a24a2ef01f67c4b7d963ae804644ecc5b"}]}