)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"0df7fda6b7f489b3f119f025f47ccc89f083e46e","unresolved":false,"context_lines":[{"line_number":14,"context_line":"the `store_image_file` method of the glance client is already tested"},{"line_number":15,"context_line":"in the `test_register_upload_get_image_file` API test."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Finally, the whole upload-an-image to Glance and boot a server from"},{"line_number":18,"context_line":"that image is already tested in the scenario test_snapshot_pattern."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I665bfe1bb8e803b73066f613da3204e5c0683dcf"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"ffe62b97_49c89c72","line":18,"range":{"start_line":17,"start_character":0,"end_line":18,"end_character":67},"updated":"2017-03-29 14:37:11.000000000","message":"I don\u0027t fully agree, because in case of test_snapshot_pattern, the image is created by nova. The resulting image is owned by the tenant so it should be similar, but I don\u0027t see a need to fully remove from tempest the glance_image_create.\n\nThe original deprecation was done with the removal of AWS format images only.\nThis commits instead removes the glance_create_image completely, and it leaves a few unused and non-deprecated options around.\n\nI think it would be best to finish the cleanup that was started by removing the deprecated options and simplifying the logic of glance_image_create.\nThe only problem I see is that CONF.scenario.img_file is currently a name relative to CONF.scenario.img_dir, and changing that would be a backward incompatible change with no deprecation... so perhaps we should keep CONF.scenario.img_dir instead and remove the deprecation?","commit_id":"128c58af0ead04b4a8e01fa5594aad631743b67b"}],"tempest/config.py":[{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"0df7fda6b7f489b3f119f025f47ccc89f083e46e","unresolved":false,"context_lines":[{"line_number":941,"context_line":"scenario_group \u003d cfg.OptGroup(name\u003d\u0027scenario\u0027, title\u003d\u0027Scenario Test Options\u0027)"},{"line_number":942,"context_line":""},{"line_number":943,"context_line":"ScenarioGroup \u003d ["},{"line_number":944,"context_line":"    cfg.StrOpt(\u0027img_dir\u0027,"},{"line_number":945,"context_line":"               default\u003d\u0027/opt/stack/new/devstack/files/images/\u0027"},{"line_number":946,"context_line":"               \u0027cirros-0.3.1-x86_64-uec\u0027,"},{"line_number":947,"context_line":"               help\u003d\u0027Directory containing image files\u0027,"},{"line_number":948,"context_line":"               deprecated_for_removal\u003dTrue),"},{"line_number":949,"context_line":"    cfg.StrOpt(\u0027img_file\u0027, deprecated_name\u003d\u0027qcow2_img_file\u0027,"},{"line_number":950,"context_line":"               default\u003d\u0027cirros-0.3.1-x86_64-disk.img\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"ffe62b97_cecf1227","line":947,"range":{"start_line":944,"start_character":0,"end_line":947,"end_character":55},"updated":"2017-03-29 14:37:11.000000000","message":"This one was deprecated along with the three options below, and it should be removed as well.\n\nSee I8a6ee167384c8a2d17905db3a4061c06398980ad and https://bugs.launchpad.net/tempest/+bug/1393881.","commit_id":"128c58af0ead04b4a8e01fa5594aad631743b67b"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"0df7fda6b7f489b3f119f025f47ccc89f083e46e","unresolved":false,"context_lines":[{"line_number":946,"context_line":"               \u0027cirros-0.3.1-x86_64-uec\u0027,"},{"line_number":947,"context_line":"               help\u003d\u0027Directory containing image files\u0027,"},{"line_number":948,"context_line":"               deprecated_for_removal\u003dTrue),"},{"line_number":949,"context_line":"    cfg.StrOpt(\u0027img_file\u0027, deprecated_name\u003d\u0027qcow2_img_file\u0027,"},{"line_number":950,"context_line":"               default\u003d\u0027cirros-0.3.1-x86_64-disk.img\u0027,"},{"line_number":951,"context_line":"               help\u003d\u0027Image file name\u0027),"},{"line_number":952,"context_line":"    cfg.StrOpt(\u0027img_disk_format\u0027,"},{"line_number":953,"context_line":"               default\u003d\u0027qcow2\u0027,"},{"line_number":954,"context_line":"               help\u003d\u0027Image disk format\u0027),"},{"line_number":955,"context_line":"    cfg.StrOpt(\u0027img_container_format\u0027,"},{"line_number":956,"context_line":"               default\u003d\u0027bare\u0027,"},{"line_number":957,"context_line":"               help\u003d\u0027Image container format\u0027),"},{"line_number":958,"context_line":"    cfg.DictOpt(\u0027img_properties\u0027, help\u003d\u0027Glance image properties. \u0027"},{"line_number":959,"context_line":"                \u0027Use for custom images which require them\u0027),"},{"line_number":960,"context_line":"    # TODO(yfried): add support for dhcpcd"}],"source_content_type":"text/x-python","patch_set":5,"id":"ffe62b97_69924059","line":957,"range":{"start_line":949,"start_character":0,"end_line":957,"end_character":46},"updated":"2017-03-29 14:37:11.000000000","message":"These are now not used and not deprecated...","commit_id":"128c58af0ead04b4a8e01fa5594aad631743b67b"}]}