)]}'
{"tempest/api/compute/admin/test_migrations.py":[{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"12e75210adea95f45ccf225f8994ac7cce21da44","unresolved":false,"context_lines":[{"line_number":106,"context_line":"        server \u003d self.servers_client.show_server(server[\u0027id\u0027])[\u0027server\u0027]"},{"line_number":107,"context_line":"        self.assertEqual(flavor[\u0027id\u0027], server[\u0027flavor\u0027][\u0027id\u0027])"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    def _test_cold_migrate_server(self, revert):"},{"line_number":110,"context_line":"        host_client \u003d self.admin_hosts_client"},{"line_number":111,"context_line":"        hosts \u003d host_client.list_hosts()[\u0027hosts\u0027]"},{"line_number":112,"context_line":"        computes \u003d [x for x in hosts if x[\u0027service\u0027] \u003d\u003d \u0027compute\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_e113995a","line":109,"updated":"2016-09-21 01:05:37.000000000","message":"revert\u003dFalse\n\nas a safeguard","commit_id":"a894c59628e10d671f405d7504755de07f75fc7b"},{"author":{"_account_id":17973,"name":"Ludovic Beliveau","email":"lbeliveau@gmail.com","username":"lbeliveau"},"change_message_id":"a06fd0f3a3ab2ef7cd303e71e4cf5ae53fe55dc0","unresolved":false,"context_lines":[{"line_number":106,"context_line":"        server \u003d self.servers_client.show_server(server[\u0027id\u0027])[\u0027server\u0027]"},{"line_number":107,"context_line":"        self.assertEqual(flavor[\u0027id\u0027], server[\u0027flavor\u0027][\u0027id\u0027])"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    def _test_cold_migrate_server(self, revert):"},{"line_number":110,"context_line":"        host_client \u003d self.admin_hosts_client"},{"line_number":111,"context_line":"        hosts \u003d host_client.list_hosts()[\u0027hosts\u0027]"},{"line_number":112,"context_line":"        computes \u003d [x for x in hosts if x[\u0027service\u0027] \u003d\u003d \u0027compute\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_e303800e","line":109,"in_reply_to":"7a8ec9b2_e113995a","updated":"2016-09-21 11:58:45.000000000","message":"Done","commit_id":"a894c59628e10d671f405d7504755de07f75fc7b"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"12e75210adea95f45ccf225f8994ac7cce21da44","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        waiters.wait_for_server_status(self.servers_client,"},{"line_number":124,"context_line":"                                       server[\u0027id\u0027], \u0027VERIFY_RESIZE\u0027)"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        if (not revert):"},{"line_number":127,"context_line":"            self.servers_client.confirm_resize_server(server[\u0027id\u0027])"},{"line_number":128,"context_line":"            waiters.wait_for_server_status(self.servers_client,"},{"line_number":129,"context_line":"                                           server[\u0027id\u0027], \u0027ACTIVE\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_4119ad78","line":126,"updated":"2016-09-21 01:05:37.000000000","message":"swap the content in the if-else so it can be \n\nif revert:\n\ninstead","commit_id":"a894c59628e10d671f405d7504755de07f75fc7b"},{"author":{"_account_id":17973,"name":"Ludovic Beliveau","email":"lbeliveau@gmail.com","username":"lbeliveau"},"change_message_id":"a06fd0f3a3ab2ef7cd303e71e4cf5ae53fe55dc0","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        waiters.wait_for_server_status(self.servers_client,"},{"line_number":124,"context_line":"                                       server[\u0027id\u0027], \u0027VERIFY_RESIZE\u0027)"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        if (not revert):"},{"line_number":127,"context_line":"            self.servers_client.confirm_resize_server(server[\u0027id\u0027])"},{"line_number":128,"context_line":"            waiters.wait_for_server_status(self.servers_client,"},{"line_number":129,"context_line":"                                           server[\u0027id\u0027], \u0027ACTIVE\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_d5663bec","line":126,"in_reply_to":"7a8ec9b2_4119ad78","updated":"2016-09-21 11:58:45.000000000","message":"Done","commit_id":"a894c59628e10d671f405d7504755de07f75fc7b"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"7ce0e887dcaf2619f94cbdbbc0c8447732b005b4","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        waiters.wait_for_server_status(self.servers_client,"},{"line_number":121,"context_line":"                                       server[\u0027id\u0027], \u0027VERIFY_RESIZE\u0027)"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        if (revert):"},{"line_number":124,"context_line":"            self.servers_client.revert_resize_server(server[\u0027id\u0027])"},{"line_number":125,"context_line":"            waiters.wait_for_server_status(self.servers_client,"},{"line_number":126,"context_line":"                                           server[\u0027id\u0027], \u0027ACTIVE\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a98d1f4_bbfc2e73","line":123,"range":{"start_line":123,"start_character":11,"end_line":123,"end_character":19},"updated":"2016-09-30 17:22:11.000000000","message":"nit: () seems unnecessary..","commit_id":"d97c552bec9a8657f7736e8af4c66625437baeea"},{"author":{"_account_id":17973,"name":"Ludovic Beliveau","email":"lbeliveau@gmail.com","username":"lbeliveau"},"change_message_id":"5239d631ca5b466cc36643bed54fd0a235fdad85","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        waiters.wait_for_server_status(self.servers_client,"},{"line_number":121,"context_line":"                                       server[\u0027id\u0027], \u0027VERIFY_RESIZE\u0027)"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        if (revert):"},{"line_number":124,"context_line":"            self.servers_client.revert_resize_server(server[\u0027id\u0027])"},{"line_number":125,"context_line":"            waiters.wait_for_server_status(self.servers_client,"},{"line_number":126,"context_line":"                                           server[\u0027id\u0027], \u0027ACTIVE\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a98d1f4_5e5eb812","line":123,"range":{"start_line":123,"start_character":11,"end_line":123,"end_character":19},"in_reply_to":"3a98d1f4_bbfc2e73","updated":"2016-09-30 17:34:57.000000000","message":"Done","commit_id":"d97c552bec9a8657f7736e8af4c66625437baeea"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"7ce0e887dcaf2619f94cbdbbc0c8447732b005b4","unresolved":false,"context_lines":[{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        if (revert):"},{"line_number":124,"context_line":"            self.servers_client.revert_resize_server(server[\u0027id\u0027])"},{"line_number":125,"context_line":"            waiters.wait_for_server_status(self.servers_client,"},{"line_number":126,"context_line":"                                           server[\u0027id\u0027], \u0027ACTIVE\u0027)"},{"line_number":127,"context_line":"            dst_host \u003d self.admin_servers_client.show_server("},{"line_number":128,"context_line":"                server[\u0027id\u0027])[\u0027server\u0027][\u0027OS-EXT-SRV-ATTR:host\u0027]"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"            self.assertEqual(src_host, dst_host)"},{"line_number":131,"context_line":"        else:"},{"line_number":132,"context_line":"            self.servers_client.confirm_resize_server(server[\u0027id\u0027])"},{"line_number":133,"context_line":"            waiters.wait_for_server_status(self.servers_client,"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a98d1f4_1b544251","line":130,"range":{"start_line":125,"start_character":0,"end_line":130,"end_character":48},"updated":"2016-09-30 17:22:11.000000000","message":"nit: This part is almost duplicated with the following.\n\nHow about\n\n if revert:\n     self.servers_client.revert_resize_server(server[\u0027id\u0027])\n     assert_func \u003d self.assertEqual\n else\n     self.servers_client.confirm_resize_server(server[\u0027id\u0027])\n     assert_func \u003d self.assertNotEqual\n\n waiters.wait_for_server_status(self.servers_client,\n                                server[\u0027id\u0027], \u0027ACTIVE\u0027)\n dst_host \u003d self.admin_servers_client.show_server(\n    server[\u0027id\u0027])[\u0027server\u0027][\u0027OS-EXT-SRV-ATTR:host\u0027]\n\n assert_func(src_host, dst_host)\n\nBut the above is also a little tricky. So current one is already good for me.","commit_id":"d97c552bec9a8657f7736e8af4c66625437baeea"},{"author":{"_account_id":17973,"name":"Ludovic Beliveau","email":"lbeliveau@gmail.com","username":"lbeliveau"},"change_message_id":"5239d631ca5b466cc36643bed54fd0a235fdad85","unresolved":false,"context_lines":[{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        if (revert):"},{"line_number":124,"context_line":"            self.servers_client.revert_resize_server(server[\u0027id\u0027])"},{"line_number":125,"context_line":"            waiters.wait_for_server_status(self.servers_client,"},{"line_number":126,"context_line":"                                           server[\u0027id\u0027], \u0027ACTIVE\u0027)"},{"line_number":127,"context_line":"            dst_host \u003d self.admin_servers_client.show_server("},{"line_number":128,"context_line":"                server[\u0027id\u0027])[\u0027server\u0027][\u0027OS-EXT-SRV-ATTR:host\u0027]"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"            self.assertEqual(src_host, dst_host)"},{"line_number":131,"context_line":"        else:"},{"line_number":132,"context_line":"            self.servers_client.confirm_resize_server(server[\u0027id\u0027])"},{"line_number":133,"context_line":"            waiters.wait_for_server_status(self.servers_client,"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a98d1f4_3e02ccb4","line":130,"range":{"start_line":125,"start_character":0,"end_line":130,"end_character":48},"in_reply_to":"3a98d1f4_1b544251","updated":"2016-09-30 17:34:57.000000000","message":"Good idea.\n\nDone","commit_id":"d97c552bec9a8657f7736e8af4c66625437baeea"}]}