)]}'
{"tempest/api/volume/test_snapshot_metadata.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"94d8af8ba9cb6e3564c90bc04ef75f114718fe7e","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    @test.idempotent_id(\u0027a2f20f99-e363-4584-be97-bc33afb1a56c\u0027)"},{"line_number":44,"context_line":"    def test_create_get_delete_snapshot_metadata(self):"},{"line_number":45,"context_line":"        snapshot \u003d self.create_snapshot(volume_id\u003dself.volume[\u0027id\u0027])"},{"line_number":46,"context_line":"        snapshot_id \u003d snapshot[\u0027id\u0027]"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        # Create metadata for the snapshot"},{"line_number":49,"context_line":"        metadata \u003d {\"key1\": \"value1\","}],"source_content_type":"text/x-python","patch_set":11,"id":"5a8bc5a2_0ce17a9a","line":46,"updated":"2016-09-25 18:37:27.000000000","message":"Not sure it\u0027s really worth introducing a new variable just to save 2 chars. I mean maybe you could use snapshot[\u0027id\u0027] everywhere instead. \n\nOr just do snapshot_id \u003d self.create_snapshot(volume_id\u003dself.volume[\u0027id\u0027])[\u0027id\u0027]","commit_id":"68536fa661ea327f7be31c009d18e494418f239a"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"91e90eed91b2c67e0ecb1c17f186eb5bb7052c16","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    @test.idempotent_id(\u0027a2f20f99-e363-4584-be97-bc33afb1a56c\u0027)"},{"line_number":44,"context_line":"    def test_create_get_delete_snapshot_metadata(self):"},{"line_number":45,"context_line":"        snapshot \u003d self.create_snapshot(volume_id\u003dself.volume[\u0027id\u0027])"},{"line_number":46,"context_line":"        snapshot_id \u003d snapshot[\u0027id\u0027]"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        # Create metadata for the snapshot"},{"line_number":49,"context_line":"        metadata \u003d {\"key1\": \"value1\","}],"source_content_type":"text/x-python","patch_set":11,"id":"5a8bc5a2_a155e8fa","line":46,"in_reply_to":"5a8bc5a2_0ce17a9a","updated":"2016-09-26 05:54:45.000000000","message":"Thanks for your comment, I\u0027ll fix it","commit_id":"68536fa661ea327f7be31c009d18e494418f239a"}],"tempest/api/volume/test_volumes_snapshots.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"94d8af8ba9cb6e3564c90bc04ef75f114718fe7e","unresolved":false,"context_lines":[{"line_number":100,"context_line":"        self.assertEqual(new_s_name, updated_snapshot[self.name_field])"},{"line_number":101,"context_line":"        self.assertEqual(new_desc, updated_snapshot[self.descrip_field])"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    @decorators.skip_because(bug\u003d\u00271627510\u0027)"},{"line_number":104,"context_line":"    @test.idempotent_id(\u0027677863d1-3142-456d-b6ac-9924f667a7f4\u0027)"},{"line_number":105,"context_line":"    def test_volume_from_snapshot(self):"},{"line_number":106,"context_line":"        # Creates a volume a snapshot passing a size different from the source"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a8bc5a2_ac04064a","line":103,"updated":"2016-09-25 18:37:27.000000000","message":"That\u0027s wrong.\n\nThat should be a patch on its own. Also, skipping a test just because it fails with Ceph is wrong. There are more than 50 drivers in Cinder and they deserve to be tested too.","commit_id":"68536fa661ea327f7be31c009d18e494418f239a"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"91e90eed91b2c67e0ecb1c17f186eb5bb7052c16","unresolved":false,"context_lines":[{"line_number":100,"context_line":"        self.assertEqual(new_s_name, updated_snapshot[self.name_field])"},{"line_number":101,"context_line":"        self.assertEqual(new_desc, updated_snapshot[self.descrip_field])"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    @decorators.skip_because(bug\u003d\u00271627510\u0027)"},{"line_number":104,"context_line":"    @test.idempotent_id(\u0027677863d1-3142-456d-b6ac-9924f667a7f4\u0027)"},{"line_number":105,"context_line":"    def test_volume_from_snapshot(self):"},{"line_number":106,"context_line":"        # Creates a volume a snapshot passing a size different from the source"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a8bc5a2_218f1876","line":103,"in_reply_to":"5a8bc5a2_ac04064a","updated":"2016-09-26 05:54:45.000000000","message":"I agree with you, but how can I skip only on Ceph driver?\nIs there an option to test all other drivers except Ceph driver?\nIf yes, I\u0027ll happy to know how","commit_id":"68536fa661ea327f7be31c009d18e494418f239a"},{"author":{"_account_id":16437,"name":"Anna Babich","email":"anna.v.babich@gmail.com","username":"ababich"},"change_message_id":"dce3f3337a9c275abe7d423196b3b9c314490056","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        self.assertEqual(new_desc, updated_snapshot[self.descrip_field])"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    @test.idempotent_id(\u0027677863d1-3142-456d-b6ac-9924f667a7f4\u0027)"},{"line_number":105,"context_line":"    @testtools.skipUnless(CONF.volume.storage_protocol \u003d\u003d \u0027Ceph\u0027,"},{"line_number":106,"context_line":"                          \u0027There is a bug in Ceph driver\u0027"},{"line_number":107,"context_line":"                          \u0027https://bugs.launchpad.net/cinder/+bug/1627510\u0027)"},{"line_number":108,"context_line":"    def test_volume_from_snapshot(self):"}],"source_content_type":"text/x-python","patch_set":13,"id":"1a95cdbc_b40ae8d0","line":105,"updated":"2016-10-05 12:06:43.000000000","message":"If you want to skip the case for Ceph only, use skipIf, not skipUnless. Otherwise,the case will be skipped for all drivers, except Ceph: \n@testtools.skipIf(CONF.volume.storage_protocol \u003d\u003d \u0027ceph\u0027,\n...)","commit_id":"7ed277eb613b0d65cd9b57fd2f0c29d3467ddbed"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"0a7f8dacec810d86ffd36c71e2ee178160be6bf3","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        self.assertEqual(new_desc, updated_snapshot[self.descrip_field])"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    @test.idempotent_id(\u0027677863d1-3142-456d-b6ac-9924f667a7f4\u0027)"},{"line_number":105,"context_line":"    @testtools.skipUnless(CONF.volume.storage_protocol \u003d\u003d \u0027Ceph\u0027,"},{"line_number":106,"context_line":"                          \u0027There is a bug in Ceph driver\u0027"},{"line_number":107,"context_line":"                          \u0027https://bugs.launchpad.net/cinder/+bug/1627510\u0027)"},{"line_number":108,"context_line":"    def test_volume_from_snapshot(self):"}],"source_content_type":"text/x-python","patch_set":13,"id":"1a95cdbc_b763cab0","line":105,"in_reply_to":"1a95cdbc_b40ae8d0","updated":"2016-10-05 12:21:12.000000000","message":"My mistake","commit_id":"7ed277eb613b0d65cd9b57fd2f0c29d3467ddbed"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"670d00f064f690195c4684cfb1c3bab4dc4cc0c3","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        self.assertEqual(new_desc, updated_snapshot[self.descrip_field])"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    @test.idempotent_id(\u0027677863d1-3142-456d-b6ac-9924f667a7f4\u0027)"},{"line_number":105,"context_line":"    @testtools.skipIf(CONF.volume.storage_protocol \u003d\u003d \u0027ceph\u0027,"},{"line_number":106,"context_line":"                      \u0027There is a bug in Ceph driver\u0027"},{"line_number":107,"context_line":"                      \u0027https://bugs.launchpad.net/cinder/+bug/1627510\u0027)"},{"line_number":108,"context_line":"    def test_volume_from_snapshot(self):"}],"source_content_type":"text/x-python","patch_set":14,"id":"1a95cdbc_ab8c1536","line":105,"updated":"2016-10-06 10:59:31.000000000","message":"You can\"t do that in the same patch. We need to have separate patches if you want to fix several bugs.","commit_id":"186b471bd1df4e8bf93cf2277678e4c107ef5074"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"3ed414b9053c66186ebdd3175c413f2d403968b1","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        self.assertEqual(new_desc, updated_snapshot[self.descrip_field])"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    @test.idempotent_id(\u0027677863d1-3142-456d-b6ac-9924f667a7f4\u0027)"},{"line_number":105,"context_line":"    @testtools.skipIf(CONF.volume.storage_protocol \u003d\u003d \u0027ceph\u0027,"},{"line_number":106,"context_line":"                      \u0027There is a bug in Ceph driver\u0027"},{"line_number":107,"context_line":"                      \u0027https://bugs.launchpad.net/cinder/+bug/1627510\u0027)"},{"line_number":108,"context_line":"    def test_volume_from_snapshot(self):"}],"source_content_type":"text/x-python","patch_set":14,"id":"1a95cdbc_ecac6937","line":105,"in_reply_to":"1a95cdbc_ab8c1536","updated":"2016-10-06 14:30:17.000000000","message":"Thanks for your comment, I\u0027ll do it","commit_id":"186b471bd1df4e8bf93cf2277678e4c107ef5074"}],"tempest/api/volume/test_volumes_snapshots_list.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"670d00f064f690195c4684cfb1c3bab4dc4cc0c3","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    def _create_test_snapshots(self):"},{"line_number":36,"context_line":"        # Create snapshots with params"},{"line_number":37,"context_line":"        for _ in range(2):"},{"line_number":38,"context_line":"            self.snapshot \u003d self.create_snapshot(self.volume_origin[\u0027id\u0027])"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def _list_by_param_values_and_assert(self, with_detail\u003dFalse, **params):"},{"line_number":41,"context_line":"        \"\"\"list or list_details with given params and validates result.\"\"\""}],"source_content_type":"text/x-python","patch_set":14,"id":"1a95cdbc_eb161d54","line":38,"updated":"2016-10-06 10:59:31.000000000","message":"Where do you use/reuse the self.snapshot variable ? If you don\"t need it, maybe just do\n\n  for _ in range(2):\n     self.create_snapshot(self.volume_origin[\u0027id\u0027])","commit_id":"186b471bd1df4e8bf93cf2277678e4c107ef5074"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"3ed414b9053c66186ebdd3175c413f2d403968b1","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    def _create_test_snapshots(self):"},{"line_number":36,"context_line":"        # Create snapshots with params"},{"line_number":37,"context_line":"        for _ in range(2):"},{"line_number":38,"context_line":"            self.snapshot \u003d self.create_snapshot(self.volume_origin[\u0027id\u0027])"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def _list_by_param_values_and_assert(self, with_detail\u003dFalse, **params):"},{"line_number":41,"context_line":"        \"\"\"list or list_details with given params and validates result.\"\"\""}],"source_content_type":"text/x-python","patch_set":14,"id":"1a95cdbc_4cbd5d67","line":38,"in_reply_to":"1a95cdbc_eb161d54","updated":"2016-10-06 14:30:17.000000000","message":"L68,L77,L86,L93","commit_id":"186b471bd1df4e8bf93cf2277678e4c107ef5074"}]}