)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"9ff11f28926a6365e3be88bf6696e013885acb3d","unresolved":false,"context_lines":[{"line_number":9,"context_line":"verify_glance_api_versions was used .get_versions() method which is"},{"line_number":10,"context_line":"work correctly only for RestClient and not applicable to child with"},{"line_number":11,"context_line":"defined property api_version. Now it\u0027s switched to _get_api_versions"},{"line_number":12,"context_line":"method."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I43e03a272d8c71671c2eaf78e621c03a2eec6866"},{"line_number":15,"context_line":"Closes-Bug: 1611771"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f044301_7a46197f","line":12,"updated":"2017-05-05 16:02:32.000000000","message":"You need to write why the previous patch is reverted and this patch is fine on the commit message.","commit_id":"8d971d7b1189e143b344018e5b6d262ac7f556b8"}],"tempest/cmd/verify_tempest_config.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"1be60d38b9e77ba0c3c13966b772464a092ce249","unresolved":false,"context_lines":[{"line_number":99,"context_line":"    }"},{"line_number":100,"context_line":"    # Image_clients the only variables that can be not declared in"},{"line_number":101,"context_line":"    # clients.Manager class."},{"line_number":102,"context_line":"    if \u0027image_client\u0027 in dir(os):"},{"line_number":103,"context_line":"        client_dict[\u0027glance\u0027] \u003d os.image_client"},{"line_number":104,"context_line":"    if service !\u003d \u0027keystone\u0027:"},{"line_number":105,"context_line":"        # Since keystone may be listening on a path, do not remove the path."}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_59a51202","line":102,"updated":"2016-09-21 09:42:53.000000000","message":"I don\u0027t understand this code, nor the code comment.","commit_id":"8d971d7b1189e143b344018e5b6d262ac7f556b8"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"9ff11f28926a6365e3be88bf6696e013885acb3d","unresolved":false,"context_lines":[{"line_number":99,"context_line":"    }"},{"line_number":100,"context_line":"    # Image_clients the only variables that can be not declared in"},{"line_number":101,"context_line":"    # clients.Manager class."},{"line_number":102,"context_line":"    if \u0027image_client\u0027 in dir(os):"},{"line_number":103,"context_line":"        client_dict[\u0027glance\u0027] \u003d os.image_client"},{"line_number":104,"context_line":"    if service !\u003d \u0027keystone\u0027:"},{"line_number":105,"context_line":"        # Since keystone may be listening on a path, do not remove the path."}],"source_content_type":"text/x-python","patch_set":1,"id":"3f044301_1a7275e4","line":102,"in_reply_to":"7a8ec9b2_59a51202","updated":"2017-05-05 16:02:32.000000000","message":"It would be great if containing the NOTE Gnocchi\u0027s gate doesn\u0027t contain image_client here.","commit_id":"8d971d7b1189e143b344018e5b6d262ac7f556b8"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"24f643347fbe34215a8755d36ce9633b9fd75eb2","unresolved":false,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":"def _get_api_versions(os, service):"},{"line_number":95,"context_line":"    client_dict \u003d {"},{"line_number":96,"context_line":"        \u0027nova\u0027: os.servers_client,"},{"line_number":97,"context_line":"        \u0027keystone\u0027: os.identity_client,"},{"line_number":98,"context_line":"        \u0027cinder\u0027: os.volumes_client,"},{"line_number":99,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":2,"id":"df140735_83f9664e","line":96,"range":{"start_line":96,"start_character":16,"end_line":96,"end_character":18},"updated":"2017-05-31 21:51:30.000000000","message":"Shouldn\u0027t these be os_primary now?","commit_id":"b15619fbc8e74e7d408b90f43d2c563a96983e9d"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"75a202ebe09cf47143352795d8f2662682b9eda2","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        \u0027keystone\u0027: os.identity_client,"},{"line_number":98,"context_line":"        \u0027cinder\u0027: os.volumes_client,"},{"line_number":99,"context_line":"    }"},{"line_number":100,"context_line":"    # \"os\" variable is supposed to be an instance of \"tempest.clients.Manager\""},{"line_number":101,"context_line":"    # class. That class have unique conditional init for image_clients vars"},{"line_number":102,"context_line":"    # which are not appear in instance if \"CONF.service_available.glance\" is"},{"line_number":103,"context_line":"    # false. So we have to ensure that \u0027image_client\u0027 really exist in os before"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f013ff3_070ff92e","line":100,"updated":"2017-05-13 04:11:04.000000000","message":"supposed to be?","commit_id":"b15619fbc8e74e7d408b90f43d2c563a96983e9d"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"75a202ebe09cf47143352795d8f2662682b9eda2","unresolved":false,"context_lines":[{"line_number":103,"context_line":"    # false. So we have to ensure that \u0027image_client\u0027 really exist in os before"},{"line_number":104,"context_line":"    # refer to it."},{"line_number":105,"context_line":"    if \u0027image_client\u0027 in dir(os):"},{"line_number":106,"context_line":"        client_dict[\u0027glance\u0027] \u003d os.image_client"},{"line_number":107,"context_line":"    if service !\u003d \u0027keystone\u0027:"},{"line_number":108,"context_line":"        # Since keystone may be listening on a path, do not remove the path."},{"line_number":109,"context_line":"        client_dict[service].skip_path()"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f013ff3_e71bed70","line":106,"updated":"2017-05-13 04:11:04.000000000","message":"I\u0027m not sure this is a good solution. The aim here is to verify if configuration\nmatches discovery - but if we do like this we basically skip discovery based on\nconfiguration.\n\nMy recommendation would be to try to ignore the alias \"image_client\" and\njust get an image_client, \n\nclient_dict[\u0027glance\u0027] \u003d os.image_v1.ImagesClient()","commit_id":"b15619fbc8e74e7d408b90f43d2c563a96983e9d"}]}