)]}'
{"tempest/api/network/base.py":[{"author":{"_account_id":16437,"name":"Anna Babich","email":"anna.v.babich@gmail.com","username":"ababich"},"change_message_id":"f4d3b023a2d4306fc4ef8147fe9dd68f6580558e","unresolved":false,"context_lines":[{"line_number":137,"context_line":"    @classmethod"},{"line_number":138,"context_line":"    def create_network(cls, network_name\u003dNone, **kwargs):"},{"line_number":139,"context_line":"        \"\"\"Wrapper utility that returns a test network.\"\"\""},{"line_number":140,"context_line":"        network_name \u003d network_name or data_utils.rand_name(\u0027test-network-\u0027)"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"        body \u003d cls.networks_client.create_network(name\u003dnetwork_name, **kwargs)"},{"line_number":143,"context_line":"        network \u003d body[\u0027network\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a98d1f4_d58165c4","line":140,"updated":"2016-10-04 10:16:25.000000000","message":"It should be better to use a name of testclass for test resources\u0027 naming, like it\u0027s already done in a lot of Tempest tests to improve test debugging:\nnetwork_name \u003d network_name or data_utils.rand_name(self.__class__.__name__ + \u0027-network\u0027)","commit_id":"3e79b4f7a9541534fa9ead63c808b9b086810df7"},{"author":{"_account_id":22678,"name":"Bruce Tan","email":"brucetan@linux.vnet.ibm.com","username":"brucetan"},"change_message_id":"86d6a17e57edad05f9eaba6f2fd31d670721178a","unresolved":false,"context_lines":[{"line_number":137,"context_line":"    @classmethod"},{"line_number":138,"context_line":"    def create_network(cls, network_name\u003dNone, **kwargs):"},{"line_number":139,"context_line":"        \"\"\"Wrapper utility that returns a test network.\"\"\""},{"line_number":140,"context_line":"        network_name \u003d network_name or data_utils.rand_name(\u0027test-network-\u0027)"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"        body \u003d cls.networks_client.create_network(name\u003dnetwork_name, **kwargs)"},{"line_number":143,"context_line":"        network \u003d body[\u0027network\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a95cdbc_64c46040","line":140,"in_reply_to":"3a98d1f4_d58165c4","updated":"2016-10-04 14:46:04.000000000","message":"Done","commit_id":"3e79b4f7a9541534fa9ead63c808b9b086810df7"}],"tempest/api/network/test_networks.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"a6cfd264597577dced3eb2f546b2a4b77c3d2d24","unresolved":false,"context_lines":[{"line_number":399,"context_line":"    @test.idempotent_id(\u0027c72c1c0c-2193-4aca-ccc4-b1442640bbbb\u0027)"},{"line_number":400,"context_line":"    @test.requires_ext(extension\u003d\"standard-attr-description\","},{"line_number":401,"context_line":"                       service\u003d\"network\")"},{"line_number":402,"context_line":"    def test_create_update_network_description(self):"},{"line_number":403,"context_line":"        body \u003d self.create_network(description\u003d\u0027d1\u0027)"},{"line_number":404,"context_line":"        self.assertEqual(\u0027d1\u0027, body[\u0027description\u0027])"},{"line_number":405,"context_line":"        net_id \u003d body[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a98d1f4_57f8eb7c","line":402,"updated":"2016-09-28 15:28:52.000000000","message":"Could you please merge this test into test_create_update_delete_network_subnet\n\nNo need to duplicate the whole test just to test the update of one field.","commit_id":"02b0454fe6b4e344dc50334f08380f48600a0f3d"},{"author":{"_account_id":22678,"name":"Bruce Tan","email":"brucetan@linux.vnet.ibm.com","username":"brucetan"},"change_message_id":"5a04fa1d08fb22348dfb8f8e13a944866f09b582","unresolved":false,"context_lines":[{"line_number":399,"context_line":"    @test.idempotent_id(\u0027c72c1c0c-2193-4aca-ccc4-b1442640bbbb\u0027)"},{"line_number":400,"context_line":"    @test.requires_ext(extension\u003d\"standard-attr-description\","},{"line_number":401,"context_line":"                       service\u003d\"network\")"},{"line_number":402,"context_line":"    def test_create_update_network_description(self):"},{"line_number":403,"context_line":"        body \u003d self.create_network(description\u003d\u0027d1\u0027)"},{"line_number":404,"context_line":"        self.assertEqual(\u0027d1\u0027, body[\u0027description\u0027])"},{"line_number":405,"context_line":"        net_id \u003d body[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a98d1f4_cef3a171","line":402,"in_reply_to":"3a98d1f4_57f8eb7c","updated":"2016-10-04 07:28:12.000000000","message":"I actually think that it is a better idea to keep the case separate because:\n\n1. I am simple moving an existing case from Neutron to Tempest. The two cases (test_create_update_network_description and test_create_update_delete_network_subnet) are two separate cases back in Neutron. So keeping them the same way could make it easier to understand.\n\n2. I would like to consider this test case as \"creating/updating network with different set of parameters\", like we test creating/deleting subnet with different types of parameters (gw/allocation_pool/dns_server/dhcp/etc.). So, it is reasonable to verify \"a new parameter in creating/updating network\" in a separate case. \n\n3. Testing \"description\" of network needs to verify the existence of API extension \"standard-attr-description\". If we put the test in test_create_update_delete_network_subnet, we cannot skip the \"description\" part by decorator(test.requires_ext) and instead, we need to add \"if-else\" before each API call, since the old API won\u0027t accept \"description\" field. This makes the whole test case more difficult to understand and to debug in case of failure.","commit_id":"02b0454fe6b4e344dc50334f08380f48600a0f3d"}]}