)]}'
{"tempest/api/compute/images/test_images.py":[{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"a26e332b48a4954ee61b6db4ef1c3ce7c437b2d3","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        resp, body \u003d self.client.create_image(server[\u0027id\u0027], snapshot_name)"},{"line_number":118,"context_line":"        self.assertEqual(202, resp.status)"},{"line_number":119,"context_line":"        image_id \u003d parse_image_id(resp[\u0027location\u0027])"},{"line_number":120,"context_line":"        self.client.wait_for_image_resp_code(image_id, 200)"},{"line_number":121,"context_line":"        self.client.wait_for_image_status(image_id, \u0027ACTIVE\u0027)"},{"line_number":122,"context_line":"        resp, image \u003d self.client.get_image(image_id)"},{"line_number":123,"context_line":"        self.assertEqual(snapshot_name, image[\u0027name\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAQn%2F%2F4uI%3D","line":120,"updated":"2013-07-19 19:51:18.000000000","message":"why do we have to wait on the resp and the image status?","commit_id":"ed52a264cc631dbc948b57ed5bf6b43b912f1032"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"a26e332b48a4954ee61b6db4ef1c3ce7c437b2d3","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        resp, image \u003d self.client.get_image(image_id)"},{"line_number":123,"context_line":"        self.assertEqual(snapshot_name, image[\u0027name\u0027])"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"        self.servers_client.delete_server(server[\u0027id\u0027])"},{"line_number":126,"context_line":"        self.client.delete_image(image[\u0027id\u0027])"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    @attr(type\u003d[\u0027positive\u0027, \u0027gate\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAQn%2F%2F4uA%3D","line":125,"updated":"2013-07-19 19:51:18.000000000","message":"this should be done as an addCleanup","commit_id":"ed52a264cc631dbc948b57ed5bf6b43b912f1032"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"a26e332b48a4954ee61b6db4ef1c3ce7c437b2d3","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        self.assertEqual(snapshot_name, image[\u0027name\u0027])"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"        self.servers_client.delete_server(server[\u0027id\u0027])"},{"line_number":126,"context_line":"        self.client.delete_image(image[\u0027id\u0027])"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    @attr(type\u003d[\u0027positive\u0027, \u0027gate\u0027])"},{"line_number":129,"context_line":"    def test_delete_saving_image(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAQn%2F%2F4t4%3D","line":126,"updated":"2013-07-19 19:51:18.000000000","message":"so should this","commit_id":"ed52a264cc631dbc948b57ed5bf6b43b912f1032"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"a26e332b48a4954ee61b6db4ef1c3ce7c437b2d3","unresolved":false,"context_lines":[{"line_number":132,"context_line":"        resp, body \u003d self.client.create_image(server[\u0027id\u0027], snapshot_name)"},{"line_number":133,"context_line":"        self.assertEqual(202, resp.status)"},{"line_number":134,"context_line":"        image_id \u003d parse_image_id(resp[\u0027location\u0027])"},{"line_number":135,"context_line":"        self.client.wait_for_image_resp_code(image_id, 200)"},{"line_number":136,"context_line":"        self.client.wait_for_image_status(image_id, \u0027SAVING\u0027)"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"        resp, body \u003d self.client.delete_image(image_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAQn%2F%2F4uM%3D","line":135,"updated":"2013-07-19 19:51:18.000000000","message":"this seems not required, no? We should just be able to wait for the image_status.","commit_id":"ed52a264cc631dbc948b57ed5bf6b43b912f1032"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"8279e1e476ee8e990e7e7c12d5d86b47bb4f6f9c","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        self.assertEqual(202, resp.status)"},{"line_number":134,"context_line":"        image_id \u003d parse_image_id(resp[\u0027location\u0027])"},{"line_number":135,"context_line":"        self.client.wait_for_image_resp_code(image_id, 200)"},{"line_number":136,"context_line":"        self.client.wait_for_image_status(image_id, \u0027SAVING\u0027)"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"        resp, body \u003d self.client.delete_image(image_id)"},{"line_number":139,"context_line":"        self.assertEqual(\u0027204\u0027, resp[\u0027status\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAQn%2F%2F8HE%3D","line":136,"updated":"2013-07-18 19:18:25.000000000","message":"If it ever causes an issue, we need to handle it differently.","commit_id":"ed52a264cc631dbc948b57ed5bf6b43b912f1032"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"a26e332b48a4954ee61b6db4ef1c3ce7c437b2d3","unresolved":false,"context_lines":[{"line_number":135,"context_line":"        self.client.wait_for_image_resp_code(image_id, 200)"},{"line_number":136,"context_line":"        self.client.wait_for_image_status(image_id, \u0027SAVING\u0027)"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"        resp, body \u003d self.client.delete_image(image_id)"},{"line_number":139,"context_line":"        self.assertEqual(\u0027204\u0027, resp[\u0027status\u0027])"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"    @attr(type\u003d[\u0027negative\u0027, \u0027gate\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAQn%2F%2F4to%3D","line":138,"updated":"2013-07-19 19:51:18.000000000","message":"we need addCleanup here as well so that if we blew up early we\u0027d still get rid of the image.","commit_id":"ed52a264cc631dbc948b57ed5bf6b43b912f1032"}]}
