)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"190b0078f95ade398b4f955bc82120db0aed0443","unresolved":false,"context_lines":[{"line_number":11,"context_line":"cleaned by base\u0027s clear_volumes() in base\u0027s resource_cleanup; If"},{"line_number":12,"context_line":"the testcase want to delete the volume immediately after the testcase,"},{"line_number":13,"context_line":"a flag is added to base.create_volume to specify not to delete volume"},{"line_number":14,"context_line":"in resource_cleanup, but to delete volume by using addCleanup."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I06201be2cb70e358e58353b1d8b522d960452793"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3a98d1f4_d1d867f2","line":14,"updated":"2016-09-29 05:51:33.000000000","message":"I\u0027m not sure what is the benefit of this flag(delete_in_cleanup\u003dFalse). Improving performance? People can understand the flow of this proccess easily? or something?","commit_id":"9c4646525081745d7b5b767666c849613b16830f"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"c2b99605560e0322fc3b5e25fb8908a1dc838a9c","unresolved":false,"context_lines":[{"line_number":11,"context_line":"cleaned by base\u0027s clear_volumes() in base\u0027s resource_cleanup; If"},{"line_number":12,"context_line":"the testcase want to delete the volume immediately after the testcase,"},{"line_number":13,"context_line":"a flag is added to base.create_volume to specify not to delete volume"},{"line_number":14,"context_line":"in resource_cleanup, but to delete volume by using addCleanup."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I06201be2cb70e358e58353b1d8b522d960452793"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3a98d1f4_ccce105a","line":14,"in_reply_to":"3a98d1f4_d1d867f2","updated":"2016-09-29 06:23:58.000000000","message":"Thanks,\nI think the obvious duplicated deletion is not good, either for performance or for consistency.\nBut if some testcases want to delete volume in resouce_cleanup, while other testcases want to delete volume right after testcase, it seems we can only distinguish them  by a flag. It is not so serious even people cann\u0027t understand the flag, after all, the volume will sure be deleted in the end.","commit_id":"9c4646525081745d7b5b767666c849613b16830f"}]}