)]}'
{"tempest/lib/services/volume/v1/qos_client.py":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"57068703cf0182ce07b1963ed18933155e197d48","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        :param keys: keys to delete from the QoS specification."},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"        Available params: see http://developer.openstack.org/"},{"line_number":94,"context_line":"                              api-ref-blockstorage-v2.html#deleteQoSSpec"},{"line_number":95,"context_line":"        \"\"\""},{"line_number":96,"context_line":"        put_body \u003d json.dumps({\u0027keys\u0027: keys})"},{"line_number":97,"context_line":"        resp, body \u003d self.put(\u0027qos-specs/%s/delete_keys\u0027 % qos_id, put_body)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a98d1f4_bb049515","line":94,"updated":"2016-09-29 07:51:29.000000000","message":"I don\u0027t think so. I think it\u0027s enough to add around L.24 as a class document.","commit_id":"3572fbd345e32297af3b7a2207d802bd50c3b8d5"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"97e14eb76332e0e6a00f10c3251a0ac7a6345194","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        :param keys: keys to delete from the QoS specification."},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"        Available params: see http://developer.openstack.org/"},{"line_number":94,"context_line":"                              api-ref-blockstorage-v2.html#deleteQoSSpec"},{"line_number":95,"context_line":"        \"\"\""},{"line_number":96,"context_line":"        put_body \u003d json.dumps({\u0027keys\u0027: keys})"},{"line_number":97,"context_line":"        resp, body \u003d self.put(\u0027qos-specs/%s/delete_keys\u0027 % qos_id, put_body)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a98d1f4_95d172d0","line":94,"updated":"2016-09-29 01:29:47.000000000","message":"I\u0027m not sure why we can use v2 documents for v1 clients. Is this a really correct way?","commit_id":"3572fbd345e32297af3b7a2207d802bd50c3b8d5"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"0b7744543dcb26e8b27ef87e42af72d90cbd1537","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        :param keys: keys to delete from the QoS specification."},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"        Available params: see http://developer.openstack.org/"},{"line_number":94,"context_line":"                              api-ref-blockstorage-v2.html#deleteQoSSpec"},{"line_number":95,"context_line":"        \"\"\""},{"line_number":96,"context_line":"        put_body \u003d json.dumps({\u0027keys\u0027: keys})"},{"line_number":97,"context_line":"        resp, body \u003d self.put(\u0027qos-specs/%s/delete_keys\u0027 % qos_id, put_body)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a98d1f4_76e8697d","line":94,"updated":"2016-09-29 05:07:33.000000000","message":"Yeah, so, I\u0027m worried about that some people might be confused like this \"I\u0027m going to use v1 but the doc indicates v2??\".","commit_id":"3572fbd345e32297af3b7a2207d802bd50c3b8d5"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"3273c391f727e59e52def440246159953f338788","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        :param keys: keys to delete from the QoS specification."},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"        Available params: see http://developer.openstack.org/"},{"line_number":94,"context_line":"                              api-ref-blockstorage-v2.html#deleteQoSSpec"},{"line_number":95,"context_line":"        \"\"\""},{"line_number":96,"context_line":"        put_body \u003d json.dumps({\u0027keys\u0027: keys})"},{"line_number":97,"context_line":"        resp, body \u003d self.put(\u0027qos-specs/%s/delete_keys\u0027 % qos_id, put_body)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a98d1f4_d674ddd0","line":94,"updated":"2016-09-29 05:10:52.000000000","message":"so, I think one possible option is adding a comment like you said \"The v1 document has no QoS specification. But we can use v2 doc for v1.\" something like this.","commit_id":"3572fbd345e32297af3b7a2207d802bd50c3b8d5"},{"author":{"_account_id":22752,"name":"Hanxi Liu","email":"apolloliuhx@gmail.com","username":"Hanxi_Liu"},"change_message_id":"277c2576f414d35b15dbecc6e9cc7a1f1e9da29b","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        :param keys: keys to delete from the QoS specification."},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"        Available params: see http://developer.openstack.org/"},{"line_number":94,"context_line":"                              api-ref-blockstorage-v2.html#deleteQoSSpec"},{"line_number":95,"context_line":"        \"\"\""},{"line_number":96,"context_line":"        put_body \u003d json.dumps({\u0027keys\u0027: keys})"},{"line_number":97,"context_line":"        resp, body \u003d self.put(\u0027qos-specs/%s/delete_keys\u0027 % qos_id, put_body)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a98d1f4_a7cac54d","line":94,"in_reply_to":"3a98d1f4_95d172d0","updated":"2016-09-29 01:59:28.000000000","message":"http://developer.openstack.org/api-ref-blockstorage-v1.html\nThe v1 document has no QoS specification.","commit_id":"3572fbd345e32297af3b7a2207d802bd50c3b8d5"},{"author":{"_account_id":22752,"name":"Hanxi Liu","email":"apolloliuhx@gmail.com","username":"Hanxi_Liu"},"change_message_id":"ffbf2dcc82100d9171727db517ad1d78184b6fc7","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        :param keys: keys to delete from the QoS specification."},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"        Available params: see http://developer.openstack.org/"},{"line_number":94,"context_line":"                              api-ref-blockstorage-v2.html#deleteQoSSpec"},{"line_number":95,"context_line":"        \"\"\""},{"line_number":96,"context_line":"        put_body \u003d json.dumps({\u0027keys\u0027: keys})"},{"line_number":97,"context_line":"        resp, body \u003d self.put(\u0027qos-specs/%s/delete_keys\u0027 % qos_id, put_body)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a98d1f4_0c047815","line":94,"in_reply_to":"3a98d1f4_d674ddd0","updated":"2016-09-29 06:37:10.000000000","message":"create_qos and set_qos_key use the v2 doc. Is it necessary to add comments to all places above?","commit_id":"3572fbd345e32297af3b7a2207d802bd50c3b8d5"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"ea1d3a97d06121e69c028a95f222bc2047fcf150","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        :param keys: keys to delete from the QoS specification."},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        Available params: see http://developer.openstack.org/"},{"line_number":97,"context_line":"                              api-ref-blockstorage-v2.html#deleteQoSSpec"},{"line_number":98,"context_line":"        \"\"\""},{"line_number":99,"context_line":"        put_body \u003d json.dumps({\u0027keys\u0027: keys})"},{"line_number":100,"context_line":"        resp, body \u003d self.put(\u0027qos-specs/%s/delete_keys\u0027 % qos_id, put_body)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a98d1f4_f392849e","line":97,"updated":"2016-09-30 06:43:22.000000000","message":"I\u0027m curious about, is the document really correct? The doc shows \u0027/v2/​{tenant_id}​/qos-specs/​{qos_id}​\u0027 but this client sends \u0027PUT ../qos-specs/%s/delete_keys\u0027. It doesn\u0027t match with the doc....\nhttp://developer.openstack.org/api-ref-blockstorage-v2.html#deleteQoSSpec","commit_id":"8f31ba043082fb47b5cc3ca2fee4002c9c5f14bd"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"e3fc030b5ad0d684bb7c771a3d97201e963cb4a5","unresolved":false,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":"        :param keys: keys to delete from the QoS specification."},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        Available params: see http://developer.openstack.org/"},{"line_number":97,"context_line":"                              api-ref-blockstorage-v2.html#deleteQoSSpec"},{"line_number":98,"context_line":"        \"\"\""},{"line_number":99,"context_line":"        put_body \u003d json.dumps({\u0027keys\u0027: keys})"},{"line_number":100,"context_line":"        resp, body \u003d self.put(\u0027qos-specs/%s/delete_keys\u0027 % qos_id, put_body)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a98d1f4_fed06421","line":97,"range":{"start_line":96,"start_character":0,"end_line":97,"end_character":72},"updated":"2016-09-30 17:36:34.000000000","message":"Now we should change here like\n\n For a full list of available parameters, please refer to the official\n API reference:\n http://developer.openstack.org/...\n\nfor making the link in a single line.\nPlease see https://review.openstack.org/#/c/370539/ as the reference.","commit_id":"8f31ba043082fb47b5cc3ca2fee4002c9c5f14bd"},{"author":{"_account_id":22752,"name":"Hanxi Liu","email":"apolloliuhx@gmail.com","username":"Hanxi_Liu"},"change_message_id":"f8250b56c50e10dc30246dc1344bfaca3d6c0a1e","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        :param keys: keys to delete from the QoS specification."},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        Available params: see http://developer.openstack.org/"},{"line_number":97,"context_line":"                              api-ref-blockstorage-v2.html#deleteQoSSpec"},{"line_number":98,"context_line":"        \"\"\""},{"line_number":99,"context_line":"        put_body \u003d json.dumps({\u0027keys\u0027: keys})"},{"line_number":100,"context_line":"        resp, body \u003d self.put(\u0027qos-specs/%s/delete_keys\u0027 % qos_id, put_body)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a98d1f4_f3d7e4bc","line":97,"in_reply_to":"3a98d1f4_f392849e","updated":"2016-09-30 07:15:45.000000000","message":"link: https://bugs.launchpad.net/openstack-api-site/+bug/1524877 \nwe just get the params info from the v2 doc. And we know the url is /v2/​{tenant_id}​/qos-specs/​{qos_id}​/delete_keys. However, we can choose which api to use, v1 or v2 when sending the \u0027PUT...\u0027. It\u0027s my view of point.","commit_id":"8f31ba043082fb47b5cc3ca2fee4002c9c5f14bd"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"e3fc030b5ad0d684bb7c771a3d97201e963cb4a5","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        :param keys: keys to delete from the QoS specification."},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        Available params: see http://developer.openstack.org/"},{"line_number":97,"context_line":"                              api-ref-blockstorage-v2.html#deleteQoSSpec"},{"line_number":98,"context_line":"        \"\"\""},{"line_number":99,"context_line":"        put_body \u003d json.dumps({\u0027keys\u0027: keys})"},{"line_number":100,"context_line":"        resp, body \u003d self.put(\u0027qos-specs/%s/delete_keys\u0027 % qos_id, put_body)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a98d1f4_9e0be08d","line":97,"in_reply_to":"3a98d1f4_f3d7e4bc","updated":"2016-09-30 17:36:34.000000000","message":"I am on the same side as Masayuki.\nCurrent V1 reference will make confuse easily.\nAnd if there are lack for v1, we should not change here until the v1 doc should be fixed.","commit_id":"8f31ba043082fb47b5cc3ca2fee4002c9c5f14bd"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"d86513d52250c519892a95f306d01ec44e40bbd3","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    def create_qos(self, **kwargs):"},{"line_number":45,"context_line":"        \"\"\"Create a QoS Specification."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        For a full list of available parameters, please refer to the official"},{"line_number":48,"context_line":"        API reference:"},{"line_number":49,"context_line":"        http://developer.openstack.org/api-ref/block-storage/v2/index.html"},{"line_number":50,"context_line":"                            ?expanded\u003dcreate-qos-specification-detail"},{"line_number":51,"context_line":"                            #quality-of-service-qos-specifications-qos-specs"},{"line_number":52,"context_line":"        \"\"\""},{"line_number":53,"context_line":"        post_body \u003d json.dumps({\u0027qos_specs\u0027: kwargs})"},{"line_number":54,"context_line":"        resp, body \u003d self.post(\u0027qos-specs\u0027, post_body)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a98d1f4_83f6d98c","line":51,"range":{"start_line":47,"start_character":0,"end_line":51,"end_character":76},"updated":"2016-10-03 23:06:07.000000000","message":"Please don\u0027t put v1 link here.\nThis just makes confusions as I said on the previous review.","commit_id":"31f1bf39ee0e5f281dce87c078afd632a0e5ee98"}],"tempest/lib/services/volume/v2/qos_client.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"e3fc030b5ad0d684bb7c771a3d97201e963cb4a5","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        :param keys: keys to delete from the QoS specification."},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"        Available params: see http://developer.openstack.org/"},{"line_number":94,"context_line":"                              api-ref-blockstorage-v2.html#deleteQoSSpec"},{"line_number":95,"context_line":"        \"\"\""},{"line_number":96,"context_line":"        put_body \u003d json.dumps({\u0027keys\u0027: keys})"},{"line_number":97,"context_line":"        resp, body \u003d self.put(\u0027qos-specs/%s/delete_keys\u0027 % qos_id, put_body)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a98d1f4_5ec4f85d","line":94,"range":{"start_line":93,"start_character":0,"end_line":94,"end_character":72},"updated":"2016-09-30 17:36:34.000000000","message":"ditto","commit_id":"8f31ba043082fb47b5cc3ca2fee4002c9c5f14bd"}]}