)]}'
{"tempest/api/compute/base.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d827b1388e4822441ed386a50f8f376af7d64a71","unresolved":false,"context_lines":[{"line_number":420,"context_line":"        if device:"},{"line_number":421,"context_line":"            attach_kwargs[\u0027device\u0027] \u003d device"},{"line_number":422,"context_line":""},{"line_number":423,"context_line":"        # check to see if we got a server object (dict-like) or server id"},{"line_number":424,"context_line":"        if isinstance(server, six.string_types):"},{"line_number":425,"context_line":"            server_id \u003d server"},{"line_number":426,"context_line":"        else:"},{"line_number":427,"context_line":"            server_id \u003d server[\u0027id\u0027]"},{"line_number":428,"context_line":""},{"line_number":429,"context_line":"        self.servers_client.attach_volume(server_id, **attach_kwargs)"},{"line_number":430,"context_line":"        # On teardown detach the volume and wait for it to be available. This"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a98d1f4_bd70660c","line":427,"range":{"start_line":423,"start_character":8,"end_line":427,"end_character":36},"updated":"2016-10-03 15:15:54.000000000","message":"Should be able to get rid of this.","commit_id":"2b70b17aa5fdfe0f3ca52d4bcb7683afd85c2fc3"}],"tempest/api/compute/servers/test_server_actions.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"a7e20a1e86f83e8b0b8d93d24169eab42897ef37","unresolved":false,"context_lines":[{"line_number":47,"context_line":"                                           self.server_id, \u0027ACTIVE\u0027)"},{"line_number":48,"context_line":"        except lib_exc.NotFound:"},{"line_number":49,"context_line":"            # The server was deleted by previous test, create a new one"},{"line_number":50,"context_line":"            server \u003d self.create_test_server("},{"line_number":51,"context_line":"                validatable\u003dTrue,"},{"line_number":52,"context_line":"                wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":53,"context_line":"            self.__class__.server_id \u003d server[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a98d1f4_9db2cae3","line":50,"range":{"start_line":50,"start_character":12,"end_line":50,"end_character":18},"updated":"2016-10-03 15:15:05.000000000","message":"if we save this on the class then we don\u0027t have to hack the attach_volume method in the base class","commit_id":"2b70b17aa5fdfe0f3ca52d4bcb7683afd85c2fc3"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"e654fec26320552bc5292e0edbfcbfa5bb7e1712","unresolved":false,"context_lines":[{"line_number":50,"context_line":"            server \u003d self.create_test_server("},{"line_number":51,"context_line":"                validatable\u003dTrue,"},{"line_number":52,"context_line":"                wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":53,"context_line":"            self.__class__.server_id \u003d server[\u0027id\u0027]"},{"line_number":54,"context_line":"        except Exception:"},{"line_number":55,"context_line":"            # Rebuild server if something happened to it during a test"},{"line_number":56,"context_line":"            self.__class__.server_id \u003d self.rebuild_server("}],"source_content_type":"text/x-python","patch_set":6,"id":"3a98d1f4_fd1f4eb4","line":53,"updated":"2016-10-03 15:15:41.000000000","message":"If we replace this line by \n\n  self.__class__.server \u003d server\n\nand all the usage of server_id by server[\u0027id\u0027] then we don\u0027t need the \u0027if isinstance(server, six.string_types):\u0027 line in the other file.","commit_id":"2b70b17aa5fdfe0f3ca52d4bcb7683afd85c2fc3"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f32e3f6f37bf77d006cf0bd69605a0848af7dcc8","unresolved":false,"context_lines":[{"line_number":50,"context_line":"            server \u003d self.create_test_server("},{"line_number":51,"context_line":"                validatable\u003dTrue,"},{"line_number":52,"context_line":"                wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":53,"context_line":"            self.__class__.server_id \u003d server[\u0027id\u0027]"},{"line_number":54,"context_line":"        except Exception:"},{"line_number":55,"context_line":"            # Rebuild server if something happened to it during a test"},{"line_number":56,"context_line":"            self.__class__.server_id \u003d self.rebuild_server("}],"source_content_type":"text/x-python","patch_set":6,"id":"3a98d1f4_c0238954","line":53,"in_reply_to":"3a98d1f4_fd1f4eb4","updated":"2016-10-03 15:25:02.000000000","message":"I\u0027ll add the one line for:\n\nself.__class__.server \u003d server\n\nIn this change. I don\u0027t want to go through and refactor all of the server_id to use server[\u0027id\u0027] in this change as that will clutter things up. I\u0027ll leave a TODO and then refactor/clean that up in a follow up change on top of the series.","commit_id":"2b70b17aa5fdfe0f3ca52d4bcb7683afd85c2fc3"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"a7e20a1e86f83e8b0b8d93d24169eab42897ef37","unresolved":false,"context_lines":[{"line_number":53,"context_line":"            self.__class__.server_id \u003d server[\u0027id\u0027]"},{"line_number":54,"context_line":"        except Exception:"},{"line_number":55,"context_line":"            # Rebuild server if something happened to it during a test"},{"line_number":56,"context_line":"            self.__class__.server_id \u003d self.rebuild_server("},{"line_number":57,"context_line":"                self.server_id, validatable\u003dTrue)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def tearDown(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a98d1f4_9de9eab9","line":56,"range":{"start_line":56,"start_character":44,"end_line":56,"end_character":58},"updated":"2016-10-03 15:15:05.000000000","message":"ditto","commit_id":"2b70b17aa5fdfe0f3ca52d4bcb7683afd85c2fc3"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"52da76dbc13dff185706a4572370ba8f9c03495f","unresolved":false,"context_lines":[{"line_number":53,"context_line":"            self.__class__.server_id \u003d server[\u0027id\u0027]"},{"line_number":54,"context_line":"        except Exception:"},{"line_number":55,"context_line":"            # Rebuild server if something happened to it during a test"},{"line_number":56,"context_line":"            self.__class__.server_id \u003d self.rebuild_server("},{"line_number":57,"context_line":"                self.server_id, validatable\u003dTrue)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def tearDown(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a98d1f4_f3193d23","line":56,"range":{"start_line":56,"start_character":44,"end_line":56,"end_character":58},"in_reply_to":"3a98d1f4_9de9eab9","updated":"2016-10-03 15:39:58.000000000","message":"Actually this is messy because rebuild_server returns a server id, not a server object. So I guess if we do this I\u0027d need to do a GET on the server id and store that.","commit_id":"2b70b17aa5fdfe0f3ca52d4bcb7683afd85c2fc3"}]}