)]}'
{"tempest/api/compute/admin/test_volumes_negative.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"ccde66278a42197f7361c1a7243f51b9f6e27444","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    def resource_setup(cls):"},{"line_number":40,"context_line":"        super(VolumesAdminNegativeTest, cls).resource_setup()"},{"line_number":41,"context_line":"        cls.server \u003d cls.create_test_server(wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":42,"context_line":"        cls.volume1 \u003d cls.create_volume()"},{"line_number":43,"context_line":"        cls.volume2 \u003d cls.create_volume()"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    @test.idempotent_id(\u0027309b5ecd-0585-4a7e-a36f-d2b2bf55259d\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa6399be_7fb9f514","line":42,"updated":"2016-10-19 08:46:47.000000000","message":"Given that volume1 is used only in one test, and volume2 is used on the other test, you should not create these resources in \u0027resource_setup\u0027. Create each volume in their respective test.\n\nResource_setup is bad (side-effects, test timing is not accurate etc.) and should be avoided when not needed.","commit_id":"de6f64ae852ab3d867d2652d379dea030382a342"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"7823c13fe2677faeb921008ec6a57fd7771b34c5","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    def resource_setup(cls):"},{"line_number":40,"context_line":"        super(VolumesAdminNegativeTest, cls).resource_setup()"},{"line_number":41,"context_line":"        cls.server \u003d cls.create_test_server(wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":42,"context_line":"        cls.volume1 \u003d cls.create_volume()"},{"line_number":43,"context_line":"        cls.volume2 \u003d cls.create_volume()"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    @test.idempotent_id(\u0027309b5ecd-0585-4a7e-a36f-d2b2bf55259d\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba5da102_93f75258","line":42,"in_reply_to":"ba5da102_24dd6d6f","updated":"2016-11-02 09:56:08.000000000","message":"Creation and deletion of a volume takes less than 3secs. Also, in your case, if you use resource_setup you are going to create 2 (two) volumes. If you create each volume in each test you are going to create 2 (two) volumes. So it\u0027s the same thing.\n\nThe difference is when people are going to copy/paste this code (because people do copy/paste code) it\u0027s better if they don\"t use resource_setup because it can have bad side effect.","commit_id":"de6f64ae852ab3d867d2652d379dea030382a342"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"ab1f4f520aa065eff99466513e585b3fb1ea9749","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    def resource_setup(cls):"},{"line_number":40,"context_line":"        super(VolumesAdminNegativeTest, cls).resource_setup()"},{"line_number":41,"context_line":"        cls.server \u003d cls.create_test_server(wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":42,"context_line":"        cls.volume1 \u003d cls.create_volume()"},{"line_number":43,"context_line":"        cls.volume2 \u003d cls.create_volume()"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    @test.idempotent_id(\u0027309b5ecd-0585-4a7e-a36f-d2b2bf55259d\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba5da102_f10b11d4","line":42,"in_reply_to":"ba5da102_93f75258","updated":"2016-11-02 17:39:03.000000000","message":"Ah, nice point.\n\nCurrent created sources are just used at each test only. not shared at all actually.","commit_id":"de6f64ae852ab3d867d2652d379dea030382a342"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"3820732d8ef4b61fe7cd3c1c93ca8176e7c19704","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    def resource_setup(cls):"},{"line_number":40,"context_line":"        super(VolumesAdminNegativeTest, cls).resource_setup()"},{"line_number":41,"context_line":"        cls.server \u003d cls.create_test_server(wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":42,"context_line":"        cls.volume1 \u003d cls.create_volume()"},{"line_number":43,"context_line":"        cls.volume2 \u003d cls.create_volume()"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    @test.idempotent_id(\u0027309b5ecd-0585-4a7e-a36f-d2b2bf55259d\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba5da102_24dd6d6f","line":42,"in_reply_to":"fa6399be_7fb9f514","updated":"2016-11-01 23:07:47.000000000","message":"I don\u0027t think it is nice to create each volume in each test because creation and deletion of volume tend to take time.\nresource_setup() is called at once in each test class, so do we really need to change this?","commit_id":"de6f64ae852ab3d867d2652d379dea030382a342"}]}