)]}'
{"tempest/tests/common/test_dynamic_creds.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"cc159e26ccdd588b7f79ae9c38bd059dde4b0f76","unresolved":false,"context_lines":[{"line_number":291,"context_line":""},{"line_number":292,"context_line":"    @mock.patch(\u0027tempest.lib.common.rest_client.RestClient\u0027)"},{"line_number":293,"context_line":"    def test_no_network_creation_with_config_set(self, MockRestClient):"},{"line_number":294,"context_line":"        creds \u003d dynamic_creds.DynamicCredentialProvider("},{"line_number":295,"context_line":"            neutron_available\u003dTrue, create_networks\u003dFalse,"},{"line_number":296,"context_line":"            project_network_cidr\u003d\u002710.100.0.0/16\u0027, project_network_mask_bits\u003d28,"},{"line_number":297,"context_line":"            **self.fixed_params)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa6399be_b2a05f92","line":294,"updated":"2016-10-11 09:53:06.000000000","message":"It would make the code easier to read if you also put the \u0027neutron_available\u0027, \u0027create_networks\u0027, \u0027project_network_cidr\u0027, \u0027project_network_mask_bits\u0027 in the \"fixed_params\" dict. And then you copy that dict and update just the one relevant param at the beginning of each test.","commit_id":"b48bc180323e81884434172beefd06e8dc29c867"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"dfcde34245ef530ae81aba30e8b1ff2db78606ac","unresolved":false,"context_lines":[{"line_number":291,"context_line":""},{"line_number":292,"context_line":"    @mock.patch(\u0027tempest.lib.common.rest_client.RestClient\u0027)"},{"line_number":293,"context_line":"    def test_no_network_creation_with_config_set(self, MockRestClient):"},{"line_number":294,"context_line":"        creds \u003d dynamic_creds.DynamicCredentialProvider("},{"line_number":295,"context_line":"            neutron_available\u003dTrue, create_networks\u003dFalse,"},{"line_number":296,"context_line":"            project_network_cidr\u003d\u002710.100.0.0/16\u0027, project_network_mask_bits\u003d28,"},{"line_number":297,"context_line":"            **self.fixed_params)"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa6399be_cefe71ad","line":294,"updated":"2016-10-14 08:46:27.000000000","message":"It would make the code easier to read if you also put the \u0027neutron_available\u0027, \u0027create_networks\u0027, \u0027project_network_cidr\u0027, \u0027project_network_mask_bits\u0027 in the \"fixed_params\" dict. And then you copy that dict and update just the one relevant param at the beginning of each test.\n\nI am saying that because people will copy/paste that code to create new tests. So the less code is duplicated the better.","commit_id":"75abbcf11fa78573f36339cd96b7e3c69e897bda"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"beed813d89ef544568035e2b0a0cf55c3fbcbe65","unresolved":false,"context_lines":[{"line_number":291,"context_line":""},{"line_number":292,"context_line":"    @mock.patch(\u0027tempest.lib.common.rest_client.RestClient\u0027)"},{"line_number":293,"context_line":"    def test_no_network_creation_with_config_set(self, MockRestClient):"},{"line_number":294,"context_line":"        creds \u003d dynamic_creds.DynamicCredentialProvider("},{"line_number":295,"context_line":"            neutron_available\u003dTrue, create_networks\u003dFalse,"},{"line_number":296,"context_line":"            project_network_cidr\u003d\u002710.100.0.0/16\u0027, project_network_mask_bits\u003d28,"},{"line_number":297,"context_line":"            **self.fixed_params)"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa6399be_5e0d4c36","line":294,"in_reply_to":"fa6399be_cefe71ad","updated":"2016-10-18 05:08:24.000000000","message":"Yea we can share the code but lets do it in follow up and let is merge.","commit_id":"75abbcf11fa78573f36339cd96b7e3c69e897bda"}]}