)]}'
{"tempest/api/identity/v3/test_tokens.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"dfd25f05e91e1d654df6c8907b399576717fb951","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        # it to be \u0027default\u0027"},{"line_number":35,"context_line":"        token_id, resp \u003d self.non_admin_token.get_token("},{"line_number":36,"context_line":"            user_id\u003duser_id,"},{"line_number":37,"context_line":"            username\u003dusername,"},{"line_number":38,"context_line":"            user_domain_id\u003duser_domain_id,"},{"line_number":39,"context_line":"            password\u003dpassword,"},{"line_number":40,"context_line":"            auth_data\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a77a97e_521b6772","line":37,"updated":"2016-11-15 19:07:09.000000000","message":"What if both username and user_id are supplied ? Which one is used ? Does it make sense to pass both ?","commit_id":"dd9f80514cf8af84b2748aa86df4377281ec54ac"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"11f35b1658fc9a331a844e3e636451b506dca03a","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        # it to be \u0027default\u0027"},{"line_number":35,"context_line":"        token_id, resp \u003d self.non_admin_token.get_token("},{"line_number":36,"context_line":"            user_id\u003duser_id,"},{"line_number":37,"context_line":"            username\u003dusername,"},{"line_number":38,"context_line":"            user_domain_id\u003duser_domain_id,"},{"line_number":39,"context_line":"            password\u003dpassword,"},{"line_number":40,"context_line":"            auth_data\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a77a97e_d273ec13","line":37,"in_reply_to":"7a77a97e_521b6772","updated":"2016-11-16 01:36:26.000000000","message":"if both username and user_id are supplied then user_id takes precedence. This is consistent with the way I think clients should work.\n\nThe function that winds up getting called that https://github.com/openstack/tempest/blob/master/tempest/lib/services/identity/v3/token_client.py#L39 . The docs for that function say it handles different combinations of credentials.","commit_id":"dd9f80514cf8af84b2748aa86df4377281ec54ac"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"6167c9f5d55052f452b4d854eb0d9e7feea95ae1","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        # it to be \u0027default\u0027"},{"line_number":35,"context_line":"        token_id, resp \u003d self.non_admin_token.get_token("},{"line_number":36,"context_line":"            user_id\u003duser_id,"},{"line_number":37,"context_line":"            username\u003dusername,"},{"line_number":38,"context_line":"            user_domain_id\u003duser_domain_id,"},{"line_number":39,"context_line":"            password\u003dpassword,"},{"line_number":40,"context_line":"            auth_data\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a77a97e_7378492c","line":37,"in_reply_to":"7a77a97e_d273ec13","updated":"2016-11-16 11:14:30.000000000","message":"Ok, maybe a log.warning in case they are both supplied would be nice. In a follow up patch, maybe.","commit_id":"dd9f80514cf8af84b2748aa86df4377281ec54ac"}]}