)]}'
{"tempest/api/network/test_networks.py":[{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"2f5cfcbc7a89d52dd9ebbd1f0bcdf80103dec6c3","unresolved":false,"context_lines":[{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    @attr(type\u003d\u0027gate\u0027)"},{"line_number":130,"context_line":"    def test_create_and_delete_port(self):"},{"line_number":131,"context_line":"        #Verify that successful port creation \u0026 deletion"},{"line_number":132,"context_line":"        resp, body \u003d self.client.create_port(self.network[\u0027id\u0027])"},{"line_number":133,"context_line":"        self.assertEqual(\u0027201\u0027, resp[\u0027status\u0027])"},{"line_number":134,"context_line":"        port \u003d body[\u0027port\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAQn%2F%2FX48%3D","line":131,"updated":"2013-08-01 07:45:51.000000000","message":"An additional space would be nice, between the \"#V\".","commit_id":"f527a704843291aa2fd7a33ca31a370a1cef7751"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"2f5cfcbc7a89d52dd9ebbd1f0bcdf80103dec6c3","unresolved":false,"context_lines":[{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    @attr(type\u003d\u0027gate\u0027)"},{"line_number":140,"context_line":"    def test_show_ports(self):"},{"line_number":141,"context_line":"        #Verify the details of port"},{"line_number":142,"context_line":"        resp, body \u003d self.client.show_port(self.port[\u0027id\u0027])"},{"line_number":143,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":144,"context_line":"        port \u003d body[\u0027port\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAQn%2F%2FX5A%3D","line":141,"updated":"2013-08-01 07:45:51.000000000","message":"An additional space would be nice, between the \"#V\".","commit_id":"f527a704843291aa2fd7a33ca31a370a1cef7751"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"64fbdd870389a3b86c7187e9205433fc8317dd5d","unresolved":false,"context_lines":[{"line_number":131,"context_line":"        resp, body \u003d self.client.create_port(self.network[\u0027id\u0027])"},{"line_number":132,"context_line":"        self.assertEqual(\u0027201\u0027, resp[\u0027status\u0027])"},{"line_number":133,"context_line":"        port \u003d body[\u0027port\u0027]"},{"line_number":134,"context_line":"        self.assertTrue(port[\u0027id\u0027] is not None)"},{"line_number":135,"context_line":"        resp, body \u003d self.client.delete_port(port[\u0027id\u0027])"},{"line_number":136,"context_line":"        self.assertEqual(\u0027204\u0027, resp[\u0027status\u0027])"},{"line_number":137,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAQn%2F%2FXRw%3D","line":134,"updated":"2013-08-01 11:31:55.000000000","message":"agree, don\u0027t use assertTrue","commit_id":"76e0377b6c46345bd7a6d794e9b034a9bbd635d7"},{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"5890222b6ae3e99b5179288b1a90a82f260730b7","unresolved":false,"context_lines":[{"line_number":131,"context_line":"        resp, body \u003d self.client.create_port(self.network[\u0027id\u0027])"},{"line_number":132,"context_line":"        self.assertEqual(\u0027201\u0027, resp[\u0027status\u0027])"},{"line_number":133,"context_line":"        port \u003d body[\u0027port\u0027]"},{"line_number":134,"context_line":"        self.assertTrue(port[\u0027id\u0027] is not None)"},{"line_number":135,"context_line":"        resp, body \u003d self.client.delete_port(port[\u0027id\u0027])"},{"line_number":136,"context_line":"        self.assertEqual(\u0027204\u0027, resp[\u0027status\u0027])"},{"line_number":137,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAQn%2F%2FXXU%3D","line":134,"updated":"2013-08-01 10:58:02.000000000","message":"self.assertIsNotNone(port[\u0027id\u0027]) should be better than self.assertTrue.\nBut why do this check?  it is true whatever port[\u0027id\u0027] is except for None.","commit_id":"76e0377b6c46345bd7a6d794e9b034a9bbd635d7"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"64fbdd870389a3b86c7187e9205433fc8317dd5d","unresolved":false,"context_lines":[{"line_number":150,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":151,"context_line":"        ports_list \u003d body[\u0027ports\u0027]"},{"line_number":152,"context_line":"        found \u003d any(n for n in ports_list if n[\u0027id\u0027] \u003d\u003d self.port[\u0027id\u0027])"},{"line_number":153,"context_line":"        self.assertTrue(found)"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"    @attr(type\u003d\u0027gate\u0027)"},{"line_number":156,"context_line":"    def test_update_port(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAQn%2F%2FXRk%3D","line":153,"updated":"2013-08-01 11:31:55.000000000","message":"we have to come up with a way to do this assert without asserTrue, this is not debugable","commit_id":"76e0377b6c46345bd7a6d794e9b034a9bbd635d7"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"7c8aef4f570fd248fc5bad6a336c8f0d7b181ae5","unresolved":false,"context_lines":[{"line_number":152,"context_line":"        for n in ports_list:"},{"line_number":153,"context_line":"            if (n[\u0027id\u0027] \u003d\u003d self.port[\u0027id\u0027]):"},{"line_number":154,"context_line":"                found \u003d n[\u0027id\u0027]"},{"line_number":155,"context_line":"        self.assertIsNotNone(found, \u0027list not showing create port\u0027)"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"    @attr(type\u003d\u0027gate\u0027)"},{"line_number":158,"context_line":"    def test_update_port(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAQn%2F%2FTVQ%3D","line":155,"updated":"2013-08-02 08:45:52.000000000","message":"\"created\" port? Maybe: \"Port list doesn\u0027t contain created port\"?","commit_id":"98ceaf36fcb01b2e26c5b98f7a56f597a0c88bf9"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"6e26b9add286af08502472b2f0123b94c151009d","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        found \u003d None"},{"line_number":121,"context_line":"        for n in networks:"},{"line_number":122,"context_line":"            if (n[\u0027id\u0027] \u003d\u003d self.network[\u0027id\u0027]):"},{"line_number":123,"context_line":"                found \u003d n[\u0027id\u0027]"},{"line_number":124,"context_line":"        msg \u003d \"Network list doesn\u0027t contain created network\""},{"line_number":125,"context_line":"        self.assertIsNotNone(found, msg)"},{"line_number":126,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAQn%2F%2FPdc%3D","line":123,"updated":"2013-08-04 15:09:50.000000000","message":"Not quite sure why you broke this out from the any() call... ?","commit_id":"d40c7bf61ff2b563cc9a1a8cf319924f9f6c5c28"}]}