)]}'
{"tempest/scenario/test_network_basic_ops.py":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"80d245f98daba4ecc2ee30a176e50abe47a65b08","unresolved":false,"context_lines":[{"line_number":330,"context_line":"        self.assertGreater(len(v4_subnets), 0,"},{"line_number":331,"context_line":"                           \"Found %d IPv4 subnets\" % len(v4_subnets))"},{"line_number":332,"context_line":""},{"line_number":333,"context_line":"        external_ips \u003d [v4_subnets[0][\u0027gateway_ip\u0027]]"},{"line_number":334,"context_line":"        self._check_server_connectivity(self.floating_ip_tuple.floating_ip,"},{"line_number":335,"context_line":"                                        external_ips)"},{"line_number":336,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5da102_5b9d4164","line":333,"updated":"2016-10-28 07:58:16.000000000","message":"I\u0027m wondering about here. If we have more than one ipv4 subnets, is this v4_subunets[0] aleays the correct subnet?\nI think we should have a comment about that at least.","commit_id":"796269340d8b80b184c67c222ca2c60881e77e58"},{"author":{"_account_id":19642,"name":"Zou Keke","email":"zoukeke@cmss.chinamobile.com","username":"zoukeke"},"change_message_id":"7303c0479eeb1db287d8e05ebe822dca0380babc","unresolved":false,"context_lines":[{"line_number":330,"context_line":"        self.assertGreater(len(v4_subnets), 0,"},{"line_number":331,"context_line":"                           \"Found %d IPv4 subnets\" % len(v4_subnets))"},{"line_number":332,"context_line":""},{"line_number":333,"context_line":"        external_ips \u003d [v4_subnets[0][\u0027gateway_ip\u0027]]"},{"line_number":334,"context_line":"        self._check_server_connectivity(self.floating_ip_tuple.floating_ip,"},{"line_number":335,"context_line":"                                        external_ips)"},{"line_number":336,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5da102_2677913b","line":333,"in_reply_to":"ba5da102_5b9d4164","updated":"2017-02-07 02:38:14.000000000","message":"Thanks Igawa.I have also considered it before. And we just need some valid external IPv4 addresses(not router_gateway) here to test external connectivity.\nSo we can use v4_subnets[0][\u0027gateway_ip\u0027] as the external ips for simplicity. Any suggestions for the comments?","commit_id":"796269340d8b80b184c67c222ca2c60881e77e58"}]}