)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"76a431dd8529eb2f30755df855f1facfab2c286c","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[WIP] Provide shortcuts to assess neutron plugin compatibility"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Today each 3rd party vendor uses a piecemeal approach when running"},{"line_number":10,"context_line":"3rd party CI to test their solution against neutron changes."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"What I mean by this is that each project uses a huge regex that"},{"line_number":13,"context_line":"cherry picks only a handful of tests [1,2,3]. This approach has"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5a74a57a_c8185f21","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":60},"updated":"2016-11-25 14:14:20.000000000","message":"btw do 3parties ask us to provide tags as proposed? I don\u0027t see vendors lined up to fix their CI ways, do you? What\u0027s their motivation to adopt your proposal if/once we deliver it?","commit_id":"63d6703f8372e4115428a6d6867498ffef9a590e"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"6787edc8625947645dd645e602a56650cd7777c2","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[WIP] Provide shortcuts to assess neutron plugin compatibility"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Today each 3rd party vendor uses a piecemeal approach when running"},{"line_number":10,"context_line":"3rd party CI to test their solution against neutron changes."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"What I mean by this is that each project uses a huge regex that"},{"line_number":13,"context_line":"cherry picks only a handful of tests [1,2,3]. This approach has"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5a74a57a_f84af253","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":60},"in_reply_to":"5a74a57a_c8185f21","updated":"2016-11-29 01:06:27.000000000","message":"I suppose they would have one fewer excuse not to use a symbolic tag","commit_id":"63d6703f8372e4115428a6d6867498ffef9a590e"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b21bbd8b14aca97487fda4418e66f65054344a21","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Today each 3rd party vendor uses a piecemeal approach when running"},{"line_number":10,"context_line":"3rd party CI to test their solution against neutron changes."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"What I mean by this is that each project uses a huge regex that"},{"line_number":13,"context_line":"cherry picks only a handful of tests [1,2,3]. This approach has"},{"line_number":14,"context_line":"a number of drawbacks:"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"a) it is prone to causing coverage holes if tests are renamed"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba5da102_b95129db","line":13,"range":{"start_line":12,"start_character":28,"end_line":13,"end_character":36},"updated":"2016-11-04 16:01:48.000000000","message":"Can\u0027t we just tell them to stop and run all tests? Those that don\u0027t apply to them will be skipped by the virtue of extensions not being enabled in tempest.conf; those applying to them should be executed.\n\nI mean, keeping CI green is not the end goal; CI is to detect legit breakages while the project evolves, and fix them in timely manner. Picking and choosing tests and freezing the list of those executed is not very proactive for integration matters.","commit_id":"63d6703f8372e4115428a6d6867498ffef9a590e"},{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"438854bf05c2839cbe64f49fe5430d383d842805","unresolved":false,"context_lines":[{"line_number":10,"context_line":"3rd party CI to test their solution against neutron changes."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"What I mean by this is that each project uses a huge regex that"},{"line_number":13,"context_line":"cherry picks only a handful of tests [1,2,3]. This approach has"},{"line_number":14,"context_line":"a number of drawbacks:"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"a) it is prone to causing coverage holes if tests are renamed"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da4df55a_32ea0aad","line":13,"in_reply_to":"5a74a57a_98701ea6","updated":"2016-12-27 20:53:14.000000000","message":"Correct Neutron will not have to police anything if they don\u0027t want to. There are potential parties that could police things, but importantly they should be policing based on what Neutron sets as the guideline.","commit_id":"63d6703f8372e4115428a6d6867498ffef9a590e"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"6787edc8625947645dd645e602a56650cd7777c2","unresolved":false,"context_lines":[{"line_number":10,"context_line":"3rd party CI to test their solution against neutron changes."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"What I mean by this is that each project uses a huge regex that"},{"line_number":13,"context_line":"cherry picks only a handful of tests [1,2,3]. This approach has"},{"line_number":14,"context_line":"a number of drawbacks:"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"a) it is prone to causing coverage holes if tests are renamed"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5a74a57a_98701ea6","line":13,"in_reply_to":"5a74a57a_e850bbd6","updated":"2016-11-29 01:06:27.000000000","message":"I don\u0027t want to police anything or anyone. What I was trying to do is to make simpler to discern between apples and oranges.","commit_id":"63d6703f8372e4115428a6d6867498ffef9a590e"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"76a431dd8529eb2f30755df855f1facfab2c286c","unresolved":false,"context_lines":[{"line_number":10,"context_line":"3rd party CI to test their solution against neutron changes."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"What I mean by this is that each project uses a huge regex that"},{"line_number":13,"context_line":"cherry picks only a handful of tests [1,2,3]. This approach has"},{"line_number":14,"context_line":"a number of drawbacks:"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"a) it is prone to causing coverage holes if tests are renamed"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5a74a57a_e850bbd6","line":13,"in_reply_to":"7a77a97e_7ab711f5","updated":"2016-11-25 14:14:20.000000000","message":"I don\u0027t feel like you will get any real control back. Third parties will misbehave, they will ignore your guidelines, and they will not care about getting a new badge. And that\u0027s ok, I don\u0027t think it\u0027s our job to police them. Their users should ask them to be in line with upstream behaviour, not us.\n\nI think it\u0027s on us to suggest 3parties to validate their solutions against full set of tests we produce. Then it\u0027s up to them to set any CI they may want to maintain, to cover features they need. I find push from users and partners and distributions a lot better motivation for vendors than upstream guidelines and tooling.","commit_id":"63d6703f8372e4115428a6d6867498ffef9a590e"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"2da693f8736c35973188397a248b1df233c9ddf1","unresolved":false,"context_lines":[{"line_number":10,"context_line":"3rd party CI to test their solution against neutron changes."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"What I mean by this is that each project uses a huge regex that"},{"line_number":13,"context_line":"cherry picks only a handful of tests [1,2,3]. This approach has"},{"line_number":14,"context_line":"a number of drawbacks:"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"a) it is prone to causing coverage holes if tests are renamed"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a77a97e_7ab711f5","line":13,"in_reply_to":"ba5da102_b95129db","updated":"2016-11-17 03:26:56.000000000","message":"You make a good point, but telling is not enough as what 3rd party CIs end up doing is beyond our control. The proposal allows us to gain some of that control back because with it, it\u0027s easier to a) verify that the expected tests are executed and passing and b) define a minimum bar of functionality that a driver is expected to provide.","commit_id":"63d6703f8372e4115428a6d6867498ffef9a590e"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b21bbd8b14aca97487fda4418e66f65054344a21","unresolved":false,"context_lines":[{"line_number":23,"context_line":"d) I think I can come up with more, but I am ok for now..."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"This patch proposes a labeling convention to be used for 3rd party"},{"line_number":26,"context_line":"validation. Once (and if) labels are agreed on and added to existing"},{"line_number":27,"context_line":"tests, each 3rd party vendor can choose what level of CI validation"},{"line_number":28,"context_line":"it wants to achieve by simply specifying the labels. Even though"},{"line_number":29,"context_line":"vendors get to opt-in the labels, all tests associated to the labels"},{"line_number":30,"context_line":"must run for the test category to be considered exercised."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba5da102_c41c34c4","line":27,"range":{"start_line":26,"start_character":12,"end_line":27,"end_character":5},"updated":"2016-11-04 16:01:48.000000000","message":"Do we plan to guarantee that neutron tests are tagged in some way or another? If not, it may well turn out that we forget to maintain classification for later changes.","commit_id":"63d6703f8372e4115428a6d6867498ffef9a590e"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"6787edc8625947645dd645e602a56650cd7777c2","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"This patch proposes a labeling convention to be used for 3rd party"},{"line_number":26,"context_line":"validation. Once (and if) labels are agreed on and added to existing"},{"line_number":27,"context_line":"tests, each 3rd party vendor can choose what level of CI validation"},{"line_number":28,"context_line":"it wants to achieve by simply specifying the labels. Even though"},{"line_number":29,"context_line":"vendors get to opt-in the labels, all tests associated to the labels"},{"line_number":30,"context_line":"must run for the test category to be considered exercised."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5a74a57a_b86b1ab6","line":27,"in_reply_to":"5a74a57a_85b2d292","updated":"2016-11-29 01:06:27.000000000","message":"a hacking rule could help us spot whether a tag has not been added","commit_id":"63d6703f8372e4115428a6d6867498ffef9a590e"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"76a431dd8529eb2f30755df855f1facfab2c286c","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"This patch proposes a labeling convention to be used for 3rd party"},{"line_number":26,"context_line":"validation. Once (and if) labels are agreed on and added to existing"},{"line_number":27,"context_line":"tests, each 3rd party vendor can choose what level of CI validation"},{"line_number":28,"context_line":"it wants to achieve by simply specifying the labels. Even though"},{"line_number":29,"context_line":"vendors get to opt-in the labels, all tests associated to the labels"},{"line_number":30,"context_line":"must run for the test category to be considered exercised."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5a74a57a_85b2d292","line":27,"in_reply_to":"7a77a97e_3a96793f","updated":"2016-11-25 14:14:20.000000000","message":"Sorry, I probably used bad wording. What I was asking is, how do we guarantee that test classification happens for any new neutron related tests added either here or in neutron tree?","commit_id":"63d6703f8372e4115428a6d6867498ffef9a590e"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"2da693f8736c35973188397a248b1df233c9ddf1","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"This patch proposes a labeling convention to be used for 3rd party"},{"line_number":26,"context_line":"validation. Once (and if) labels are agreed on and added to existing"},{"line_number":27,"context_line":"tests, each 3rd party vendor can choose what level of CI validation"},{"line_number":28,"context_line":"it wants to achieve by simply specifying the labels. Even though"},{"line_number":29,"context_line":"vendors get to opt-in the labels, all tests associated to the labels"},{"line_number":30,"context_line":"must run for the test category to be considered exercised."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a77a97e_3a96793f","line":27,"in_reply_to":"ba5da102_c41c34c4","updated":"2016-11-17 03:26:56.000000000","message":"I would like to look at the neutron API tests too. I started here because I wanted a feedback from tempest folks first. I must admit, I am overwhelmed by the enthusiastic reaction I have received so far, not!","commit_id":"63d6703f8372e4115428a6d6867498ffef9a590e"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b21bbd8b14aca97487fda4418e66f65054344a21","unresolved":false,"context_lines":[{"line_number":26,"context_line":"validation. Once (and if) labels are agreed on and added to existing"},{"line_number":27,"context_line":"tests, each 3rd party vendor can choose what level of CI validation"},{"line_number":28,"context_line":"it wants to achieve by simply specifying the labels. Even though"},{"line_number":29,"context_line":"vendors get to opt-in the labels, all tests associated to the labels"},{"line_number":30,"context_line":"must run for the test category to be considered exercised."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Besides the benefit of addressing drawbacks a-d as mentioned above,"},{"line_number":33,"context_line":"this approach empowers the neutron team to advise what level of"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba5da102_a433c0f5","line":30,"range":{"start_line":29,"start_character":34,"end_line":30,"end_character":58},"updated":"2016-11-04 16:01:48.000000000","message":"One problem with that is that if the plugin under consideration does not implement a specific extension that is needed by a test, the test will be skipped right away. So yeah, it will be executed, but short-circuited; so without diving into actual results, it\u0027s still hard to tell if a 3rd party actually covers a feature with CI, or just pretends to.","commit_id":"63d6703f8372e4115428a6d6867498ffef9a590e"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"2da693f8736c35973188397a248b1df233c9ddf1","unresolved":false,"context_lines":[{"line_number":27,"context_line":"tests, each 3rd party vendor can choose what level of CI validation"},{"line_number":28,"context_line":"it wants to achieve by simply specifying the labels. Even though"},{"line_number":29,"context_line":"vendors get to opt-in the labels, all tests associated to the labels"},{"line_number":30,"context_line":"must run for the test category to be considered exercised."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Besides the benefit of addressing drawbacks a-d as mentioned above,"},{"line_number":33,"context_line":"this approach empowers the neutron team to advise what level of"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a77a97e_3abd99b7","line":30,"in_reply_to":"ba5da102_a433c0f5","updated":"2016-11-17 03:26:56.000000000","message":"true, but if tooling is put in place it\u0027s easier to assert that no tests must be skipped.","commit_id":"63d6703f8372e4115428a6d6867498ffef9a590e"}],"tempest/api/network/README":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b21bbd8b14aca97487fda4418e66f65054344a21","unresolved":false,"context_lines":[{"line_number":6,"context_line":" * an L3 service plugin;"},{"line_number":7,"context_line":" * an L3 flavor driver;"},{"line_number":8,"context_line":" * a generic service plugin (QoS, Trunk, ...);"},{"line_number":9,"context_line":" "},{"line_number":10,"context_line":"The following attributes are defined to qualify level of support of"},{"line_number":11,"context_line":"the neutron APIs:"},{"line_number":12,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"ba5da102_24c970ad","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":1},"updated":"2016-11-04 16:01:48.000000000","message":"heresy!!! Reds are coming!","commit_id":"63d6703f8372e4115428a6d6867498ffef9a590e"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"2da693f8736c35973188397a248b1df233c9ddf1","unresolved":false,"context_lines":[{"line_number":6,"context_line":" * an L3 service plugin;"},{"line_number":7,"context_line":" * an L3 flavor driver;"},{"line_number":8,"context_line":" * a generic service plugin (QoS, Trunk, ...);"},{"line_number":9,"context_line":" "},{"line_number":10,"context_line":"The following attributes are defined to qualify level of support of"},{"line_number":11,"context_line":"the neutron APIs:"},{"line_number":12,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"7a77a97e_7ab391e9","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":1},"in_reply_to":"ba5da102_24c970ad","updated":"2016-11-17 03:26:56.000000000","message":"OMG","commit_id":"63d6703f8372e4115428a6d6867498ffef9a590e"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"df3dfca6c716085c2af347c5cc74b4831e711681","unresolved":false,"context_lines":[{"line_number":8,"context_line":" * a generic service plugin (QoS, Trunk, ...);"},{"line_number":9,"context_line":" "},{"line_number":10,"context_line":"The following attributes are defined to qualify level of support of"},{"line_number":11,"context_line":"the neutron APIs:"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"* net-core: to be applied to a test that validates the core neutron v2"},{"line_number":14,"context_line":"  API, plus any extension (i.e. port binding) that is relied on by"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"ba5201f7_21572a27","line":11,"updated":"2017-01-05 07:01:05.000000000","message":"my honest impression is that tempest network-feature-enabled is good enough to tweak a set of features to test.","commit_id":"63d6703f8372e4115428a6d6867498ffef9a590e"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b21bbd8b14aca97487fda4418e66f65054344a21","unresolved":false,"context_lines":[{"line_number":15,"context_line":"  projects like nova to fulfill higher level operations like boot."},{"line_number":16,"context_line":"* net-ipam: to be applied to a test that validates IPAM operations;"},{"line_number":17,"context_line":"* net-security: to be applied to a test that validates security operations."},{"line_number":18,"context_line":"* net-security-extra: to be applied to a test that validates extensions"},{"line_number":19,"context_line":"  to security operations."},{"line_number":20,"context_line":"* net-security-ipv6: like net-security, but for ipv6."},{"line_number":21,"context_line":"* net-routing: to be applied to a test that validates routing operations."}],"source_content_type":"application/octet-stream","patch_set":1,"id":"ba5da102_f94d619a","line":18,"range":{"start_line":18,"start_character":2,"end_line":18,"end_character":20},"updated":"2016-11-04 16:01:48.000000000","message":"you lost me here. What\u0027s the distinction between this and net-security?","commit_id":"63d6703f8372e4115428a6d6867498ffef9a590e"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"df3dfca6c716085c2af347c5cc74b4831e711681","unresolved":false,"context_lines":[{"line_number":15,"context_line":"  projects like nova to fulfill higher level operations like boot."},{"line_number":16,"context_line":"* net-ipam: to be applied to a test that validates IPAM operations;"},{"line_number":17,"context_line":"* net-security: to be applied to a test that validates security operations."},{"line_number":18,"context_line":"* net-security-extra: to be applied to a test that validates extensions"},{"line_number":19,"context_line":"  to security operations."},{"line_number":20,"context_line":"* net-security-ipv6: like net-security, but for ipv6."},{"line_number":21,"context_line":"* net-routing: to be applied to a test that validates routing operations."}],"source_content_type":"application/octet-stream","patch_set":1,"id":"ba5201f7_01b06689","line":18,"range":{"start_line":18,"start_character":2,"end_line":18,"end_character":20},"in_reply_to":"7a77a97e_5afc1572","updated":"2017-01-05 07:01:05.000000000","message":"in that case, -optional might be a better name.","commit_id":"63d6703f8372e4115428a6d6867498ffef9a590e"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"2da693f8736c35973188397a248b1df233c9ddf1","unresolved":false,"context_lines":[{"line_number":15,"context_line":"  projects like nova to fulfill higher level operations like boot."},{"line_number":16,"context_line":"* net-ipam: to be applied to a test that validates IPAM operations;"},{"line_number":17,"context_line":"* net-security: to be applied to a test that validates security operations."},{"line_number":18,"context_line":"* net-security-extra: to be applied to a test that validates extensions"},{"line_number":19,"context_line":"  to security operations."},{"line_number":20,"context_line":"* net-security-ipv6: like net-security, but for ipv6."},{"line_number":21,"context_line":"* net-routing: to be applied to a test that validates routing operations."}],"source_content_type":"application/octet-stream","patch_set":1,"id":"7a77a97e_5afc1572","line":18,"range":{"start_line":18,"start_character":2,"end_line":18,"end_character":20},"in_reply_to":"ba5da102_f94d619a","updated":"2016-11-17 03:26:56.000000000","message":"we have a number of things we implement to provide security, like security groups, port security, allowed-address-pairs, \u003cadd the extension of your choice\u003e. The distinction here is that there\u0027s one bucket of security related features that must be absolutely be there and tested, the other bucket (-extra) that include things that we can consider optional.","commit_id":"63d6703f8372e4115428a6d6867498ffef9a590e"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b21bbd8b14aca97487fda4418e66f65054344a21","unresolved":false,"context_lines":[{"line_number":17,"context_line":"* net-security: to be applied to a test that validates security operations."},{"line_number":18,"context_line":"* net-security-extra: to be applied to a test that validates extensions"},{"line_number":19,"context_line":"  to security operations."},{"line_number":20,"context_line":"* net-security-ipv6: like net-security, but for ipv6."},{"line_number":21,"context_line":"* net-routing: to be applied to a test that validates routing operations."},{"line_number":22,"context_line":"* net-routing-ipv6: like net-routing, but for ipv6."},{"line_number":23,"context_line":"* net-routing-distributed: to be applied to a test that validates"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"ba5da102_f93481fc","line":20,"range":{"start_line":20,"start_character":2,"end_line":20,"end_character":19},"updated":"2016-11-04 16:01:48.000000000","message":"(trying to follow lines 17-18) do we need net-security-ipv6-extra?","commit_id":"63d6703f8372e4115428a6d6867498ffef9a590e"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"76a431dd8529eb2f30755df855f1facfab2c286c","unresolved":false,"context_lines":[{"line_number":17,"context_line":"* net-security: to be applied to a test that validates security operations."},{"line_number":18,"context_line":"* net-security-extra: to be applied to a test that validates extensions"},{"line_number":19,"context_line":"  to security operations."},{"line_number":20,"context_line":"* net-security-ipv6: like net-security, but for ipv6."},{"line_number":21,"context_line":"* net-routing: to be applied to a test that validates routing operations."},{"line_number":22,"context_line":"* net-routing-ipv6: like net-routing, but for ipv6."},{"line_number":23,"context_line":"* net-routing-distributed: to be applied to a test that validates"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"5a74a57a_680f4b88","line":20,"range":{"start_line":20,"start_character":2,"end_line":20,"end_character":19},"in_reply_to":"7a77a97e_9afa2d74","updated":"2016-11-25 14:14:20.000000000","message":"Not sure. I was thinking that net-security is let\u0027s say security groups, while net-security-extra is e.g. allowed-address-pairs. If that\u0027s the case, and we have net-security-ipv6 (apparently for SG IPv6 rules?), then we need net-security-ipv6-extra (for IPv6 allowed-address-pairs).","commit_id":"63d6703f8372e4115428a6d6867498ffef9a590e"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"2da693f8736c35973188397a248b1df233c9ddf1","unresolved":false,"context_lines":[{"line_number":17,"context_line":"* net-security: to be applied to a test that validates security operations."},{"line_number":18,"context_line":"* net-security-extra: to be applied to a test that validates extensions"},{"line_number":19,"context_line":"  to security operations."},{"line_number":20,"context_line":"* net-security-ipv6: like net-security, but for ipv6."},{"line_number":21,"context_line":"* net-routing: to be applied to a test that validates routing operations."},{"line_number":22,"context_line":"* net-routing-ipv6: like net-routing, but for ipv6."},{"line_number":23,"context_line":"* net-routing-distributed: to be applied to a test that validates"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"7a77a97e_9afa2d74","line":20,"range":{"start_line":20,"start_character":2,"end_line":20,"end_character":19},"in_reply_to":"ba5da102_f93481fc","updated":"2016-11-17 03:26:56.000000000","message":"does my answer above help?","commit_id":"63d6703f8372e4115428a6d6867498ffef9a590e"},{"author":{"_account_id":6558,"name":"Sukhdev Kapur","email":"sukhdevkapur@gmail.com","username":"sukhdev-8"},"change_message_id":"30e1ff42728619005498e1eb0ef7646910ea5a43","unresolved":false,"context_lines":[{"line_number":18,"context_line":"* net-security-extra: to be applied to a test that validates extensions"},{"line_number":19,"context_line":"  to security operations."},{"line_number":20,"context_line":"* net-security-ipv6: like net-security, but for ipv6."},{"line_number":21,"context_line":"* net-routing: to be applied to a test that validates routing operations."},{"line_number":22,"context_line":"* net-routing-ipv6: like net-routing, but for ipv6."},{"line_number":23,"context_line":"* net-routing-distributed: to be applied to a test that validates"},{"line_number":24,"context_line":"  distributed routing."}],"source_content_type":"application/octet-stream","patch_set":1,"id":"ba5201f7_75820596","line":21,"range":{"start_line":21,"start_character":2,"end_line":21,"end_character":14},"updated":"2017-01-04 01:15:36.000000000","message":"I wonder if net-routing should be split into two - i.e. net-routing and net-routing-gw. \n\nSome of the vendor L3 plugin may not care (or want) to support gateway functionality. They will end up failing most of these tests.","commit_id":"63d6703f8372e4115428a6d6867498ffef9a590e"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b21bbd8b14aca97487fda4418e66f65054344a21","unresolved":false,"context_lines":[{"line_number":19,"context_line":"  to security operations."},{"line_number":20,"context_line":"* net-security-ipv6: like net-security, but for ipv6."},{"line_number":21,"context_line":"* net-routing: to be applied to a test that validates routing operations."},{"line_number":22,"context_line":"* net-routing-ipv6: like net-routing, but for ipv6."},{"line_number":23,"context_line":"* net-routing-distributed: to be applied to a test that validates"},{"line_number":24,"context_line":"  distributed routing."},{"line_number":25,"context_line":"* net-routing-distributed-ipv6: like net-routing-distributed, but for ipv6."}],"source_content_type":"application/octet-stream","patch_set":1,"id":"ba5da102_c4e35432","line":22,"range":{"start_line":22,"start_character":2,"end_line":22,"end_character":18},"updated":"2016-11-04 16:01:48.000000000","message":"ipv4/ipv6 distinction is a bit synthetic to my taste. We don\u0027t provide API level distinction for ipv6 subnets that would allow plugins to opt out of ipv6 support; ipv6 is an old feature (Juno?); I believe all legit implementations should have got support for ipv6 by now.","commit_id":"63d6703f8372e4115428a6d6867498ffef9a590e"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"2da693f8736c35973188397a248b1df233c9ddf1","unresolved":false,"context_lines":[{"line_number":19,"context_line":"  to security operations."},{"line_number":20,"context_line":"* net-security-ipv6: like net-security, but for ipv6."},{"line_number":21,"context_line":"* net-routing: to be applied to a test that validates routing operations."},{"line_number":22,"context_line":"* net-routing-ipv6: like net-routing, but for ipv6."},{"line_number":23,"context_line":"* net-routing-distributed: to be applied to a test that validates"},{"line_number":24,"context_line":"  distributed routing."},{"line_number":25,"context_line":"* net-routing-distributed-ipv6: like net-routing-distributed, but for ipv6."}],"source_content_type":"application/octet-stream","patch_set":1,"id":"7a77a97e_fa1b21c8","line":22,"range":{"start_line":22,"start_character":2,"end_line":22,"end_character":18},"in_reply_to":"ba5da102_c4e35432","updated":"2016-11-17 03:26:56.000000000","message":"I agree. Reality is that some ipv6 tests may be skipped the way tempest is configured. Some IPAM drivers may be not v6 capable :/...I am simply capturing what is the current situation.","commit_id":"63d6703f8372e4115428a6d6867498ffef9a590e"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b21bbd8b14aca97487fda4418e66f65054344a21","unresolved":false,"context_lines":[{"line_number":20,"context_line":"* net-security-ipv6: like net-security, but for ipv6."},{"line_number":21,"context_line":"* net-routing: to be applied to a test that validates routing operations."},{"line_number":22,"context_line":"* net-routing-ipv6: like net-routing, but for ipv6."},{"line_number":23,"context_line":"* net-routing-distributed: to be applied to a test that validates"},{"line_number":24,"context_line":"  distributed routing."},{"line_number":25,"context_line":"* net-routing-distributed-ipv6: like net-routing-distributed, but for ipv6."},{"line_number":26,"context_line":"* net-routing-extra: to be applied to a test that validates extensions"},{"line_number":27,"context_line":"  to the routing layer."}],"source_content_type":"application/octet-stream","patch_set":1,"id":"ba5da102_240ed0e5","line":24,"range":{"start_line":23,"start_character":2,"end_line":24,"end_character":22},"updated":"2016-11-04 16:01:48.000000000","message":"I am wondering why does it matter for a user to know if that feature is supported by the backend. What they probably should care is performance metrics for different east-west/south-north scenarios, and that\u0027s not what tempest tags will give to us.","commit_id":"63d6703f8372e4115428a6d6867498ffef9a590e"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"6787edc8625947645dd645e602a56650cd7777c2","unresolved":false,"context_lines":[{"line_number":20,"context_line":"* net-security-ipv6: like net-security, but for ipv6."},{"line_number":21,"context_line":"* net-routing: to be applied to a test that validates routing operations."},{"line_number":22,"context_line":"* net-routing-ipv6: like net-routing, but for ipv6."},{"line_number":23,"context_line":"* net-routing-distributed: to be applied to a test that validates"},{"line_number":24,"context_line":"  distributed routing."},{"line_number":25,"context_line":"* net-routing-distributed-ipv6: like net-routing-distributed, but for ipv6."},{"line_number":26,"context_line":"* net-routing-extra: to be applied to a test that validates extensions"},{"line_number":27,"context_line":"  to the routing layer."}],"source_content_type":"application/octet-stream","patch_set":1,"id":"5a74a57a_389e2ab9","line":24,"range":{"start_line":23,"start_character":2,"end_line":24,"end_character":22},"in_reply_to":"5a74a57a_0897b7ec","updated":"2016-11-29 01:06:27.000000000","message":"that could be a sensible first step, perhaps","commit_id":"63d6703f8372e4115428a6d6867498ffef9a590e"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"76a431dd8529eb2f30755df855f1facfab2c286c","unresolved":false,"context_lines":[{"line_number":20,"context_line":"* net-security-ipv6: like net-security, but for ipv6."},{"line_number":21,"context_line":"* net-routing: to be applied to a test that validates routing operations."},{"line_number":22,"context_line":"* net-routing-ipv6: like net-routing, but for ipv6."},{"line_number":23,"context_line":"* net-routing-distributed: to be applied to a test that validates"},{"line_number":24,"context_line":"  distributed routing."},{"line_number":25,"context_line":"* net-routing-distributed-ipv6: like net-routing-distributed, but for ipv6."},{"line_number":26,"context_line":"* net-routing-extra: to be applied to a test that validates extensions"},{"line_number":27,"context_line":"  to the routing layer."}],"source_content_type":"application/octet-stream","patch_set":1,"id":"5a74a57a_0897b7ec","line":24,"range":{"start_line":23,"start_character":2,"end_line":24,"end_character":22},"in_reply_to":"7a77a97e_fa8ec1ce","updated":"2016-11-25 14:14:20.000000000","message":"I think the tool without motivation for vendors to comply will not change much. Are you thinking about enforcing the minimal bar somehow, at least for stadium participants?","commit_id":"63d6703f8372e4115428a6d6867498ffef9a590e"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"2da693f8736c35973188397a248b1df233c9ddf1","unresolved":false,"context_lines":[{"line_number":20,"context_line":"* net-security-ipv6: like net-security, but for ipv6."},{"line_number":21,"context_line":"* net-routing: to be applied to a test that validates routing operations."},{"line_number":22,"context_line":"* net-routing-ipv6: like net-routing, but for ipv6."},{"line_number":23,"context_line":"* net-routing-distributed: to be applied to a test that validates"},{"line_number":24,"context_line":"  distributed routing."},{"line_number":25,"context_line":"* net-routing-distributed-ipv6: like net-routing-distributed, but for ipv6."},{"line_number":26,"context_line":"* net-routing-extra: to be applied to a test that validates extensions"},{"line_number":27,"context_line":"  to the routing layer."}],"source_content_type":"application/octet-stream","patch_set":1,"id":"7a77a97e_fa8ec1ce","line":24,"range":{"start_line":23,"start_character":2,"end_line":24,"end_character":22},"in_reply_to":"ba5da102_240ed0e5","updated":"2016-11-17 03:26:56.000000000","message":"As briefly hinted in the comment above, we have tests in the tempest tree that exercise this capability. CIs may skip this because the plugin under test  is unable to meet the contract. \n\nBear in mind that this isn\u0027t meant to be a tool for users but for neutron and neutron driver providers.","commit_id":"63d6703f8372e4115428a6d6867498ffef9a590e"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b21bbd8b14aca97487fda4418e66f65054344a21","unresolved":false,"context_lines":[{"line_number":23,"context_line":"* net-routing-distributed: to be applied to a test that validates"},{"line_number":24,"context_line":"  distributed routing."},{"line_number":25,"context_line":"* net-routing-distributed-ipv6: like net-routing-distributed, but for ipv6."},{"line_number":26,"context_line":"* net-routing-extra: to be applied to a test that validates extensions"},{"line_number":27,"context_line":"  to the routing layer."},{"line_number":28,"context_line":"* net-routing-extra-ipv6: same as net-routing-extra, but for ipv6."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"A core plugin/ML2 mechanism driver is expected to pass tests with the"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"ba5da102_c4ffd4a8","line":27,"range":{"start_line":26,"start_character":60,"end_line":27,"end_character":22},"updated":"2016-11-04 16:01:48.000000000","message":"that does look rather vague","commit_id":"63d6703f8372e4115428a6d6867498ffef9a590e"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"2da693f8736c35973188397a248b1df233c9ddf1","unresolved":false,"context_lines":[{"line_number":23,"context_line":"* net-routing-distributed: to be applied to a test that validates"},{"line_number":24,"context_line":"  distributed routing."},{"line_number":25,"context_line":"* net-routing-distributed-ipv6: like net-routing-distributed, but for ipv6."},{"line_number":26,"context_line":"* net-routing-extra: to be applied to a test that validates extensions"},{"line_number":27,"context_line":"  to the routing layer."},{"line_number":28,"context_line":"* net-routing-extra-ipv6: same as net-routing-extra, but for ipv6."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"A core plugin/ML2 mechanism driver is expected to pass tests with the"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"7a77a97e_5ab41581","line":27,"range":{"start_line":26,"start_character":60,"end_line":27,"end_character":22},"in_reply_to":"ba5da102_c4ffd4a8","updated":"2016-11-17 03:26:56.000000000","message":"Routing is a vast area!","commit_id":"63d6703f8372e4115428a6d6867498ffef9a590e"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"df3dfca6c716085c2af347c5cc74b4831e711681","unresolved":false,"context_lines":[{"line_number":36,"context_line":"  * net-ipam"},{"line_number":37,"context_line":"  * net-security"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"* optional:"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"  * net-security-ipv6,"},{"line_number":42,"context_line":"  * net-security-extra"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"ba5201f7_8138d6f0","line":39,"range":{"start_line":39,"start_character":2,"end_line":39,"end_character":10},"updated":"2017-01-05 07:01:05.000000000","message":"isn\u0027t it simpler to have a single \"optional\" tag,\nand leave the rest to tempest network-feature-enabled?","commit_id":"63d6703f8372e4115428a6d6867498ffef9a590e"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b21bbd8b14aca97487fda4418e66f65054344a21","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"  * net-security-ipv6,"},{"line_number":42,"context_line":"  * net-security-extra"},{"line_number":43,"context_line":"  * net-security-extra-ipv6"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"An L3 plugin/flavor driver is expected to pass tests with the following"},{"line_number":46,"context_line":"attributes:"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"ba5da102_849f9c4f","line":43,"range":{"start_line":43,"start_character":4,"end_line":43,"end_character":27},"updated":"2016-11-04 16:01:48.000000000","message":"oh you have it here!","commit_id":"63d6703f8372e4115428a6d6867498ffef9a590e"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"76a431dd8529eb2f30755df855f1facfab2c286c","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"  * net-security-ipv6,"},{"line_number":42,"context_line":"  * net-security-extra"},{"line_number":43,"context_line":"  * net-security-extra-ipv6"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"An L3 plugin/flavor driver is expected to pass tests with the following"},{"line_number":46,"context_line":"attributes:"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"5a74a57a_68a2eb4c","line":43,"range":{"start_line":43,"start_character":4,"end_line":43,"end_character":27},"in_reply_to":"7a77a97e_7ab9d178","updated":"2016-11-25 14:14:20.000000000","message":"NO. :-x","commit_id":"63d6703f8372e4115428a6d6867498ffef9a590e"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"2da693f8736c35973188397a248b1df233c9ddf1","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"  * net-security-ipv6,"},{"line_number":42,"context_line":"  * net-security-extra"},{"line_number":43,"context_line":"  * net-security-extra-ipv6"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"An L3 plugin/flavor driver is expected to pass tests with the following"},{"line_number":46,"context_line":"attributes:"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"7a77a97e_7ab9d178","line":43,"range":{"start_line":43,"start_character":4,"end_line":43,"end_character":27},"in_reply_to":"ba5da102_849f9c4f","updated":"2016-11-17 03:26:56.000000000","message":"do you like it?","commit_id":"63d6703f8372e4115428a6d6867498ffef9a590e"}],"tempest/api/network/test_allowed_address_pair.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b21bbd8b14aca97487fda4418e66f65054344a21","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        cls.ip_address \u003d port[\u0027fixed_ips\u0027][0][\u0027ip_address\u0027]"},{"line_number":57,"context_line":"        cls.mac_address \u003d port[\u0027mac_address\u0027]"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    @test.attr(type\u003d[\u0027net-security-extra\u0027, \u0027net-security-extra-ipv6\u0027])"},{"line_number":60,"context_line":"    @test.idempotent_id(\u002786c3529b-1231-40de-803c-00e40882f043\u0027)"},{"line_number":61,"context_line":"    def test_create_list_port_with_address_pair(self):"},{"line_number":62,"context_line":"        # Create port with allowed address pair attribute"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_e42938f4","line":59,"updated":"2016-11-04 16:01:48.000000000","message":"you tag each test with both, even though probably you want ipv6 applied only to test cases that come from V6 version of the test class.","commit_id":"63d6703f8372e4115428a6d6867498ffef9a590e"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"df3dfca6c716085c2af347c5cc74b4831e711681","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        cls.ip_address \u003d port[\u0027fixed_ips\u0027][0][\u0027ip_address\u0027]"},{"line_number":57,"context_line":"        cls.mac_address \u003d port[\u0027mac_address\u0027]"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    @test.attr(type\u003d[\u0027net-security-extra\u0027, \u0027net-security-extra-ipv6\u0027])"},{"line_number":60,"context_line":"    @test.idempotent_id(\u002786c3529b-1231-40de-803c-00e40882f043\u0027)"},{"line_number":61,"context_line":"    def test_create_list_port_with_address_pair(self):"},{"line_number":62,"context_line":"        # Create port with allowed address pair attribute"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5201f7_21fbaa48","line":59,"in_reply_to":"ba5da102_e42938f4","updated":"2017-01-05 07:01:05.000000000","message":"+1","commit_id":"63d6703f8372e4115428a6d6867498ffef9a590e"}],"tempest/api/network/test_routers.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b21bbd8b14aca97487fda4418e66f65054344a21","unresolved":false,"context_lines":[{"line_number":45,"context_line":"                           if cls._ip_version \u003d\u003d 4 else"},{"line_number":46,"context_line":"                           CONF.network.project_network_v6_cidr)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    @test.attr(type\u003d[\u0027smoke\u0027, \u0027net-routing\u0027, \u0027net-routing-ipv6\u0027])"},{"line_number":49,"context_line":"    @test.idempotent_id(\u0027f64403e2-8483-4b34-8ccd-b09a87bcc68c\u0027)"},{"line_number":50,"context_line":"    def test_create_show_list_update_delete_router(self):"},{"line_number":51,"context_line":"        # Create a router"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_24d090c9","line":48,"updated":"2016-11-04 16:01:48.000000000","message":"same problem with v4/v6 distinction as in the prev file","commit_id":"63d6703f8372e4115428a6d6867498ffef9a590e"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"76a431dd8529eb2f30755df855f1facfab2c286c","unresolved":false,"context_lines":[{"line_number":45,"context_line":"                           if cls._ip_version \u003d\u003d 4 else"},{"line_number":46,"context_line":"                           CONF.network.project_network_v6_cidr)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    @test.attr(type\u003d[\u0027smoke\u0027, \u0027net-routing\u0027, \u0027net-routing-ipv6\u0027])"},{"line_number":49,"context_line":"    @test.idempotent_id(\u0027f64403e2-8483-4b34-8ccd-b09a87bcc68c\u0027)"},{"line_number":50,"context_line":"    def test_create_show_list_update_delete_router(self):"},{"line_number":51,"context_line":"        # Create a router"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a74a57a_88b2e792","line":48,"in_reply_to":"7a77a97e_faa5e146","updated":"2016-11-25 14:14:20.000000000","message":"\"you tag each test with both, even though probably you want ipv6 applied only to test cases that come from V6 version of the test class.\"","commit_id":"63d6703f8372e4115428a6d6867498ffef9a590e"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"2da693f8736c35973188397a248b1df233c9ddf1","unresolved":false,"context_lines":[{"line_number":45,"context_line":"                           if cls._ip_version \u003d\u003d 4 else"},{"line_number":46,"context_line":"                           CONF.network.project_network_v6_cidr)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    @test.attr(type\u003d[\u0027smoke\u0027, \u0027net-routing\u0027, \u0027net-routing-ipv6\u0027])"},{"line_number":49,"context_line":"    @test.idempotent_id(\u0027f64403e2-8483-4b34-8ccd-b09a87bcc68c\u0027)"},{"line_number":50,"context_line":"    def test_create_show_list_update_delete_router(self):"},{"line_number":51,"context_line":"        # Create a router"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a77a97e_faa5e146","line":48,"in_reply_to":"ba5da102_24d090c9","updated":"2016-11-17 03:26:56.000000000","message":"what problem are you referring to? Not sure I follow.","commit_id":"63d6703f8372e4115428a6d6867498ffef9a590e"},{"author":{"_account_id":6558,"name":"Sukhdev Kapur","email":"sukhdevkapur@gmail.com","username":"sukhdev-8"},"change_message_id":"30e1ff42728619005498e1eb0ef7646910ea5a43","unresolved":false,"context_lines":[{"line_number":201,"context_line":"            subnet_id \u003d fixed_ip[\u0027subnet_id\u0027]"},{"line_number":202,"context_line":"            self.assertIn(subnet_id, public_subnet_ids)"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"    @test.attr(type\u003d[\u0027net-routing\u0027, \u0027net-routing-ipv6\u0027])"},{"line_number":205,"context_line":"    @test.idempotent_id(\u00276cc285d8-46bf-4f36-9b1a-783e3008ba79\u0027)"},{"line_number":206,"context_line":"    def test_update_router_set_gateway(self):"},{"line_number":207,"context_line":"        router \u003d self._create_router()"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5201f7_f53b55e9","line":204,"range":{"start_line":204,"start_character":22,"end_line":204,"end_character":34},"updated":"2017-01-04 01:15:36.000000000","message":"net-routing-gw ?\n\nSee my comment on the other file.","commit_id":"63d6703f8372e4115428a6d6867498ffef9a590e"},{"author":{"_account_id":6558,"name":"Sukhdev Kapur","email":"sukhdevkapur@gmail.com","username":"sukhdev-8"},"change_message_id":"30e1ff42728619005498e1eb0ef7646910ea5a43","unresolved":false,"context_lines":[{"line_number":247,"context_line":"             \u0027enable_snat\u0027: False})"},{"line_number":248,"context_line":"        self._verify_gateway_port(router[\u0027id\u0027])"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"    @test.attr(type\u003d[\u0027net-routing\u0027, \u0027net-routing-ipv6\u0027])"},{"line_number":251,"context_line":"    @test.idempotent_id(\u0027ad81b7ee-4f81-407b-a19c-17e623f763e8\u0027)"},{"line_number":252,"context_line":"    def test_update_router_unset_gateway(self):"},{"line_number":253,"context_line":"        router \u003d self._create_router("}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5201f7_d51bb17e","line":250,"updated":"2017-01-04 01:15:36.000000000","message":"ditto","commit_id":"63d6703f8372e4115428a6d6867498ffef9a590e"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b21bbd8b14aca97487fda4418e66f65054344a21","unresolved":false,"context_lines":[{"line_number":413,"context_line":"            raise cls.skipException(msg)"},{"line_number":414,"context_line":""},{"line_number":415,"context_line":"    @test.attr(type\u003d[\u0027net-routing-distributed\u0027,"},{"line_number":416,"context_line":"                     \u0027net-routing-distributed-ipv6\u0027])"},{"line_number":417,"context_line":"    @test.idempotent_id(\u0027141297aa-3424-455d-aa8d-f2d95731e00a\u0027)"},{"line_number":418,"context_line":"    def test_create_distributed_router(self):"},{"line_number":419,"context_line":"        name \u003d data_utils.rand_name(\u0027router\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_44a3c44f","line":416,"updated":"2016-11-04 16:01:48.000000000","message":"It seems like the base class is ip_version \u003d 4 (it bubbles up to BaseNetworkTest).","commit_id":"63d6703f8372e4115428a6d6867498ffef9a590e"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"2da693f8736c35973188397a248b1df233c9ddf1","unresolved":false,"context_lines":[{"line_number":413,"context_line":"            raise cls.skipException(msg)"},{"line_number":414,"context_line":""},{"line_number":415,"context_line":"    @test.attr(type\u003d[\u0027net-routing-distributed\u0027,"},{"line_number":416,"context_line":"                     \u0027net-routing-distributed-ipv6\u0027])"},{"line_number":417,"context_line":"    @test.idempotent_id(\u0027141297aa-3424-455d-aa8d-f2d95731e00a\u0027)"},{"line_number":418,"context_line":"    def test_create_distributed_router(self):"},{"line_number":419,"context_line":"        name \u003d data_utils.rand_name(\u0027router\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a77a97e_da7f45a9","line":416,"in_reply_to":"ba5da102_44a3c44f","updated":"2016-11-17 03:26:56.000000000","message":"um, I might have applied a wrong type. Let me check.","commit_id":"63d6703f8372e4115428a6d6867498ffef9a590e"}]}