)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"c3731d265d586e305e8349fc1bc536ef7ecd2582","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use random name in network common function"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Commit d2c40cace00f19a835e8f0e26620d69105b43e74 seemed like missing"},{"line_number":10,"context_line":"one position, this patch is to append that."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Use random name in network\u0027s common function to remove flushing"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ba5da102_e33b8e36","line":9,"updated":"2016-11-01 06:20:27.000000000","message":"nit, we prefer use \"Change-Id\" to \"commit id\".","commit_id":"d6f612dc9daed6c73ba1dc1ab308ba86925b296d"},{"author":{"_account_id":23413,"name":"Tianbiao Qi","email":"qitianbiao@gmail.com","username":"trisq"},"change_message_id":"c67415053107da2c75fc552dc25fcf83f81e2cb1","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use random name in network common function"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Commit d2c40cace00f19a835e8f0e26620d69105b43e74 seemed like missing"},{"line_number":10,"context_line":"one position, this patch is to append that."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Use random name in network\u0027s common function to remove flushing"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ba5da102_15ddf16e","line":9,"in_reply_to":"ba5da102_e33b8e36","updated":"2016-11-02 03:32:50.000000000","message":"Thanks for comments. Change-Id it is now.","commit_id":"d6f612dc9daed6c73ba1dc1ab308ba86925b296d"}],"tempest/api/network/test_networks.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"2c1927f5ce67290ba7b67c1b81e3921db8c5e4fb","unresolved":false,"context_lines":[{"line_number":276,"context_line":"    @test.idempotent_id(\u0027f04f61a9-b7f3-4194-90b2-9bcf660d1bfe\u0027)"},{"line_number":277,"context_line":"    def test_delete_network_with_subnet(self):"},{"line_number":278,"context_line":"        # Creates a network"},{"line_number":279,"context_line":"        network \u003d self.create_network()"},{"line_number":280,"context_line":"        net_id \u003d network[\u0027id\u0027]"},{"line_number":281,"context_line":"        self.addCleanup(test_utils.call_and_ignore_notfound_exc,"},{"line_number":282,"context_line":"                        self.networks_client.delete_network, net_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5da102_4b24495f","line":279,"range":{"start_line":279,"start_character":8,"end_line":279,"end_character":39},"updated":"2016-11-01 12:16:17.000000000","message":"This is something different change than stated in commit message.\n\nYou are changing call to networks_client function to base class function(which does all cleanup also).\n\nIf you want to change that then commit message should be corrected.","commit_id":"d6f612dc9daed6c73ba1dc1ab308ba86925b296d"},{"author":{"_account_id":23413,"name":"Tianbiao Qi","email":"qitianbiao@gmail.com","username":"trisq"},"change_message_id":"c67415053107da2c75fc552dc25fcf83f81e2cb1","unresolved":false,"context_lines":[{"line_number":276,"context_line":"    @test.idempotent_id(\u0027f04f61a9-b7f3-4194-90b2-9bcf660d1bfe\u0027)"},{"line_number":277,"context_line":"    def test_delete_network_with_subnet(self):"},{"line_number":278,"context_line":"        # Creates a network"},{"line_number":279,"context_line":"        network \u003d self.create_network()"},{"line_number":280,"context_line":"        net_id \u003d network[\u0027id\u0027]"},{"line_number":281,"context_line":"        self.addCleanup(test_utils.call_and_ignore_notfound_exc,"},{"line_number":282,"context_line":"                        self.networks_client.delete_network, net_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5da102_35059513","line":279,"range":{"start_line":279,"start_character":8,"end_line":279,"end_character":39},"in_reply_to":"ba5da102_4b24495f","updated":"2016-11-02 03:32:50.000000000","message":"Main purpose of calling base is to use random name function only. The commit message has been updated to more clear.","commit_id":"d6f612dc9daed6c73ba1dc1ab308ba86925b296d"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"2c1927f5ce67290ba7b67c1b81e3921db8c5e4fb","unresolved":false,"context_lines":[{"line_number":278,"context_line":"        # Creates a network"},{"line_number":279,"context_line":"        network \u003d self.create_network()"},{"line_number":280,"context_line":"        net_id \u003d network[\u0027id\u0027]"},{"line_number":281,"context_line":"        self.addCleanup(test_utils.call_and_ignore_notfound_exc,"},{"line_number":282,"context_line":"                        self.networks_client.delete_network, net_id)"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"        # Find a cidr that is not in use yet and create a subnet with it"},{"line_number":285,"context_line":"        subnet \u003d self.create_subnet(network)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5da102_6bb74df5","line":282,"range":{"start_line":281,"start_character":8,"end_line":282,"end_character":68},"updated":"2016-11-01 12:16:17.000000000","message":"if you are using the base class function then network is being cleaned up automatically during teardownClass or you want to clean that before that also i mean just after test?","commit_id":"d6f612dc9daed6c73ba1dc1ab308ba86925b296d"},{"author":{"_account_id":23413,"name":"Tianbiao Qi","email":"qitianbiao@gmail.com","username":"trisq"},"change_message_id":"c67415053107da2c75fc552dc25fcf83f81e2cb1","unresolved":false,"context_lines":[{"line_number":278,"context_line":"        # Creates a network"},{"line_number":279,"context_line":"        network \u003d self.create_network()"},{"line_number":280,"context_line":"        net_id \u003d network[\u0027id\u0027]"},{"line_number":281,"context_line":"        self.addCleanup(test_utils.call_and_ignore_notfound_exc,"},{"line_number":282,"context_line":"                        self.networks_client.delete_network, net_id)"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"        # Find a cidr that is not in use yet and create a subnet with it"},{"line_number":285,"context_line":"        subnet \u003d self.create_subnet(network)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5da102_50193778","line":282,"range":{"start_line":281,"start_character":8,"end_line":282,"end_character":68},"in_reply_to":"ba5da102_6bb74df5","updated":"2016-11-02 03:32:50.000000000","message":"Thanks for comments. I prefer not using teardownClass to clean up created resources. Please check the new commit: using _delete_network function instead.","commit_id":"d6f612dc9daed6c73ba1dc1ab308ba86925b296d"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"2c1927f5ce67290ba7b67c1b81e3921db8c5e4fb","unresolved":false,"context_lines":[{"line_number":286,"context_line":"        subnet_id \u003d subnet[\u0027id\u0027]"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"        # Delete network while the subnet still exists"},{"line_number":289,"context_line":"        self.networks_client.delete_network(net_id)"},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"        # Verify that the subnet got automatically deleted."},{"line_number":292,"context_line":"        self.assertRaises(lib_exc.NotFound, self.subnets_client.show_subnet,"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5da102_8bd02121","line":289,"range":{"start_line":289,"start_character":8,"end_line":289,"end_character":12},"updated":"2016-11-01 12:16:17.000000000","message":"unrelated changes but ok with this.","commit_id":"d6f612dc9daed6c73ba1dc1ab308ba86925b296d"},{"author":{"_account_id":23413,"name":"Tianbiao Qi","email":"qitianbiao@gmail.com","username":"trisq"},"change_message_id":"c67415053107da2c75fc552dc25fcf83f81e2cb1","unresolved":false,"context_lines":[{"line_number":286,"context_line":"        subnet_id \u003d subnet[\u0027id\u0027]"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"        # Delete network while the subnet still exists"},{"line_number":289,"context_line":"        self.networks_client.delete_network(net_id)"},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"        # Verify that the subnet got automatically deleted."},{"line_number":292,"context_line":"        self.assertRaises(lib_exc.NotFound, self.subnets_client.show_subnet,"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5da102_d02387a5","line":289,"range":{"start_line":289,"start_character":8,"end_line":289,"end_character":12},"in_reply_to":"ba5da102_8bd02121","updated":"2016-11-02 03:32:50.000000000","message":"if not, pep8 check failed.","commit_id":"d6f612dc9daed6c73ba1dc1ab308ba86925b296d"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"4f920faefa6b321052946e36ab39339e2881ab66","unresolved":false,"context_lines":[{"line_number":297,"context_line":"        # Since create_subnet adds the subnet to the delete list, and it is"},{"line_number":298,"context_line":"        # actually deleted here - this will create and issue, hence remove"},{"line_number":299,"context_line":"        # it from the list."},{"line_number":300,"context_line":"        self.subnets.pop()"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"    @test.idempotent_id(\u0027d2d596e2-8e76-47a9-ac51-d4648009f4d3\u0027)"},{"line_number":303,"context_line":"    def test_create_delete_subnet_without_gateway(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba5da102_a69dfd0b","side":"PARENT","line":300,"updated":"2016-11-02 06:21:58.000000000","message":"Why did you remove this code? I think this is still needed.","commit_id":"7615b04fe7ba067b6731516af33931935c741ae4"},{"author":{"_account_id":23413,"name":"Tianbiao Qi","email":"qitianbiao@gmail.com","username":"trisq"},"change_message_id":"6cf6d14cd7a268e262745110b0e807f294a7a6bf","unresolved":false,"context_lines":[{"line_number":297,"context_line":"        # Since create_subnet adds the subnet to the delete list, and it is"},{"line_number":298,"context_line":"        # actually deleted here - this will create and issue, hence remove"},{"line_number":299,"context_line":"        # it from the list."},{"line_number":300,"context_line":"        self.subnets.pop()"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"    @test.idempotent_id(\u0027d2d596e2-8e76-47a9-ac51-d4648009f4d3\u0027)"},{"line_number":303,"context_line":"    def test_create_delete_subnet_without_gateway(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba5da102_e40c4eee","side":"PARENT","line":300,"in_reply_to":"ba5da102_a69dfd0b","updated":"2016-11-02 06:51:11.000000000","message":"I use function self._delete_network() in addCleanup, it has two clean steps: both self.networks.remove(network) and self.subnets.remove(subnet), so self.subnets.pop() is redundant code.","commit_id":"7615b04fe7ba067b6731516af33931935c741ae4"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"0e4103c25001a143ad42c90fc8eac62c373ff111","unresolved":false,"context_lines":[{"line_number":297,"context_line":"        # Since create_subnet adds the subnet to the delete list, and it is"},{"line_number":298,"context_line":"        # actually deleted here - this will create and issue, hence remove"},{"line_number":299,"context_line":"        # it from the list."},{"line_number":300,"context_line":"        self.subnets.pop()"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"    @test.idempotent_id(\u0027d2d596e2-8e76-47a9-ac51-d4648009f4d3\u0027)"},{"line_number":303,"context_line":"    def test_create_delete_subnet_without_gateway(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba5da102_4655d3c3","side":"PARENT","line":300,"in_reply_to":"ba5da102_e40c4eee","updated":"2016-11-03 03:28:46.000000000","message":"oops, indeed. thanks :)","commit_id":"7615b04fe7ba067b6731516af33931935c741ae4"}]}