)]}'
{"tempest/api/network/test_routers.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"257350f2b45d0ac750f68616747fba10fde0fee3","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        self.assertEqual("},{"line_number":62,"context_line":"            create_body[\u0027router\u0027][\u0027external_gateway_info\u0027][\u0027network_id\u0027],"},{"line_number":63,"context_line":"            CONF.network.public_network_id)"},{"line_number":64,"context_line":"        self.assertEqual(create_body[\u0027router\u0027][\u0027admin_state_up\u0027], False)"},{"line_number":65,"context_line":"        # Show details of the created router"},{"line_number":66,"context_line":"        show_body \u003d self.routers_client.show_router("},{"line_number":67,"context_line":"            create_body[\u0027router\u0027][\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a77a97e_8676e803","side":"PARENT","line":64,"range":{"start_line":64,"start_character":8,"end_line":64,"end_character":72},"updated":"2016-11-20 04:52:22.000000000","message":"do not remove this check also. even we can pass admin_state_up\u003dFalse while creating router(even default value is same). that will be more readable.","commit_id":"725af03175d9953e3e7d76d4759785762fb64e5f"},{"author":{"_account_id":23413,"name":"Tianbiao Qi","email":"qitianbiao@gmail.com","username":"trisq"},"change_message_id":"05271ebf1b3205c81d2bdf1c8a249a683ace62a2","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        self.assertEqual("},{"line_number":62,"context_line":"            create_body[\u0027router\u0027][\u0027external_gateway_info\u0027][\u0027network_id\u0027],"},{"line_number":63,"context_line":"            CONF.network.public_network_id)"},{"line_number":64,"context_line":"        self.assertEqual(create_body[\u0027router\u0027][\u0027admin_state_up\u0027], False)"},{"line_number":65,"context_line":"        # Show details of the created router"},{"line_number":66,"context_line":"        show_body \u003d self.routers_client.show_router("},{"line_number":67,"context_line":"            create_body[\u0027router\u0027][\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a74a57a_437449fc","side":"PARENT","line":64,"range":{"start_line":64,"start_character":8,"end_line":64,"end_character":72},"in_reply_to":"7a77a97e_8676e803","updated":"2016-11-25 02:17:32.000000000","message":"Done","commit_id":"725af03175d9953e3e7d76d4759785762fb64e5f"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"257350f2b45d0ac750f68616747fba10fde0fee3","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        # Show details of the created router"},{"line_number":66,"context_line":"        show_body \u003d self.routers_client.show_router("},{"line_number":67,"context_line":"            create_body[\u0027router\u0027][\u0027id\u0027])"},{"line_number":68,"context_line":"        self.assertEqual(show_body[\u0027router\u0027][\u0027name\u0027], name)"},{"line_number":69,"context_line":"        self.assertEqual("},{"line_number":70,"context_line":"            show_body[\u0027router\u0027][\u0027external_gateway_info\u0027][\u0027network_id\u0027],"},{"line_number":71,"context_line":"            CONF.network.public_network_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a77a97e_66246c0c","side":"PARENT","line":68,"range":{"start_line":68,"start_character":8,"end_line":68,"end_character":59},"updated":"2016-11-20 04:52:22.000000000","message":"we should not remove this check.","commit_id":"725af03175d9953e3e7d76d4759785762fb64e5f"},{"author":{"_account_id":23413,"name":"Tianbiao Qi","email":"qitianbiao@gmail.com","username":"trisq"},"change_message_id":"05271ebf1b3205c81d2bdf1c8a249a683ace62a2","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        # Show details of the created router"},{"line_number":66,"context_line":"        show_body \u003d self.routers_client.show_router("},{"line_number":67,"context_line":"            create_body[\u0027router\u0027][\u0027id\u0027])"},{"line_number":68,"context_line":"        self.assertEqual(show_body[\u0027router\u0027][\u0027name\u0027], name)"},{"line_number":69,"context_line":"        self.assertEqual("},{"line_number":70,"context_line":"            show_body[\u0027router\u0027][\u0027external_gateway_info\u0027][\u0027network_id\u0027],"},{"line_number":71,"context_line":"            CONF.network.public_network_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a74a57a_63614539","side":"PARENT","line":68,"range":{"start_line":68,"start_character":8,"end_line":68,"end_character":59},"in_reply_to":"7a77a97e_66246c0c","updated":"2016-11-25 02:17:32.000000000","message":"Done","commit_id":"725af03175d9953e3e7d76d4759785762fb64e5f"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"257350f2b45d0ac750f68616747fba10fde0fee3","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        routers \u003d self.routers_client.list_routers()[\u0027routers\u0027]"},{"line_number":65,"context_line":"        self.assertIn(router[\u0027id\u0027], map(lambda x: x[\u0027id\u0027], routers))"},{"line_number":66,"context_line":"        # Update the name of router and verify if it is updated"},{"line_number":67,"context_line":"        updated_name \u003d \u0027New_Router\u0027"},{"line_number":68,"context_line":"        router_update \u003d self.routers_client.update_router("},{"line_number":69,"context_line":"            router[\u0027id\u0027], name\u003dupdated_name)[\u0027router\u0027]"},{"line_number":70,"context_line":"        self.assertEqual(router_update[\u0027name\u0027], updated_name)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a77a97e_e6179ca0","line":67,"range":{"start_line":67,"start_character":23,"end_line":67,"end_character":35},"updated":"2016-11-20 04:52:22.000000000","message":"we can do like- \u0027updated \u0027 + router[\u0027name\u0027]","commit_id":"3c6345017a06577ae20a690f8bcfb5e28294afc4"},{"author":{"_account_id":23413,"name":"Tianbiao Qi","email":"qitianbiao@gmail.com","username":"trisq"},"change_message_id":"05271ebf1b3205c81d2bdf1c8a249a683ace62a2","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        routers \u003d self.routers_client.list_routers()[\u0027routers\u0027]"},{"line_number":65,"context_line":"        self.assertIn(router[\u0027id\u0027], map(lambda x: x[\u0027id\u0027], routers))"},{"line_number":66,"context_line":"        # Update the name of router and verify if it is updated"},{"line_number":67,"context_line":"        updated_name \u003d \u0027New_Router\u0027"},{"line_number":68,"context_line":"        router_update \u003d self.routers_client.update_router("},{"line_number":69,"context_line":"            router[\u0027id\u0027], name\u003dupdated_name)[\u0027router\u0027]"},{"line_number":70,"context_line":"        self.assertEqual(router_update[\u0027name\u0027], updated_name)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a74a57a_8364a149","line":67,"range":{"start_line":67,"start_character":23,"end_line":67,"end_character":35},"in_reply_to":"7a77a97e_e6179ca0","updated":"2016-11-25 02:17:32.000000000","message":"Done","commit_id":"3c6345017a06577ae20a690f8bcfb5e28294afc4"}]}