)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"d084ddbbce2e9a0d68246653b7916d64f2f00fcd","unresolved":false,"context_lines":[{"line_number":15,"context_line":"  list, why should we require them to maintain the new"},{"line_number":16,"context_line":"  CONF.network_feature_enabled.port_security?"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"- what\u0027s \"default neutron, i.e. not devstack\"?  neutron itself"},{"line_number":19,"context_line":"  doesn\u0027t have a default even for core_plugin."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Closes-Bug: #1638487"},{"line_number":22,"context_line":"Change-Id: I8f209dff0b5ef6dcad5864ae36ae0245d612b740"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ba5da102_3a497d8f","line":19,"range":{"start_line":18,"start_character":0,"end_line":19,"end_character":46},"updated":"2016-11-04 23:49:10.000000000","message":"On devstack, I3035317c83d22804855517434bd8578719ce0436 introduced port_security as the default of ml2 driver like:\n\n Note that extension drivers for the ML2 plugin is set by\n `Q_ML2_PLUGIN_EXT_DRIVERS`, and it includes \u0027port_security\u0027 by default. If you\n want to remove all the extension drivers (even \u0027port_security\u0027), set\n `Q_ML2_PLUGIN_EXT_DRIVERS` to blank.\n\nI guess ml2 driver would be default, is that wrong?","commit_id":"1cfaaad2c50190eeb7d198be436babf593728b49"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"56a34a734c38195c44a35228899cd2272b8977a3","unresolved":false,"context_lines":[{"line_number":15,"context_line":"  list, why should we require them to maintain the new"},{"line_number":16,"context_line":"  CONF.network_feature_enabled.port_security?"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"- what\u0027s \"default neutron, i.e. not devstack\"?  neutron itself"},{"line_number":19,"context_line":"  doesn\u0027t have a default even for core_plugin."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Closes-Bug: #1638487"},{"line_number":22,"context_line":"Change-Id: I8f209dff0b5ef6dcad5864ae36ae0245d612b740"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ba5da102_ed257c0a","line":19,"range":{"start_line":18,"start_character":0,"end_line":19,"end_character":46},"in_reply_to":"ba5da102_3a497d8f","updated":"2016-11-07 06:17:31.000000000","message":"yes, it\u0027s devstack\u0027s default. but not neutron\u0027s.","commit_id":"1cfaaad2c50190eeb7d198be436babf593728b49"}],"tempest/scenario/manager.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"a503cceaef9b1429943ccf149999e1debaf11150","unresolved":false,"context_lines":[{"line_number":667,"context_line":"        if not tenant_id:"},{"line_number":668,"context_line":"            tenant_id \u003d networks_client.tenant_id"},{"line_number":669,"context_line":"        name \u003d data_utils.rand_name(namestart)"},{"line_number":670,"context_line":"        network_kwargs \u003d dict(name\u003dname, tenant_id\u003dtenant_id)"},{"line_number":671,"context_line":"        # Neutron disables port security by default so we have to check the"},{"line_number":672,"context_line":"        # config before trying to create the network with port_security_enabled"},{"line_number":673,"context_line":"        if CONF.network_feature_enabled.port_security:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a629dbe_0777023b","side":"PARENT","line":670,"updated":"2016-11-07 21:48:07.000000000","message":"this is all you need to revert, the rest is fine.","commit_id":"039b2fe1764e212133a652c62cb003a9f15c76b0"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"39d05d8095b65895ddc94fe7a05f6e5b8f506b37","unresolved":false,"context_lines":[{"line_number":667,"context_line":"        if not tenant_id:"},{"line_number":668,"context_line":"            tenant_id \u003d networks_client.tenant_id"},{"line_number":669,"context_line":"        name \u003d data_utils.rand_name(namestart)"},{"line_number":670,"context_line":"        network_kwargs \u003d dict(name\u003dname, tenant_id\u003dtenant_id)"},{"line_number":671,"context_line":"        # Neutron disables port security by default so we have to check the"},{"line_number":672,"context_line":"        # config before trying to create the network with port_security_enabled"},{"line_number":673,"context_line":"        if CONF.network_feature_enabled.port_security:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a629dbe_d20301b7","side":"PARENT","line":670,"in_reply_to":"9a629dbe_0777023b","updated":"2016-11-08 02:45:59.000000000","message":"it\u0027s what my original patch [1] did, but Ken\u0027ichi was not happy with it.\n\n[1] https://review.openstack.org/#/c/392464/","commit_id":"039b2fe1764e212133a652c62cb003a9f15c76b0"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"d87ac3c20782e82eeba2b7cd2c8c28c44275a564","unresolved":false,"context_lines":[{"line_number":667,"context_line":"        if not tenant_id:"},{"line_number":668,"context_line":"            tenant_id \u003d networks_client.tenant_id"},{"line_number":669,"context_line":"        name \u003d data_utils.rand_name(namestart)"},{"line_number":670,"context_line":"        network_kwargs \u003d dict(name\u003dname, tenant_id\u003dtenant_id)"},{"line_number":671,"context_line":"        # Neutron disables port security by default so we have to check the"},{"line_number":672,"context_line":"        # config before trying to create the network with port_security_enabled"},{"line_number":673,"context_line":"        if CONF.network_feature_enabled.port_security:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a629dbe_8b87940e","side":"PARENT","line":670,"in_reply_to":"9a629dbe_50944936","updated":"2016-11-08 05:12:39.000000000","message":"sure.  i flipped my \"preference\" by changing workflow of these changes.","commit_id":"039b2fe1764e212133a652c62cb003a9f15c76b0"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"1b22e98df0c75d4c91bde020d0249bff7071394f","unresolved":false,"context_lines":[{"line_number":667,"context_line":"        if not tenant_id:"},{"line_number":668,"context_line":"            tenant_id \u003d networks_client.tenant_id"},{"line_number":669,"context_line":"        name \u003d data_utils.rand_name(namestart)"},{"line_number":670,"context_line":"        network_kwargs \u003d dict(name\u003dname, tenant_id\u003dtenant_id)"},{"line_number":671,"context_line":"        # Neutron disables port security by default so we have to check the"},{"line_number":672,"context_line":"        # config before trying to create the network with port_security_enabled"},{"line_number":673,"context_line":"        if CONF.network_feature_enabled.port_security:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a629dbe_50944936","side":"PARENT","line":670,"in_reply_to":"9a629dbe_d20301b7","updated":"2016-11-08 04:24:39.000000000","message":"He may have not been happy with it, but that doesn\u0027t change the fact that one can\u0027t specify an attribute in the body that a neutron server cannot understand (when the extension is disabled).","commit_id":"039b2fe1764e212133a652c62cb003a9f15c76b0"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"a503cceaef9b1429943ccf149999e1debaf11150","unresolved":false,"context_lines":[{"line_number":668,"context_line":"            tenant_id \u003d networks_client.tenant_id"},{"line_number":669,"context_line":"        name \u003d data_utils.rand_name(namestart)"},{"line_number":670,"context_line":"        network_kwargs \u003d dict(name\u003dname, tenant_id\u003dtenant_id,"},{"line_number":671,"context_line":"                              port_security_enabled\u003dport_security_enabled)"},{"line_number":672,"context_line":"        result \u003d networks_client.create_network(**network_kwargs)"},{"line_number":673,"context_line":"        network \u003d result[\u0027network\u0027]"},{"line_number":674,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a629dbe_e7a04e93","line":671,"updated":"2016-11-07 21:48:07.000000000","message":"for deployments where port security is disabled, we cannot pass this attribute in the request otherwise we will get the error that Yamamoto is reporting.","commit_id":"1cfaaad2c50190eeb7d198be436babf593728b49"}]}