)]}'
{"tempest/api/image/v1/test_images_negative.py":[{"author":{"_account_id":7020,"name":"Joe Hakim Rahme","email":"jhakimra@redhat.com","username":"rahmu"},"change_message_id":"0a81fcdeb233862cde043392b6f257a65dd193a7","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from tempest import test"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from tempest.api.image import base"},{"line_number":19,"context_line":"from tempest.lib import exceptions as lib_exc"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a77a97e_8dcd0760","line":16,"updated":"2016-11-21 14:12:07.000000000","message":"Why move the import statement?","commit_id":"015d31f25c036c008f9932cd8af082da779714b0"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"4812674cad13e141501f87db6cd1e4854bed223d","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from tempest import test"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from tempest.api.image import base"},{"line_number":19,"context_line":"from tempest.lib import exceptions as lib_exc"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a77a97e_0df2d76f","line":16,"in_reply_to":"7a77a97e_8dcd0760","updated":"2016-11-21 14:15:12.000000000","message":"Not a good reason from my side , my flake8 reports mis-order ...","commit_id":"015d31f25c036c008f9932cd8af082da779714b0"}],"tempest/api/image/v2/test_images_negative.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"792aa237d3c07f544e9c44e1e1dd6ff3fde358a6","unresolved":false,"context_lines":[{"line_number":15,"context_line":"#    under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from tempest import test"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from tempest.api.image import base"},{"line_number":20,"context_line":"from tempest.lib import exceptions as lib_exc"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from tempest.lib.common.utils import data_utils"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class ImagesNegativeTest(base.BaseV2ImageTest):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a77a97e_fa47fa48","line":22,"range":{"start_line":18,"start_character":0,"end_line":22,"end_character":47},"updated":"2016-11-22 00:30:07.000000000","message":"We should not change \"import\" code here at all..\n\nThese modules are the same group which is local, and they should be import in a single block.","commit_id":"015d31f25c036c008f9932cd8af082da779714b0"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"792aa237d3c07f544e9c44e1e1dd6ff3fde358a6","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        self.client.delete_image(image[\u0027id\u0027])"},{"line_number":95,"context_line":"        self.client.wait_for_resource_deletion(image[\u0027id\u0027])"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        # create an image with deleted image-id"},{"line_number":98,"context_line":"        self.assertRaises(lib_exc.Conflict, self.client.create_image,"},{"line_number":99,"context_line":"                          name\u003d\u0027test\u0027, id\u003dimage[\u0027id\u0027])"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    @test.attr(type\u003d[\u0027negative\u0027])"},{"line_number":102,"context_line":"    @test.idempotent_id(\u0027292bd310-369b-41c7-a7a3-10276ef76753\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a77a97e_baf582cc","line":99,"range":{"start_line":97,"start_character":0,"end_line":99,"end_character":54},"updated":"2016-11-22 00:30:07.000000000","message":"We have negative test guideline like https://github.com/openstack/tempest/blob/master/HACKING.rst#negative-tests\n\nThis API behavior is interesting for me, but the API-WG guideline doesn\u0027t cover this case according to https://github.com/openstack/tempest/blob/master/HACKING.rst#negative-tests\n\nand I am not sure this behavior is ideal or not on whole OpenStack services. So it would be nice to discuss it on API-WG as the above negative test guideline said.","commit_id":"015d31f25c036c008f9932cd8af082da779714b0"}]}
