)]}'
{"tempest/api/volume/admin/test_volume_types.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"372a9de1d71702ee818279558f59f9a332c6b90a","unresolved":false,"context_lines":[{"line_number":51,"context_line":"                  \u0027size\u0027: CONF.volume.volume_size}"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        # Create volume"},{"line_number":54,"context_line":"        volume \u003d self.create_volume(**params)"},{"line_number":55,"context_line":"        self.assertEqual(volume_types[0][\u0027name\u0027], volume[\"volume_type\"])"},{"line_number":56,"context_line":"        self.assertEqual(volume[self.name_field], vol_name,"},{"line_number":57,"context_line":"                         \"The created volume name is not equal \""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a629dbe_d61c8715","line":54,"range":{"start_line":54,"start_character":8,"end_line":54,"end_character":45},"updated":"2016-11-09 13:02:47.000000000","message":"remember this going to delay deletion part till end of teardownClass not just after tests case.\n\nIt will be nice if you can mention the actual benefit of doing this ?","commit_id":"e26de586f9ef13a3541392409d79ee0af3dbc2b3"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"372a9de1d71702ee818279558f59f9a332c6b90a","unresolved":false,"context_lines":[{"line_number":51,"context_line":"                  \u0027size\u0027: CONF.volume.volume_size}"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        # Create volume"},{"line_number":54,"context_line":"        volume \u003d self.create_volume(**params)"},{"line_number":55,"context_line":"        self.assertEqual(volume_types[0][\u0027name\u0027], volume[\"volume_type\"])"},{"line_number":56,"context_line":"        self.assertEqual(volume[self.name_field], vol_name,"},{"line_number":57,"context_line":"                         \"The created volume name is not equal \""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a629dbe_f6f26bd1","line":54,"range":{"start_line":54,"start_character":8,"end_line":54,"end_character":45},"updated":"2016-11-09 13:02:47.000000000","message":"remember this going to delay deletion part till end of teardownClass not just after tests case.\n\nIt will be nice if you can mention the actual benefit of doing this ?","commit_id":"e26de586f9ef13a3541392409d79ee0af3dbc2b3"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"4acfb003fad7a4acc0d67c3281dbad05ef8bb11e","unresolved":false,"context_lines":[{"line_number":51,"context_line":"                  \u0027size\u0027: CONF.volume.volume_size}"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        # Create volume"},{"line_number":54,"context_line":"        volume \u003d self.create_volume(**params)"},{"line_number":55,"context_line":"        self.assertEqual(volume_types[0][\u0027name\u0027], volume[\"volume_type\"])"},{"line_number":56,"context_line":"        self.assertEqual(volume[self.name_field], vol_name,"},{"line_number":57,"context_line":"                         \"The created volume name is not equal \""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a629dbe_2739bdd7","line":54,"range":{"start_line":54,"start_character":8,"end_line":54,"end_character":45},"in_reply_to":"9a629dbe_16aa7f70","updated":"2016-11-11 02:33:23.000000000","message":"Yea that is fine but sometime we need to cleanup the resources just after tests where other resources are attached. Like- volume here was link with volume type and here we might need to delete the volume immediately.\n\nCurrently it is handled fine in base class but in case order of cleanup is changed then it will be issue.","commit_id":"e26de586f9ef13a3541392409d79ee0af3dbc2b3"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"d5890d1d56af1d9c889b3da8fe56062b3ae02945","unresolved":false,"context_lines":[{"line_number":51,"context_line":"                  \u0027size\u0027: CONF.volume.volume_size}"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        # Create volume"},{"line_number":54,"context_line":"        volume \u003d self.create_volume(**params)"},{"line_number":55,"context_line":"        self.assertEqual(volume_types[0][\u0027name\u0027], volume[\"volume_type\"])"},{"line_number":56,"context_line":"        self.assertEqual(volume[self.name_field], vol_name,"},{"line_number":57,"context_line":"                         \"The created volume name is not equal \""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a629dbe_16aa7f70","line":54,"range":{"start_line":54,"start_character":8,"end_line":54,"end_character":45},"in_reply_to":"9a629dbe_d61c8715","updated":"2016-11-09 13:07:33.000000000","message":"Hi , Thanks for your review .\nThe main idea is to handle the create_volume actions in a single location . for any future change or maintance we will be able to do it for all create actions.","commit_id":"e26de586f9ef13a3541392409d79ee0af3dbc2b3"}],"tempest/api/volume/admin/v2/test_volume_type_access.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"5525ebf463cfb67e3eb1dc8c5626374fc4b7acf4","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        # Creating a volume from primary tenant"},{"line_number":54,"context_line":"        volume \u003d self.create_volume(volume_type\u003dvolume_type[\u0027id\u0027],"},{"line_number":55,"context_line":"                                    size\u003dCONF.volume.volume_size)"},{"line_number":56,"context_line":"        # Validating the created volume is based on the volume type"},{"line_number":57,"context_line":"        self.assertEqual(volume_type[\u0027name\u0027], volume[\u0027volume_type\u0027])"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"9a629dbe_17e1f5d0","line":55,"updated":"2016-11-14 14:13:36.000000000","message":"We shouldn\"t have to set size\u003dCONF.volume.volume_size given that it\u0027s the default value anyway.","commit_id":"0ca2c09de73faf66c29fe3a6381a9b130e34d5fc"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"41f2d42e64f779889823e16f318d17d020c4ce7d","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        # Creating a volume from primary tenant"},{"line_number":54,"context_line":"        volume \u003d self.create_volume(volume_type\u003dvolume_type[\u0027id\u0027],"},{"line_number":55,"context_line":"                                    size\u003dCONF.volume.volume_size)"},{"line_number":56,"context_line":"        # Validating the created volume is based on the volume type"},{"line_number":57,"context_line":"        self.assertEqual(volume_type[\u0027name\u0027], volume[\u0027volume_type\u0027])"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"9a629dbe_56036e0d","line":55,"in_reply_to":"9a629dbe_17e1f5d0","updated":"2016-11-14 14:35:32.000000000","message":"fixed\nBenny","commit_id":"0ca2c09de73faf66c29fe3a6381a9b130e34d5fc"}],"tempest/api/volume/admin/v3/test_user_messages.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"372a9de1d71702ee818279558f59f9a332c6b90a","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        except exceptions.VolumeBuildErrorException:"},{"line_number":62,"context_line":"            # Error state is expected and desired"},{"line_number":63,"context_line":"            pass"},{"line_number":64,"context_line":"        messages \u003d self.messages_client.list_messages()"},{"line_number":65,"context_line":"        message_id \u003d None"},{"line_number":66,"context_line":"        for message in messages:"},{"line_number":67,"context_line":"            if message[\u0027resource_uuid\u0027] \u003d\u003d volume[\u0027id\u0027]:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a629dbe_16eeffeb","line":64,"range":{"start_line":64,"start_character":39,"end_line":64,"end_character":55},"updated":"2016-11-09 13:02:47.000000000","message":"why this change.","commit_id":"e26de586f9ef13a3541392409d79ee0af3dbc2b3"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"372a9de1d71702ee818279558f59f9a332c6b90a","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        except exceptions.VolumeBuildErrorException:"},{"line_number":62,"context_line":"            # Error state is expected and desired"},{"line_number":63,"context_line":"            pass"},{"line_number":64,"context_line":"        messages \u003d self.messages_client.list_messages()"},{"line_number":65,"context_line":"        message_id \u003d None"},{"line_number":66,"context_line":"        for message in messages:"},{"line_number":67,"context_line":"            if message[\u0027resource_uuid\u0027] \u003d\u003d volume[\u0027id\u0027]:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a629dbe_36d4e31e","line":64,"range":{"start_line":64,"start_character":39,"end_line":64,"end_character":55},"updated":"2016-11-09 13:02:47.000000000","message":"why this change.","commit_id":"e26de586f9ef13a3541392409d79ee0af3dbc2b3"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"d5890d1d56af1d9c889b3da8fe56062b3ae02945","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        except exceptions.VolumeBuildErrorException:"},{"line_number":62,"context_line":"            # Error state is expected and desired"},{"line_number":63,"context_line":"            pass"},{"line_number":64,"context_line":"        messages \u003d self.messages_client.list_messages()"},{"line_number":65,"context_line":"        message_id \u003d None"},{"line_number":66,"context_line":"        for message in messages:"},{"line_number":67,"context_line":"            if message[\u0027resource_uuid\u0027] \u003d\u003d volume[\u0027id\u0027]:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a629dbe_b6d2b3fe","line":64,"range":{"start_line":64,"start_character":39,"end_line":64,"end_character":55},"in_reply_to":"9a629dbe_16eeffeb","updated":"2016-11-09 13:07:33.000000000","message":"Hi , A mistake from my side .\nFixing","commit_id":"e26de586f9ef13a3541392409d79ee0af3dbc2b3"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e3f3814a095aa4fde39a27d070ad3e685774f359","unresolved":false,"context_lines":[{"line_number":47,"context_line":"                       \u0027vendor_name\u0027: bad_vendor}"},{"line_number":48,"context_line":"        vol_type_name \u003d data_utils.rand_name("},{"line_number":49,"context_line":"            self.__class__.__name__ + \u0027-volume-type\u0027)"},{"line_number":50,"context_line":"        bogus_type \u003d self.admin_volume_types_client.create_volume_type("},{"line_number":51,"context_line":"            name\u003dvol_type_name,"},{"line_number":52,"context_line":"            extra_specs\u003dextra_specs)[\u0027volume_type\u0027]"},{"line_number":53,"context_line":"        self.addCleanup(self.admin_volume_types_client.delete_volume_type,"},{"line_number":54,"context_line":"                        bogus_type[\u0027id\u0027])"},{"line_number":55,"context_line":"        params \u003d {\u0027volume_type\u0027: bogus_type[\u0027id\u0027],"},{"line_number":56,"context_line":"                  \u0027size\u0027: CONF.volume.volume_size}"},{"line_number":57,"context_line":"        volume \u003d self.create_volume(**params)[\u0027volume\u0027]"},{"line_number":58,"context_line":"        self.addCleanup(self.delete_volume, self.volumes_client, volume[\u0027id\u0027])"},{"line_number":59,"context_line":"        try:"},{"line_number":60,"context_line":"            waiters.wait_for_volume_status(self.volumes_client, volume[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a629dbe_2767fde9","line":57,"range":{"start_line":50,"start_character":0,"end_line":57,"end_character":55},"updated":"2016-11-11 02:33:30.000000000","message":"This is perfect example what I meant in previous comment on PS2. \nHere we are deleting the volume type immediately after tests but leave its linked volume till teardownClass which will not work and fail the tests.\nFailure is due to this only.","commit_id":"16382891923f6e8cb46bbafee788c4ec44a31be8"}]}