)]}'
{"tempest/api/compute/volumes/test_volume_snapshots.py":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"fbe64b322f74dc7c67cd66abc3f0f5a746cb029b","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    @test.idempotent_id(\u0027cd4ec87d-7825-450d-8040-6e2068f2da8f\u0027)"},{"line_number":44,"context_line":"    @testtools.skipUnless(CONF.volume_feature_enabled.snapshot,"},{"line_number":45,"context_line":"                          \u0027Cinder volume snapshots are disabled\u0027)"},{"line_number":46,"context_line":"    def test_volume_snapshot_create_get_list_delete(self):"},{"line_number":47,"context_line":"        volume \u003d self.create_volume()"},{"line_number":48,"context_line":"        self.addCleanup(self.delete_volume, volume[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a629dbe_aad712ec","line":45,"updated":"2016-11-14 08:05:28.000000000","message":"Can we move this to skip_checks()? I think we can skip all of this file\u0027s tests. Currently, there\u0027s only one test, though..","commit_id":"758de6a99920034a7a92c2117fc2423d4af6f8d1"}],"tempest/api/volume/test_volumes_backup.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9b97a08e8f7514b4d768073aa18321d60f1652f6","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    @classmethod"},{"line_number":30,"context_line":"    def skip_checks(cls):"},{"line_number":31,"context_line":"        super(VolumesBackupsV2Test, cls).skip_checks()"},{"line_number":32,"context_line":"        if not CONF.volume_feature_enabled.backup:"},{"line_number":33,"context_line":"            raise cls.skipException(\"Cinder backup feature disabled\")"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    @test.idempotent_id(\u0027a66eb488-8ee1-47d4-8e9f-575a095728c6\u0027)"},{"line_number":36,"context_line":"    def test_volume_backup_create_get_detailed_list_restore_delete(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a629dbe_e08138c5","line":33,"range":{"start_line":32,"start_character":8,"end_line":33,"end_character":69},"updated":"2016-11-13 14:34:42.000000000","message":"I\u0027m actually really confused why the test is running at all if this is set - oh I see why:\n\nhttps://review.openstack.org/#/c/395887/3/devstack/plugin.sh\n\nDoesn\u0027t set backup\u003dFalse. I\u0027m not sure if snapshot and/or clone are required for volume backup, would need to ask Cinder devs, but if that\u0027s the case we just need to set volume-feature-enabled.backup\u003dFalse in that devstack-plugin-nfs change.","commit_id":"abcd9dd2c52af60c4e94364573d576f04ef70efd"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ecc84cf79f54bf691f99b0b41e78a1ecede79b50","unresolved":false,"context_lines":[{"line_number":75,"context_line":"                                       restore[\u0027volume_id\u0027], \u0027available\u0027)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    @test.idempotent_id(\u002707af8f6d-80af-44c9-a5dc-c8427b1b62e6\u0027)"},{"line_number":78,"context_line":"    @testtools.skipUnless(CONF.volume_feature_enabled.clone,"},{"line_number":79,"context_line":"                          \u0027Cinder volume clones are disabled\u0027)"},{"line_number":80,"context_line":"    @test.services(\u0027compute\u0027)"},{"line_number":81,"context_line":"    def test_backup_create_attached_volume(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a629dbe_830b66d5","line":78,"range":{"start_line":78,"start_character":54,"end_line":78,"end_character":59},"updated":"2016-11-10 20:37:01.000000000","message":"I think this should be the backup option.","commit_id":"abcd9dd2c52af60c4e94364573d576f04ef70efd"},{"author":{"_account_id":16907,"name":"Diana Clarke","email":"diana.joan.clarke@gmail.com","username":"diana-clarke"},"change_message_id":"52d4bc1c59d42336a5087f39eaeba4689b07cf6d","unresolved":false,"context_lines":[{"line_number":75,"context_line":"                                       restore[\u0027volume_id\u0027], \u0027available\u0027)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    @test.idempotent_id(\u002707af8f6d-80af-44c9-a5dc-c8427b1b62e6\u0027)"},{"line_number":78,"context_line":"    @testtools.skipUnless(CONF.volume_feature_enabled.clone,"},{"line_number":79,"context_line":"                          \u0027Cinder volume clones are disabled\u0027)"},{"line_number":80,"context_line":"    @test.services(\u0027compute\u0027)"},{"line_number":81,"context_line":"    def test_backup_create_attached_volume(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a629dbe_e99961c5","line":78,"range":{"start_line":78,"start_character":54,"end_line":78,"end_character":59},"in_reply_to":"9a629dbe_830b66d5","updated":"2016-11-10 21:30:25.000000000","message":"CONF.volume_feature_enabled.backup is already checked at the class level.\n\nI added the clone skip based on this error log:\n\n- http://logs.openstack.org/87/395887/2/check/gate-tempest-dsvm-full-devstack-plugin-nfs-nv/81d721a/logs/screen-c-vol.txt.gz?level\u003dERROR#_2016-11-10_03_02_44_317\n\nIIUC, backup does a clone under the hood in certain cases:\n\n- https://github.com/openstack/cinder/blob/41b516234f2849b3966487c3014e2b0552b5c083/cinder/volume/driver.py#L1148\n\nI\u0027m not confident that was the right approach, but that was my reasoning.","commit_id":"abcd9dd2c52af60c4e94364573d576f04ef70efd"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9b97a08e8f7514b4d768073aa18321d60f1652f6","unresolved":false,"context_lines":[{"line_number":75,"context_line":"                                       restore[\u0027volume_id\u0027], \u0027available\u0027)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    @test.idempotent_id(\u002707af8f6d-80af-44c9-a5dc-c8427b1b62e6\u0027)"},{"line_number":78,"context_line":"    @testtools.skipUnless(CONF.volume_feature_enabled.clone,"},{"line_number":79,"context_line":"                          \u0027Cinder volume clones are disabled\u0027)"},{"line_number":80,"context_line":"    @test.services(\u0027compute\u0027)"},{"line_number":81,"context_line":"    def test_backup_create_attached_volume(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a629dbe_601fe8b7","line":78,"range":{"start_line":78,"start_character":54,"end_line":78,"end_character":59},"in_reply_to":"9a629dbe_e99961c5","updated":"2016-11-13 14:34:42.000000000","message":"OK, weird, it can be a snapshot or clone I guess. Either way, this test calls self.backups_client.create_backup so we should just block on that backup config option.","commit_id":"abcd9dd2c52af60c4e94364573d576f04ef70efd"}],"tempest/api/volume/test_volumes_get.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ecc84cf79f54bf691f99b0b41e78a1ecede79b50","unresolved":false,"context_lines":[{"line_number":155,"context_line":"    @testtools.skipUnless(CONF.volume_feature_enabled.clone,"},{"line_number":156,"context_line":"                          \u0027Cinder volume clones are disabled\u0027)"},{"line_number":157,"context_line":"    @test.services(\u0027image\u0027)"},{"line_number":158,"context_line":"    def test_volume_create_get_update_delete_from_image(self):"},{"line_number":159,"context_line":"        super(VolumesV1GetTest,"},{"line_number":160,"context_line":"              self).test_volume_create_get_update_delete_from_image()"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a629dbe_23037ab9","line":158,"updated":"2016-11-10 20:37:01.000000000","message":"This seems odd - what about that test does a volume clone? The test_volume_create_get_update_delete_as_clone test obviously does a clone, given the name at least, but it already has this decorator.","commit_id":"abcd9dd2c52af60c4e94364573d576f04ef70efd"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"fa3bda0d1fdad07680695605111db29df726c23a","unresolved":false,"context_lines":[{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":131,"context_line":"    @test.idempotent_id(\u002754a01030-c7fc-447c-86ee-c1182beae638\u0027)"},{"line_number":132,"context_line":"    @testtools.skipUnless(CONF.volume_feature_enabled.clone,"},{"line_number":133,"context_line":"                          \u0027Cinder volume clones are disabled\u0027)"},{"line_number":134,"context_line":"    @test.services(\u0027image\u0027)"},{"line_number":135,"context_line":"    def test_volume_create_get_update_delete_from_image(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a629dbe_8bc09d2c","line":132,"updated":"2016-11-16 20:19:15.000000000","message":"Ack:\n\nhttp://logs.openstack.org/87/395887/4/check/gate-tempest-dsvm-full-devstack-plugin-nfs-nv/817e301/logs/screen-c-vol.txt.gz#_2016-11-13_15_29_41_391\n\nI\u0027m not really sure what about this test is trying to do a clone. This is also a defcore test:\n\nhttp://git.openstack.org/cgit/openstack/defcore/tree/2016.08.json#n2629\n\nBut I guess defcore also lists clone as a required supported operation:\n\nhttp://git.openstack.org/cgit/openstack/defcore/tree/2016.08.json#n2653","commit_id":"758de6a99920034a7a92c2117fc2423d4af6f8d1"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"fbe64b322f74dc7c67cd66abc3f0f5a746cb029b","unresolved":false,"context_lines":[{"line_number":130,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":131,"context_line":"    @test.idempotent_id(\u002754a01030-c7fc-447c-86ee-c1182beae638\u0027)"},{"line_number":132,"context_line":"    @testtools.skipUnless(CONF.volume_feature_enabled.clone,"},{"line_number":133,"context_line":"                          \u0027Cinder volume clones are disabled\u0027)"},{"line_number":134,"context_line":"    @test.services(\u0027image\u0027)"},{"line_number":135,"context_line":"    def test_volume_create_get_update_delete_from_image(self):"},{"line_number":136,"context_line":"        image \u003d self.compute_images_client.show_image("}],"source_content_type":"text/x-python","patch_set":3,"id":"9a629dbe_ca028672","line":133,"updated":"2016-11-14 08:05:28.000000000","message":"Is this a really using clone feature test?","commit_id":"758de6a99920034a7a92c2117fc2423d4af6f8d1"}],"tempest/api/volume/v2/test_image_metadata.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ecc84cf79f54bf691f99b0b41e78a1ecede79b50","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        cls.volume \u003d cls.create_volume(imageRef\u003dCONF.compute.image_ref)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    @test.idempotent_id(\u002703efff0b-5c75-4822-8f10-8789ac15b13e\u0027)"},{"line_number":35,"context_line":"    @testtools.skipUnless(CONF.volume_feature_enabled.clone,"},{"line_number":36,"context_line":"                          \u0027Cinder volume clones are disabled\u0027)"},{"line_number":37,"context_line":"    @test.services(\u0027image\u0027)"},{"line_number":38,"context_line":"    def test_update_image_metadata(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a629dbe_4315cee2","line":35,"updated":"2016-11-10 20:37:01.000000000","message":"It\u0027s not apparent to me what is using clone in this test flow...I\u0027d have to dig into the actual test failures.","commit_id":"abcd9dd2c52af60c4e94364573d576f04ef70efd"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"fbe64b322f74dc7c67cd66abc3f0f5a746cb029b","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    def skip_checks(cls):"},{"line_number":29,"context_line":"        super(VolumesV2ImageMetadata, cls).skip_checks()"},{"line_number":30,"context_line":"        if not CONF.volume_feature_enabled.clone:"},{"line_number":31,"context_line":"            raise cls.skipException(\u0027Cinder volume clones are disabled\u0027)"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    @classmethod"},{"line_number":34,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a629dbe_8ada4e16","line":31,"updated":"2016-11-14 08:05:28.000000000","message":"I\u0027m not sure the clone feature is needed with this test. Could you add a link for details?","commit_id":"758de6a99920034a7a92c2117fc2423d4af6f8d1"}],"tempest/scenario/test_shelve_instance.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ecc84cf79f54bf691f99b0b41e78a1ecede79b50","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        self._create_server_then_shelve_and_unshelve()"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    @test.idempotent_id(\u0027c1b6318c-b9da-490b-9c67-9339b627271f\u0027)"},{"line_number":84,"context_line":"    @testtools.skipUnless(CONF.volume_feature_enabled.clone,"},{"line_number":85,"context_line":"                          \u0027Cinder volume clones are disabled\u0027)"},{"line_number":86,"context_line":"    @test.services(\u0027compute\u0027, \u0027volume\u0027, \u0027network\u0027, \u0027image\u0027)"},{"line_number":87,"context_line":"    def test_shelve_volume_backed_instance(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a629dbe_23c8da73","line":84,"range":{"start_line":84,"start_character":54,"end_line":84,"end_character":59},"updated":"2016-11-10 20:37:01.000000000","message":"This should be snapshot. Shelving an instance requires taking a snapshot of it, and with a volume-backed snapshot it takes a snapshot of the volumes as well.","commit_id":"abcd9dd2c52af60c4e94364573d576f04ef70efd"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"5513d87f5818d58c49b2e34d117652d19ac59c52","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    @test.idempotent_id(\u0027c1b6318c-b9da-490b-9c67-9339b627271f\u0027)"},{"line_number":84,"context_line":"    @testtools.skipUnless(CONF.volume_feature_enabled.clone,"},{"line_number":85,"context_line":"                          \u0027Cinder volume clones are disabled\u0027)"},{"line_number":86,"context_line":"    @test.services(\u0027compute\u0027, \u0027volume\u0027, \u0027network\u0027, \u0027image\u0027)"},{"line_number":87,"context_line":"    def test_shelve_volume_backed_instance(self):"},{"line_number":88,"context_line":"        self._create_server_then_shelve_and_unshelve(boot_from_volume\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a77a97e_e5d9ce84","line":85,"updated":"2016-11-16 21:04:24.000000000","message":"Yeah from what I can tell this is the failure in the nfs job with this test:\n\nhttp://logs.openstack.org/87/395887/4/check/gate-tempest-dsvm-full-devstack-plugin-nfs-nv/817e301/logs/screen-c-vol.txt.gz?level\u003dTRACE#_2016-11-13_15_37_44_791\n\nThis is the request ID for the volume create POST:\n\nreq-1614c0df-7216-4683-bf79-2180582b54cb\n\n--\n\n\u003clater\u003e\n\nAfter talking with the cinder people, they pointed out that devstack is now running with the cinder image cache enabled in cinder and that uses volume cloning, which the NFS driver doesn\u0027t support so it blows up and it\u0027s not handled in cinder.\n\nhttps://bugs.launchpad.net/cinder/+bug/1642394","commit_id":"758de6a99920034a7a92c2117fc2423d4af6f8d1"}]}