)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"b22ff31104438eb8be9942831b430eb64e2ba148","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Anju Tiwari \u003canjutiwari5@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-08-01 16:17:05 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"A volume upload test added for xml"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Here a tests added for \"uploading"},{"line_number":10,"context_line":"a volume in glance\" in xml.It is"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAQn%2F%2FXJI%3D","line":7,"updated":"2013-08-01 13:13:03.000000000","message":"we\u0027re not adding a new test, we\u0027re adding into the volume xml service class the needed methods for the volume actions test to run; I\u0027d think about a different summary and also for a better description (the long paragraph)","commit_id":"72c63e93f715f3e3f733cc97426585ac46dcd30e"}],"tempest/api/volume/test_volumes_actions.py":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"b22ff31104438eb8be9942831b430eb64e2ba148","unresolved":false,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"class VolumesActionsTestXML(VolumesActionsTest):"},{"line_number":113,"context_line":"    _interface \u003d \"xml\""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAQn%2F%2FXJU%3D","line":113,"updated":"2013-08-01 13:13:03.000000000","message":"to make this pass the gate, you\u0027ll need to implement also the following two:\n\n    def attach_volume(self, volume_id, instance_uuid, mountpoint):\n    def detach_volume(self, volume_id):\n\nin the xml service class","commit_id":"72c63e93f715f3e3f733cc97426585ac46dcd30e"}],"tempest/services/volume/xml/volumes_client.py":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"b22ff31104438eb8be9942831b430eb64e2ba148","unresolved":false,"context_lines":[{"line_number":136,"context_line":"        post_body \u003d Element(\"volume\","},{"line_number":137,"context_line":"                            image_name\u003dimage_name,"},{"line_number":138,"context_line":"                           )"},{"line_number":139,"context_line":"        resp, body \u003d self.post(\u0027os-volume_upload_image\u0027,"},{"line_number":140,"context_line":"                               str(Document(post_body)),"},{"line_number":141,"context_line":"                               self.headers)"},{"line_number":142,"context_line":"        url \u003d \u0027volumes/%s/action\u0027 % (volume_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAQn%2F%2FW8U%3D","line":139,"updated":"2013-08-01 13:13:03.000000000","message":"this is wrong, you need to create an os-volume_upload_image element and append to it the volume Element created before\n\nmaybe you can try with:\n\npost_body \u003d Element(\u0027os-volume_upload_image\u0027).append(post_body)","commit_id":"72c63e93f715f3e3f733cc97426585ac46dcd30e"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"b22ff31104438eb8be9942831b430eb64e2ba148","unresolved":false,"context_lines":[{"line_number":141,"context_line":"                               self.headers)"},{"line_number":142,"context_line":"        url \u003d \u0027volumes/%s/action\u0027 % (volume_id)"},{"line_number":143,"context_line":"        resp, body \u003d self.post(url, str(Document(post_body)), self.headers)"},{"line_number":144,"context_line":"        volume \u003d self.xml_to_json(etree.fromstring(body))"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"        return resp, volume"},{"line_number":147,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAQn%2F%2FW8M%3D","line":144,"updated":"2013-08-01 13:13:03.000000000","message":"use xml_to_json rather than self.xml_to_json","commit_id":"72c63e93f715f3e3f733cc97426585ac46dcd30e"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"bf0f8a6f88c18852c338195865d29f6bab13c83b","unresolved":false,"context_lines":[{"line_number":135,"context_line":"        \"\"\"Uploads a volume in Glance.\"\"\""},{"line_number":136,"context_line":"        post_body \u003d Element(\"volume\","},{"line_number":137,"context_line":"                            image_name\u003dimage_name,"},{"line_number":138,"context_line":"                           )"},{"line_number":139,"context_line":"        post_body \u003d Element(\u0027os-volume_upload_image\u0027).append(post_body)"},{"line_number":140,"context_line":"        url \u003d \u0027volumes/%s/action\u0027 %str(volume_id)"},{"line_number":141,"context_line":"        resp, body \u003d self.post(url, str(Document(post_body)), self.headers)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAQn%2F%2FJs4%3D","line":138,"updated":"2013-08-06 10:50:34.000000000","message":"pep8 suggests you should close the \")\" on the line before, right after the image_name parameter","commit_id":"d36d92b741331ecf9f487e551984e2fb1020a41a"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"bf0f8a6f88c18852c338195865d29f6bab13c83b","unresolved":false,"context_lines":[{"line_number":137,"context_line":"                            image_name\u003dimage_name,"},{"line_number":138,"context_line":"                           )"},{"line_number":139,"context_line":"        post_body \u003d Element(\u0027os-volume_upload_image\u0027).append(post_body)"},{"line_number":140,"context_line":"        url \u003d \u0027volumes/%s/action\u0027 %str(volume_id)"},{"line_number":141,"context_line":"        resp, body \u003d self.post(url, str(Document(post_body)), self.headers)"},{"line_number":142,"context_line":"        volume \u003d xml_to_json(etree.fromstring(body))"},{"line_number":143,"context_line":"        return resp, volume"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAQn%2F%2FJtg%3D","line":140,"updated":"2013-08-06 10:50:34.000000000","message":"pep8 suggests you should write \"% str(volume_id)\" and not \"%str(volume_id)\"","commit_id":"d36d92b741331ecf9f487e551984e2fb1020a41a"}]}