)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"5bfd20956003c6579dfceb026848d4b530ef5fd9","unresolved":false,"context_lines":[{"line_number":16,"context_line":"The tempest/api/network/test_routers.py had an extra assert,"},{"line_number":17,"context_line":"which is moved to tempest/api/network/admin/test_routers_dvr.py ."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"In both files the tests were submitted years before."},{"line_number":20,"context_line":"The duplication is not happened because of an inside"},{"line_number":21,"context_line":" tempest code move."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Change-Id: I75c5ec4050235c79e6269ace6862be054d032821"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"7a77a97e_40c49f91","line":21,"range":{"start_line":19,"start_character":0,"end_line":21,"end_character":19},"updated":"2016-11-14 23:40:36.000000000","message":"I am not sure this comment, especially \"an inside tempest code move\".","commit_id":"f63985fa40a247b530867cd7dde30ac5865990e7"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"0c0bfc57a96612b5199a7c49625452e36ede0808","unresolved":false,"context_lines":[{"line_number":16,"context_line":"The tempest/api/network/test_routers.py had an extra assert,"},{"line_number":17,"context_line":"which is moved to tempest/api/network/admin/test_routers_dvr.py ."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"In both files the tests were submitted years before."},{"line_number":20,"context_line":"The duplication is not happened because of an inside"},{"line_number":21,"context_line":" tempest code move."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Change-Id: I75c5ec4050235c79e6269ace6862be054d032821"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"7a77a97e_53f8f07c","line":21,"range":{"start_line":19,"start_character":0,"end_line":21,"end_character":19},"in_reply_to":"7a77a97e_40c49f91","updated":"2016-11-15 05:14:03.000000000","message":"I will rephrase it, looks like we got the similar test from two different commit, we did not messed up anything by moving/renaming the tests inside tempest.","commit_id":"f63985fa40a247b530867cd7dde30ac5865990e7"}],"tempest/api/network/test_routers.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"9bad500f5d69ad22b9d5c13794f8143294a96ab9","unresolved":false,"context_lines":[{"line_number":412,"context_line":"        self.assertTrue(create_body[\u0027router\u0027][\u0027distributed\u0027])"},{"line_number":413,"context_line":""},{"line_number":414,"context_line":"    @test.idempotent_id(\u0027644d7a4a-01a1-4b68-bb8d-0c0042cb1729\u0027)"},{"line_number":415,"context_line":"    def test_convert_centralized_router(self):"},{"line_number":416,"context_line":"        router \u003d self._create_router()"},{"line_number":417,"context_line":"        self.assertNotIn(\u0027distributed\u0027, router)"},{"line_number":418,"context_line":"        update_body \u003d self.admin_routers_client.update_router(router[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a629dbe_49b4c3d0","side":"PARENT","line":415,"updated":"2016-11-14 08:58:15.000000000","message":"This test is not similar to test_centralized_router_update_to_dvr().\n\nThis one calls show_router twice to check that the \u0027distributed\u0027 attribut is persisted. \nThis one also tests that the \u0027distributed\u0027 attribut is  not visible (L424) to regular user.","commit_id":"92507fa63500c024ace683ea295f459b20ff2c33"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"5bfd20956003c6579dfceb026848d4b530ef5fd9","unresolved":false,"context_lines":[{"line_number":395,"context_line":"class DvrRoutersTest(base.BaseRouterTest):"},{"line_number":396,"context_line":""},{"line_number":397,"context_line":"    @classmethod"},{"line_number":398,"context_line":"    def skip_checks(cls):"},{"line_number":399,"context_line":"        super(DvrRoutersTest, cls).skip_checks()"},{"line_number":400,"context_line":"        if not test.is_extension_enabled(\u0027dvr\u0027, \u0027network\u0027):"},{"line_number":401,"context_line":"            msg \u003d \"DVR extension not enabled.\""},{"line_number":402,"context_line":"            raise cls.skipException(msg)"},{"line_number":403,"context_line":""},{"line_number":404,"context_line":"    @test.idempotent_id(\u0027141297aa-3424-455d-aa8d-f2d95731e00a\u0027)"},{"line_number":405,"context_line":"    def test_create_distributed_router(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a77a97e_20e24304","side":"PARENT","line":402,"range":{"start_line":398,"start_character":0,"end_line":402,"end_character":40},"updated":"2016-11-14 23:40:36.000000000","message":"fine by comparing the alternative code, LGTM","commit_id":"92507fa63500c024ace683ea295f459b20ff2c33"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"5bfd20956003c6579dfceb026848d4b530ef5fd9","unresolved":false,"context_lines":[{"line_number":401,"context_line":"            msg \u003d \"DVR extension not enabled.\""},{"line_number":402,"context_line":"            raise cls.skipException(msg)"},{"line_number":403,"context_line":""},{"line_number":404,"context_line":"    @test.idempotent_id(\u0027141297aa-3424-455d-aa8d-f2d95731e00a\u0027)"},{"line_number":405,"context_line":"    def test_create_distributed_router(self):"},{"line_number":406,"context_line":"        name \u003d data_utils.rand_name(\u0027router\u0027)"},{"line_number":407,"context_line":"        create_body \u003d self.admin_routers_client.create_router("},{"line_number":408,"context_line":"            name\u003dname, distributed\u003dTrue)"},{"line_number":409,"context_line":"        self.addCleanup(self._delete_router,"},{"line_number":410,"context_line":"                        create_body[\u0027router\u0027][\u0027id\u0027],"},{"line_number":411,"context_line":"                        self.admin_routers_client)"},{"line_number":412,"context_line":"        self.assertTrue(create_body[\u0027router\u0027][\u0027distributed\u0027])"},{"line_number":413,"context_line":""},{"line_number":414,"context_line":"    @test.idempotent_id(\u0027644d7a4a-01a1-4b68-bb8d-0c0042cb1729\u0027)"},{"line_number":415,"context_line":"    def test_convert_centralized_router(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a77a97e_16cf51b1","side":"PARENT","line":412,"range":{"start_line":404,"start_character":0,"end_line":412,"end_character":61},"updated":"2016-11-14 23:40:36.000000000","message":"This is completely same as the existing test_distributed_router_creation, LGTM","commit_id":"92507fa63500c024ace683ea295f459b20ff2c33"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"5bfd20956003c6579dfceb026848d4b530ef5fd9","unresolved":false,"context_lines":[{"line_number":418,"context_line":"        update_body \u003d self.admin_routers_client.update_router(router[\u0027id\u0027],"},{"line_number":419,"context_line":"                                                              distributed\u003dTrue)"},{"line_number":420,"context_line":"        self.assertTrue(update_body[\u0027router\u0027][\u0027distributed\u0027])"},{"line_number":421,"context_line":"        show_body \u003d self.admin_routers_client.show_router(router[\u0027id\u0027])"},{"line_number":422,"context_line":"        self.assertTrue(show_body[\u0027router\u0027][\u0027distributed\u0027])"},{"line_number":423,"context_line":"        show_body \u003d self.routers_client.show_router(router[\u0027id\u0027])"},{"line_number":424,"context_line":"        self.assertNotIn(\u0027distributed\u0027, show_body[\u0027router\u0027])"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a77a97e_761a4519","side":"PARENT","line":422,"range":{"start_line":421,"start_character":0,"end_line":422,"end_character":59},"updated":"2016-11-14 23:40:36.000000000","message":"Strictly, this assertion is checking the default behavior of admin\u0027s show_router() without specifying distributed\u003dTrue by comparing test_centralized_router_to_dvr().\n\nSo it would be nice to add this assertion to the kept test.","commit_id":"92507fa63500c024ace683ea295f459b20ff2c33"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"0c0bfc57a96612b5199a7c49625452e36ede0808","unresolved":false,"context_lines":[{"line_number":418,"context_line":"        update_body \u003d self.admin_routers_client.update_router(router[\u0027id\u0027],"},{"line_number":419,"context_line":"                                                              distributed\u003dTrue)"},{"line_number":420,"context_line":"        self.assertTrue(update_body[\u0027router\u0027][\u0027distributed\u0027])"},{"line_number":421,"context_line":"        show_body \u003d self.admin_routers_client.show_router(router[\u0027id\u0027])"},{"line_number":422,"context_line":"        self.assertTrue(show_body[\u0027router\u0027][\u0027distributed\u0027])"},{"line_number":423,"context_line":"        show_body \u003d self.routers_client.show_router(router[\u0027id\u0027])"},{"line_number":424,"context_line":"        self.assertNotIn(\u0027distributed\u0027, show_body[\u0027router\u0027])"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a77a97e_736a4c1c","side":"PARENT","line":422,"range":{"start_line":421,"start_character":0,"end_line":422,"end_character":59},"in_reply_to":"7a77a97e_761a4519","updated":"2016-11-15 05:14:03.000000000","message":"Right.","commit_id":"92507fa63500c024ace683ea295f459b20ff2c33"}]}