)]}'
{"etc/tempest.conf.sample":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"6a5fda976a3057e3d234f74256feef04a9116c0d","unresolved":false,"context_lines":[{"line_number":81,"context_line":"# Run additional tests that use SSH for instance validation?"},{"line_number":82,"context_line":"# This requires the instances be routable from the host"},{"line_number":83,"context_line":"#  executing the tests"},{"line_number":84,"context_line":"run_ssh \u003d true"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"#Auth strategy for ssh into the VM"},{"line_number":87,"context_line":"# Either \"pubkey\" or \"password\" (default password)"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAQn%2F%2FTL4%3D","line":84,"updated":"2013-08-02 10:17:36.000000000","message":"I would not enable this by default","commit_id":"7aa23fa98e0dec6938ed1cfe8a2e90dbb1abc4c2"}],"tempest/api/compute/base.py":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"6a5fda976a3057e3d234f74256feef04a9116c0d","unresolved":false,"context_lines":[{"line_number":109,"context_line":"                pass"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    @classmethod"},{"line_number":112,"context_line":"    def clear_keys(cls):"},{"line_number":113,"context_line":"        for key in cls.keypairs:"},{"line_number":114,"context_line":"            try:"},{"line_number":115,"context_line":"                cls.keypairs_client.delete_keypair(key[\u0027name\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAQn%2F%2FTLs%3D","line":112,"updated":"2013-08-02 10:17:36.000000000","message":"I\u0027d prefer to call this clear_keypairs","commit_id":"7aa23fa98e0dec6938ed1cfe8a2e90dbb1abc4c2"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"6a5fda976a3057e3d234f74256feef04a9116c0d","unresolved":false,"context_lines":[{"line_number":171,"context_line":"        return resp, image"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    @classmethod"},{"line_number":174,"context_line":"    def create_key(cls, name\u003dNone):"},{"line_number":175,"context_line":"        \"\"\"Wrapper utility that creates a key.\"\"\""},{"line_number":176,"context_line":"        if name is None:"},{"line_number":177,"context_line":"            name \u003d rand_name(cls.__name__ + \"-keypair\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAQn%2F%2FTLo%3D","line":174,"updated":"2013-08-02 10:17:36.000000000","message":"I\u0027d prefer to call this create_keypair","commit_id":"7aa23fa98e0dec6938ed1cfe8a2e90dbb1abc4c2"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"6a5fda976a3057e3d234f74256feef04a9116c0d","unresolved":false,"context_lines":[{"line_number":211,"context_line":"        return auth_param"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"    @classmethod"},{"line_number":214,"context_line":"    def get_ssh_create_param(cls):"},{"line_number":215,"context_line":"        # If ssh auth strategy is public key, create a key"},{"line_number":216,"context_line":"        # and return it as extra param for the server create"},{"line_number":217,"context_line":"        extra_params \u003d {}"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAQn%2F%2FTKQ%3D","line":214,"updated":"2013-08-02 10:17:36.000000000","message":"how about rename this into get_keypair , return only the actual keypair name and pass it at server creation keeping the actual param name in the test class rather than in the base class?","commit_id":"7aa23fa98e0dec6938ed1cfe8a2e90dbb1abc4c2"}],"tempest/api/compute/servers/test_create_server.py":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"6a5fda976a3057e3d234f74256feef04a9116c0d","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    @testtools.skipIf(not run_ssh, \u0027Instance validation tests are disabled.\u0027)"},{"line_number":96,"context_line":"    @attr(type\u003d\u0027gate\u0027)"},{"line_number":97,"context_line":"    def test_can_log_into_created_server(self):"},{"line_number":98,"context_line":"        # Check that the user can authenticate with the generated password"},{"line_number":99,"context_line":"        linux_client \u003d RemoteClient(self.server, self.ssh_user,"},{"line_number":100,"context_line":"                                    **(self.get_ssh_auth_param()))"},{"line_number":101,"context_line":"        self.assertTrue(linux_client.can_authenticate())"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAQn%2F%2FTJk%3D","line":98,"updated":"2013-08-02 10:17:36.000000000","message":"maybe you should update the comment, we\u0027ll be also checking if login via public key works if configured accordingly","commit_id":"7aa23fa98e0dec6938ed1cfe8a2e90dbb1abc4c2"}],"tempest/config.py":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"6a5fda976a3057e3d234f74256feef04a9116c0d","unresolved":false,"context_lines":[{"line_number":145,"context_line":"                help\u003d\"Does the test environment support changing the admin \""},{"line_number":146,"context_line":"                     \"password?\"),"},{"line_number":147,"context_line":"    cfg.StrOpt(\u0027ssh_auth_strategy\u0027,"},{"line_number":148,"context_line":"               default\u003d\u0027pubkey\u0027,"},{"line_number":149,"context_line":"               help\u003d\"Authentication mechanism for ssh into VMs \""},{"line_number":150,"context_line":"                    \"Either password or pubkey\"),"},{"line_number":151,"context_line":"    cfg.BoolOpt(\u0027create_image_enabled\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAQn%2F%2FTJU%3D","line":148,"updated":"2013-08-02 10:17:36.000000000","message":"wouldn\u0027t it be safer to leave the default as \"password\" ?","commit_id":"7aa23fa98e0dec6938ed1cfe8a2e90dbb1abc4c2"}]}