)]}'
{"tox.ini":[{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"aac2c76fbc2679c796b105f3a52a69c460026bcb","unresolved":false,"context_lines":[{"line_number":36,"context_line":"sitepackages \u003d True"},{"line_number":37,"context_line":"setenv \u003d VIRTUAL_ENV\u003d{envdir}"},{"line_number":38,"context_line":"commands \u003d"},{"line_number":39,"context_line":"  sh tools/pretty_tox.sh \u0027^tempest.(api|scenario|thirdparty|cli)(?!.*\\[.*\\bslow\\b.*\\]).*$ {posargs}\u0027"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"[testenv:smoke]"},{"line_number":42,"context_line":"sitepackages \u003d True"}],"source_content_type":"text/x-properties","patch_set":1,"id":"AAAAQn%2F%2FV6w%3D","line":39,"updated":"2013-08-01 18:01:33.000000000","message":"shouldn\u0027t the regex be:\n^tempest\\.(api|scenario|thirdparty|cli)(?!.*\\[.*\\bslow\\b.*\\]).*$\n\nbecause it\u0027s a period between tempest and the test directory not any character.","commit_id":"bb6d28f3375c79bc2a144f21ede3d1a461704c02"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"8383caa45430f912989a96be51e3319335de0882","unresolved":false,"context_lines":[{"line_number":30,"context_line":"sitepackages \u003d True"},{"line_number":31,"context_line":"setenv \u003d VIRTUAL_ENV\u003d{envdir}"},{"line_number":32,"context_line":"commands \u003d"},{"line_number":33,"context_line":"  sh tools/pretty_tox_serial.sh \u0027^tempest\\.(api|scenario|thirdparty|cli)(?!.*\\[.*\\bslow\\b.*\\]).*$ {posargs}\u0027"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"[testenv:testr-full]"},{"line_number":36,"context_line":"sitepackages \u003d True"}],"source_content_type":"text/x-properties","patch_set":2,"id":"AAAAQn%2F%2FVLU%3D","line":33,"updated":"2013-08-01 21:06:26.000000000","message":"AIUI it the concern here is \u0027how do devs build on this to exclude more tests, easily\u0027. I think we\u0027ll need to discuss that more fully - perhaps on a bug on https://bugs.launchpad.net/testrepository/ - because designing a language is hard. I support the idea of having a good way to do this with testr, but the \u0027obvious\u0027 route of adding a --exclude option still fails the \u0027build on a selection gracefully\u0027 test.\n\nThat said, this seems more complex a regex than needed. \n\n\u0027(:?!.*\\[.*\\bslow\\b.*\\])\u0027 can be placed at the front and have the necessary effect - it will blacklist any slow tagged test.\n\nThen \u0027^tempest\\.(api|scenario|thirdparty|cli)\u0027 appended will match the submodules you want to.\n\nBut to make it easier to extend by users I would do:\n\n\u0027(:?!.*\\[.*\\bslow\\b.*\\])(:^tempest\\.(:api|scenario|thirdparty|cli))\u0027\n\nMore exclusions can be done by prepending a (:?!.*\u003cfoo\u003e) negative lookahead. More inclusions can be done by |\u0027ing with the ^tempest group. \nE.g. to also exclude swift tests just prepend (:?!.*swift)\n\u0027(:?!.*swift)(:?!.*\\[.*\\bslow\\b.*\\].*)(:^tempest\\.(:api|scenario|thirdparty|cli))\u0027","commit_id":"d28f5a87b32f26ffb7196e35e9811dc3528fa209"}]}
