)]}'
{"tempest/api/compute/servers/test_create_server.py":[{"author":{"_account_id":15847,"name":"Mikhail Feoktistov","email":"mfeoktistov@virtuozzo.com","username":"mfeoktistov"},"change_message_id":"589ca42e290e86d2d10a0ab1c3c101823f07b2a1","unresolved":false,"context_lines":[{"line_number":312,"context_line":"            self.validation_resources[\u0027keypair\u0027][\u0027private_key\u0027],"},{"line_number":313,"context_line":"            server\u003dserver_no_eph_disk,"},{"line_number":314,"context_line":"            servers_client\u003dself.client)"},{"line_number":315,"context_line":"        partition_num \u003d len(linux_client.get_disks().split(\u0027\\n\u0027))"},{"line_number":316,"context_line":""},{"line_number":317,"context_line":"        # Explicit server deletion necessary for Juno compatibility"},{"line_number":318,"context_line":"        self.client.delete_server(server_no_eph_disk[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a77a97e_67afea2b","line":315,"range":{"start_line":315,"start_character":8,"end_line":315,"end_character":21},"updated":"2016-11-21 13:59:37.000000000","message":"Maybe rename variable from \"partition_num\" to \"disk_num\"?\nand the same for all patch","commit_id":"9a366813da271593b5344a3b99d9ffb50241938f"},{"author":{"_account_id":13431,"name":"Evgeny Antyshev","email":"eantyshev@gmail.com","username":"eantyshev"},"change_message_id":"68898d888d8ca1f5bc29af42fbbc4dc7cdd6ea8f","unresolved":false,"context_lines":[{"line_number":312,"context_line":"            self.validation_resources[\u0027keypair\u0027][\u0027private_key\u0027],"},{"line_number":313,"context_line":"            server\u003dserver_no_eph_disk,"},{"line_number":314,"context_line":"            servers_client\u003dself.client)"},{"line_number":315,"context_line":"        partition_num \u003d len(linux_client.get_disks().split(\u0027\\n\u0027))"},{"line_number":316,"context_line":""},{"line_number":317,"context_line":"        # Explicit server deletion necessary for Juno compatibility"},{"line_number":318,"context_line":"        self.client.delete_server(server_no_eph_disk[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a77a97e_d877bf06","line":315,"range":{"start_line":315,"start_character":8,"end_line":315,"end_character":21},"in_reply_to":"7a77a97e_67afea2b","updated":"2016-11-21 14:29:32.000000000","message":"ok, will do","commit_id":"9a366813da271593b5344a3b99d9ffb50241938f"}],"tempest/common/utils/linux/remote_client.py":[{"author":{"_account_id":21284,"name":"Pavel Gluschak (scsnow)","email":"pglushchak@virtuozzo.com","username":"scsnow"},"change_message_id":"51217602e041b461f4e77662470842d34e3c57bc","unresolved":false,"context_lines":[{"line_number":124,"context_line":"                 # Show header line too"},{"line_number":125,"context_line":"                 selected.append(l)"},{"line_number":126,"context_line":"             # lsblk lists disk type in a column right-aligned with TYPE"},{"line_number":127,"context_line":"             elif pos \u003e 0 and l[pos:pos+4] \u003d\u003d \"disk\":"},{"line_number":128,"context_line":"                 selected.append(l)"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"        return \"\\n\".join(selected) "}],"source_content_type":"text/x-python","patch_set":1,"id":"7a77a97e_aa3389f5","line":127,"updated":"2016-11-21 13:41:02.000000000","message":"why we need to filter out \u0027disk\u0027 here? \u0027--nodeps\u0027 ensures that no parts will be displayed.","commit_id":"9a366813da271593b5344a3b99d9ffb50241938f"},{"author":{"_account_id":21284,"name":"Pavel Gluschak (scsnow)","email":"pglushchak@virtuozzo.com","username":"scsnow"},"change_message_id":"2fc6c1c757b4ad1a97d94d4d17c1bb627d5998e5","unresolved":false,"context_lines":[{"line_number":124,"context_line":"                 # Show header line too"},{"line_number":125,"context_line":"                 selected.append(l)"},{"line_number":126,"context_line":"             # lsblk lists disk type in a column right-aligned with TYPE"},{"line_number":127,"context_line":"             elif pos \u003e 0 and l[pos:pos+4] \u003d\u003d \"disk\":"},{"line_number":128,"context_line":"                 selected.append(l)"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"        return \"\\n\".join(selected) "}],"source_content_type":"text/x-python","patch_set":1,"id":"7a77a97e_cdffffa8","line":127,"in_reply_to":"7a77a97e_6a53316d","updated":"2016-11-21 14:12:26.000000000","message":"and rom device doesn\u0027t appear in /proc/partitions unlike in lsblk output?\nI\u0027m trying to understand whether we need this parsing at all.","commit_id":"9a366813da271593b5344a3b99d9ffb50241938f"},{"author":{"_account_id":21284,"name":"Pavel Gluschak (scsnow)","email":"pglushchak@virtuozzo.com","username":"scsnow"},"change_message_id":"e86beb2c938f954a674c6103ecdc08b8d4f0330a","unresolved":false,"context_lines":[{"line_number":124,"context_line":"                 # Show header line too"},{"line_number":125,"context_line":"                 selected.append(l)"},{"line_number":126,"context_line":"             # lsblk lists disk type in a column right-aligned with TYPE"},{"line_number":127,"context_line":"             elif pos \u003e 0 and l[pos:pos+4] \u003d\u003d \"disk\":"},{"line_number":128,"context_line":"                 selected.append(l)"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"        return \"\\n\".join(selected) "}],"source_content_type":"text/x-python","patch_set":1,"id":"7a77a97e_de86c715","line":127,"in_reply_to":"7a77a97e_7385ecab","updated":"2016-11-21 15:02:34.000000000","message":"...\nselected.extend([l for l in lines[1:] if l.endswith(\u0027disk\u0027)])","commit_id":"9a366813da271593b5344a3b99d9ffb50241938f"},{"author":{"_account_id":21284,"name":"Pavel Gluschak (scsnow)","email":"pglushchak@virtuozzo.com","username":"scsnow"},"change_message_id":"68ce856e26bf2a1339888b7962facb754a3e29b9","unresolved":false,"context_lines":[{"line_number":124,"context_line":"                 # Show header line too"},{"line_number":125,"context_line":"                 selected.append(l)"},{"line_number":126,"context_line":"             # lsblk lists disk type in a column right-aligned with TYPE"},{"line_number":127,"context_line":"             elif pos \u003e 0 and l[pos:pos+4] \u003d\u003d \"disk\":"},{"line_number":128,"context_line":"                 selected.append(l)"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"        return \"\\n\".join(selected) "}],"source_content_type":"text/x-python","patch_set":1,"id":"7a77a97e_7385ecab","line":127,"in_reply_to":"7a77a97e_9848e7ce","updated":"2016-11-21 14:49:27.000000000","message":"ok, maybe it\u0027s better to do this like\n\ncommand \u003d \u0027lsblk -lb --nodeps -o NAME,TYPE\u0027\noutput \u003d self.exec_command(command)\nlines \u003d output.splitlines()\nselected \u003d [lines[0]]\nselected.extend([l for l in lines if l.endswith(\u0027disk\u0027)])","commit_id":"9a366813da271593b5344a3b99d9ffb50241938f"},{"author":{"_account_id":13431,"name":"Evgeny Antyshev","email":"eantyshev@gmail.com","username":"eantyshev"},"change_message_id":"d7ad04269ead77412a69a14e275e79e6d2c3641f","unresolved":false,"context_lines":[{"line_number":124,"context_line":"                 # Show header line too"},{"line_number":125,"context_line":"                 selected.append(l)"},{"line_number":126,"context_line":"             # lsblk lists disk type in a column right-aligned with TYPE"},{"line_number":127,"context_line":"             elif pos \u003e 0 and l[pos:pos+4] \u003d\u003d \"disk\":"},{"line_number":128,"context_line":"                 selected.append(l)"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"        return \"\\n\".join(selected) "}],"source_content_type":"text/x-python","patch_set":1,"id":"7a77a97e_6a53316d","line":127,"in_reply_to":"7a77a97e_aa3389f5","updated":"2016-11-21 13:54:58.000000000","message":"there could be other types, generally speaking: rom disks, for example. I see such on my Ubuntu desktop:\nevgeny@eantyshev2:~$ lsblk -lb --nodeps\nNAME MAJ:MIN RM          SIZE RO TYPE MOUNTPOINT\nsda    8:0    0  128035676160  0 disk \nsdb    8:16   0 1000204886016  0 disk \nsr0   11:0    1    1073741312  0 rom","commit_id":"9a366813da271593b5344a3b99d9ffb50241938f"},{"author":{"_account_id":13431,"name":"Evgeny Antyshev","email":"eantyshev@gmail.com","username":"eantyshev"},"change_message_id":"68898d888d8ca1f5bc29af42fbbc4dc7cdd6ea8f","unresolved":false,"context_lines":[{"line_number":124,"context_line":"                 # Show header line too"},{"line_number":125,"context_line":"                 selected.append(l)"},{"line_number":126,"context_line":"             # lsblk lists disk type in a column right-aligned with TYPE"},{"line_number":127,"context_line":"             elif pos \u003e 0 and l[pos:pos+4] \u003d\u003d \"disk\":"},{"line_number":128,"context_line":"                 selected.append(l)"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"        return \"\\n\".join(selected) "}],"source_content_type":"text/x-python","patch_set":1,"id":"7a77a97e_9848e7ce","line":127,"in_reply_to":"7a77a97e_cdffffa8","updated":"2016-11-21 14:29:32.000000000","message":"There could be no problems with existing testcase, but all usage scenarios of remote_client.get_partitions() imply disk devices. So filtering out everything but disks is more deterministic, IMHO.","commit_id":"9a366813da271593b5344a3b99d9ffb50241938f"},{"author":{"_account_id":13431,"name":"Evgeny Antyshev","email":"eantyshev@gmail.com","username":"eantyshev"},"change_message_id":"45c9c640ebb2a395596a8e12a2f0b711c1bbfa23","unresolved":false,"context_lines":[{"line_number":124,"context_line":"                 # Show header line too"},{"line_number":125,"context_line":"                 selected.append(l)"},{"line_number":126,"context_line":"             # lsblk lists disk type in a column right-aligned with TYPE"},{"line_number":127,"context_line":"             elif pos \u003e 0 and l[pos:pos+4] \u003d\u003d \"disk\":"},{"line_number":128,"context_line":"                 selected.append(l)"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"        return \"\\n\".join(selected) "}],"source_content_type":"text/x-python","patch_set":1,"id":"7a77a97e_39b8b5e5","line":127,"in_reply_to":"7a77a97e_de86c715","updated":"2016-11-21 15:26:34.000000000","message":"This approach makes it somewhat more robust,\nbut much less informative","commit_id":"9a366813da271593b5344a3b99d9ffb50241938f"},{"author":{"_account_id":21284,"name":"Pavel Gluschak (scsnow)","email":"pglushchak@virtuozzo.com","username":"scsnow"},"change_message_id":"aa80ac4ae8791078279b488cd1e2717f5cb67258","unresolved":false,"context_lines":[{"line_number":124,"context_line":"                # Show header line too"},{"line_number":125,"context_line":"                selected.append(l)"},{"line_number":126,"context_line":"            # lsblk lists disk type in a column right-aligned with TYPE"},{"line_number":127,"context_line":"            elif pos \u003e 0 and l[pos:pos + 4] \u003d\u003d \"disk\":"},{"line_number":128,"context_line":"                selected.append(l)"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"        return \"\\n\".join(selected)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a77a97e_32b0a0dd","line":127,"range":{"start_line":127,"start_character":35,"end_line":127,"end_character":42},"updated":"2016-11-22 11:58:53.000000000","message":"pep8: pos+4","commit_id":"e7fc4a77a2449431223f942a9e2b144c1cbe7b6c"}]}