)]}'
{"tempest/scenario/test_network_basic_ops.py":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"e0c9da44cf8e02d4fb31d14e7c302aad7bab5671","unresolved":false,"context_lines":[{"line_number":748,"context_line":"        self.check_public_network_connectivity("},{"line_number":749,"context_line":"            should_connect\u003dFalse,"},{"line_number":750,"context_line":"            msg\u003d\u0027after router unscheduling\u0027,"},{"line_number":751,"context_line":"            should_check_floating_ip_status\u003dFalse"},{"line_number":752,"context_line":"        )"},{"line_number":753,"context_line":""},{"line_number":754,"context_line":"        # schedule resource to new agent"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a74a57a_bceb5777","side":"PARENT","line":751,"updated":"2016-11-25 23:09:25.000000000","message":"can we use a wait_until_true logic instead of getting rid of it completely?","commit_id":"274bb70c27cd69dc6ad48195a23e2fe1536b4cfd"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"38fc9b89624e139232a66488b54480e9afcbc693","unresolved":false,"context_lines":[{"line_number":748,"context_line":"        self.check_public_network_connectivity("},{"line_number":749,"context_line":"            should_connect\u003dFalse,"},{"line_number":750,"context_line":"            msg\u003d\u0027after router unscheduling\u0027,"},{"line_number":751,"context_line":"            should_check_floating_ip_status\u003dFalse"},{"line_number":752,"context_line":"        )"},{"line_number":753,"context_line":""},{"line_number":754,"context_line":"        # schedule resource to new agent"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a74a57a_fc0b0f28","side":"PARENT","line":751,"in_reply_to":"5a74a57a_bceb5777","updated":"2016-11-25 23:32:43.000000000","message":"if we don\u0027t pass False, it\u0027s True by default, making https://github.com/openstack/tempest/blob/master/tempest/scenario/manager.py#L884 triggered, that already does the wait_until_true part.\n\nThe failure I see is not in this line, but below, in line 766 where we assume that FIP already transitioned to DOWN, but in reality it did not, and hence we catch \u0027ACTIVE then DOWN\u0027 status of FIP:\n\nit\u0027s ACTIVE in https://github.com/openstack/tempest/blob/master/tempest/scenario/manager.py#L898\n\nbut it\u0027s DOWN in https://github.com/openstack/tempest/blob/master/tempest/scenario/manager.py#L903","commit_id":"274bb70c27cd69dc6ad48195a23e2fe1536b4cfd"}]}
