)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"98e24d1a779745d9d7e986a786ccb181858c31a4","unresolved":false,"context_lines":[{"line_number":14,"context_line":"   manager.py of scenario"},{"line_number":15,"context_line":"4. set status_timeout() as a classmethod"},{"line_number":16,"context_line":"   in test.py so as to use it in other"},{"line_number":17,"context_line":"   classmethod"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I85979f1bc5ef7a35f111b293e17bdbb942603279"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAAQn%2F%2FBwQ%3D","line":17,"updated":"2013-08-08 08:02:47.000000000","message":"Just for the next time, you could have look to https://wiki.openstack.org/wiki/GitCommitMessages.\n\n\"Subsequent lines should be wrapped at 72 characters.\"","commit_id":"3bd1c13a33c17013ee02f9a12f9992199a1cb71c"},{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"c69af73372b1bec36f692279ebcb1baed456abc8","unresolved":false,"context_lines":[{"line_number":14,"context_line":"   manager.py of scenario"},{"line_number":15,"context_line":"4. set status_timeout() as a classmethod"},{"line_number":16,"context_line":"   in test.py so as to use it in other"},{"line_number":17,"context_line":"   classmethod"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I85979f1bc5ef7a35f111b293e17bdbb942603279"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAAQ3%2F%2F6K4%3D","line":17,"in_reply_to":"AAAAQn%2F%2FBwQ%3D","updated":"2013-08-13 06:02:29.000000000","message":"thank you, Marc!","commit_id":"3bd1c13a33c17013ee02f9a12f9992199a1cb71c"}],"etc/tempest.conf.sample":[{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"745be59f1727507d6751e2066446f665d8d0171d","unresolved":false,"context_lines":[{"line_number":364,"context_line":"# testing.\""},{"line_number":365,"context_line":"large_ops_number \u003d 0"},{"line_number":366,"context_line":""},{"line_number":367,"context_line":"# Delete resource timeout "},{"line_number":368,"context_line":"delete_timeout \u003d 10"},{"line_number":369,"context_line":""},{"line_number":370,"context_line":"# Delete resource wait interval"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"AAAARH%2F%2F2Tw%3D","line":367,"updated":"2013-08-16 09:29:19.000000000","message":"Small white-space nit.","commit_id":"ef2a0d64573f3514cc3cf3af67f1e5f43c027218"},{"author":{"_account_id":1192,"name":"David Kranz","email":"dkranz@redhat.com","username":"david-kranz"},"change_message_id":"5371a4b57402861f3b919875b76d94282b706e73","unresolved":false,"context_lines":[{"line_number":368,"context_line":"large_ops_number \u003d 0"},{"line_number":369,"context_line":""},{"line_number":370,"context_line":"# Delete resource timeout"},{"line_number":371,"context_line":"delete_timeout \u003d 10"},{"line_number":372,"context_line":""},{"line_number":373,"context_line":"# Delete resource wait interval"},{"line_number":374,"context_line":"delete_interval \u003d 1"}],"source_content_type":"application/octet-stream","patch_set":11,"id":"AAAASn%2F%2FcX8%3D","line":371,"updated":"2013-09-04 18:44:16.000000000","message":"This is too short. I suggest just using the compute section build timeout and interval.","commit_id":"448eb9af6911d2132e4c6e03b8b505694c8606ca"}],"tempest/scenario/manager.py":[{"author":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"change_message_id":"449de0f40d62dd810c8f28619920b9f879f9715b","unresolved":false,"context_lines":[{"line_number":200,"context_line":"            cls.wait_until_deletion_complete(thing)"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"    @classmethod"},{"line_number":203,"context_line":"    def wait_until_deletion_complete(cls, thing, timeout\u003d30):"},{"line_number":204,"context_line":"        def is_deletion_complete():"},{"line_number":205,"context_line":"            # Deletion testing is only required for objects whose"},{"line_number":206,"context_line":"            # existence cannot be checked via retrieval."}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAQ3%2F%2F9hY%3D","line":203,"updated":"2013-08-12 13:09:59.000000000","message":"Is it really necessary to increase the timeout from 10 to 30 seconds?","commit_id":"3bd1c13a33c17013ee02f9a12f9992199a1cb71c"},{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"938c2ad9de6cca37471e7168dafc912b65c2aa0f","unresolved":false,"context_lines":[{"line_number":200,"context_line":"            cls.wait_until_deletion_complete(thing)"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"    @classmethod"},{"line_number":203,"context_line":"    def wait_until_deletion_complete(cls, thing, timeout\u003d30):"},{"line_number":204,"context_line":"        def is_deletion_complete():"},{"line_number":205,"context_line":"            # Deletion testing is only required for objects whose"},{"line_number":206,"context_line":"            # existence cannot be checked via retrieval."}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAQ3%2F%2F6Ck%3D","line":203,"in_reply_to":"AAAAQ3%2F%2F9hY%3D","updated":"2013-08-13 06:10:26.000000000","message":"An idea just comes to my mind, we can add \u0027delete_timeout \u003d 10\u0027 in [scenario] of tempest.conf.sample so as to users could customize this variable. Is it ok?","commit_id":"3bd1c13a33c17013ee02f9a12f9992199a1cb71c"},{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"c69af73372b1bec36f692279ebcb1baed456abc8","unresolved":false,"context_lines":[{"line_number":200,"context_line":"            cls.wait_until_deletion_complete(thing)"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"    @classmethod"},{"line_number":203,"context_line":"    def wait_until_deletion_complete(cls, thing, timeout\u003d30):"},{"line_number":204,"context_line":"        def is_deletion_complete():"},{"line_number":205,"context_line":"            # Deletion testing is only required for objects whose"},{"line_number":206,"context_line":"            # existence cannot be checked via retrieval."}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAQ3%2F%2F6IM%3D","line":203,"in_reply_to":"AAAAQ3%2F%2F9hY%3D","updated":"2013-08-13 06:02:29.000000000","message":"Christopher, thanks for you comments. I increased the timeout due to 10 seconds sometimes is not enough in my test evn which is very slow. 30s should be fine since it does not impact test results.","commit_id":"3bd1c13a33c17013ee02f9a12f9992199a1cb71c"}],"tempest/whitebox/test_servers_whitebox.py":[{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"21b62ba5ff3fda99c09218f715019e3eb1b6f015","unresolved":false,"context_lines":[{"line_number":61,"context_line":"            self.assertEqual(None, result.task_state)"},{"line_number":62,"context_line":"        except Exception:"},{"line_number":63,"context_line":"            raise"},{"line_number":64,"context_line":"            self.fail(\"Should be able to delete a server when vm_state\u003d%s and \""},{"line_number":65,"context_line":"                      \"task_state\u003d%s\" % (vm_state, task_state))"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def test_delete_server_when_vm_eq_building_task_eq_networking(self):"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAASn%2F%2Fy%2Fg%3D","line":64,"updated":"2013-08-29 13:40:09.000000000","message":"This code part will never run.\n\nYou can remove the try block completely or log the text before re-raise-ing the original exception.","commit_id":"403b021214c409ad0b3ef8ce8258e6eb6fed7fdc"},{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"90d1647cded3aebf547bc91e8a2f59bd38285a4c","unresolved":false,"context_lines":[{"line_number":61,"context_line":"            self.assertEqual(None, result.task_state)"},{"line_number":62,"context_line":"        except Exception:"},{"line_number":63,"context_line":"            raise"},{"line_number":64,"context_line":"            self.fail(\"Should be able to delete a server when vm_state\u003d%s and \""},{"line_number":65,"context_line":"                      \"task_state\u003d%s\" % (vm_state, task_state))"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def test_delete_server_when_vm_eq_building_task_eq_networking(self):"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAASn%2F%2FwHM%3D","line":64,"in_reply_to":"AAAASn%2F%2Fy%2Fg%3D","updated":"2013-08-30 01:34:30.000000000","message":"thank you! I debug it using \u0027raise\u0027, but forgot to delete it.","commit_id":"403b021214c409ad0b3ef8ce8258e6eb6fed7fdc"}]}