)]}'
{"releasenotes/notes/new-volume-v3-encryption-types-client-76796ac2af201524.yaml":[{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"7b658332ca6f1e86cc30c518bcb51d5d23685cda","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - The encryption_types client was added to tempest.lib."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1a6eadb0_20291138","line":3,"range":{"start_line":3,"start_character":4,"end_line":3,"end_character":57},"updated":"2016-12-20 12:43:35.000000000","message":"maybe add more details about the client itself? What it tries to accomplish? Which APIs it handles?","commit_id":"26d2be3bdfcfc1e17517477596112d206e41b615"},{"author":{"_account_id":14885,"name":"Daniel Mellado","email":"dmellado@redhat.com","username":"daniel-mellado"},"change_message_id":"fe197330d1897d889c3b08d5691312b70d2ada65","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - The encryption_types client was added to tempest.lib."},{"line_number":4,"context_line":"    Cinder API v1 is considered as deprecated, there is a cinder"},{"line_number":5,"context_line":"    v3 client that can be used for cinder."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1a6eadb0_1790b442","line":3,"range":{"start_line":3,"start_character":4,"end_line":3,"end_character":56},"updated":"2016-12-21 06:12:37.000000000","message":"Maybe a bit picky but I\u0027d say: - Add encryption_types client to tempest.lib","commit_id":"cd4f3b63d33fe52e95f2ec758c04bd6643fd7110"},{"author":{"_account_id":14885,"name":"Daniel Mellado","email":"dmellado@redhat.com","username":"daniel-mellado"},"change_message_id":"fe197330d1897d889c3b08d5691312b70d2ada65","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - The encryption_types client was added to tempest.lib."},{"line_number":4,"context_line":"    Cinder API v1 is considered as deprecated, there is a cinder"},{"line_number":5,"context_line":"    v3 client that can be used for cinder."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1a6eadb0_f7a7b8a4","line":5,"range":{"start_line":4,"start_character":47,"end_line":5,"end_character":42},"updated":"2016-12-21 06:12:37.000000000","message":"I\u0027d rephrase this as well. \u0027There\u0027s a cinder v2 client that can be used for cinder\u0027 sounds a li\u0027l bit odd for me.","commit_id":"cd4f3b63d33fe52e95f2ec758c04bd6643fd7110"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"9a999808fe15b83e8058d86fc306ea240afac2cd","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - The encryption_types client was added to tempest.lib."},{"line_number":4,"context_line":"    Cinder API v1 is considered as deprecated, there is a cinder"},{"line_number":5,"context_line":"    v3 client that can be used for cinder."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1a6eadb0_b771d2aa","line":5,"range":{"start_line":5,"start_character":7,"end_line":5,"end_character":13},"updated":"2016-12-20 19:03:10.000000000","message":"client or API?","commit_id":"cd4f3b63d33fe52e95f2ec758c04bd6643fd7110"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"9a999808fe15b83e8058d86fc306ea240afac2cd","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - The encryption_types client was added to tempest.lib."},{"line_number":4,"context_line":"    Cinder API v1 is considered as deprecated, there is a cinder"},{"line_number":5,"context_line":"    v3 client that can be used for cinder."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1a6eadb0_176366dd","line":5,"range":{"start_line":5,"start_character":30,"end_line":5,"end_character":41},"updated":"2016-12-20 19:03:10.000000000","message":"think this is not necessary, just add a period after \"used\"","commit_id":"cd4f3b63d33fe52e95f2ec758c04bd6643fd7110"}],"tempest/lib/services/volume/v3/encryption_types_client.py":[{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"7b658332ca6f1e86cc30c518bcb51d5d23685cda","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2012 OpenStack Foundation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":6,"context_line":"#    a copy of the License at"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_20e031fa","line":3,"range":{"start_line":1,"start_character":0,"end_line":3,"end_character":1},"updated":"2016-12-20 12:43:35.000000000","message":"This is a new file, right? Not a result from a \"git mv\"? This headers looks outdated :)","commit_id":"26d2be3bdfcfc1e17517477596112d206e41b615"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"7b658332ca6f1e86cc30c518bcb51d5d23685cda","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    def create_encryption_type(self, volume_type_id, **kwargs):"},{"line_number":51,"context_line":"        \"\"\"Create encryption type."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        TODO: Current api-site doesn\u0027t contain this API description."},{"line_number":54,"context_line":"        After fixing the api-site, we need to fix here also for putting"},{"line_number":55,"context_line":"        the link to api-site."},{"line_number":56,"context_line":"        \"\"\""},{"line_number":57,"context_line":"        url \u003d \"/types/%s/encryption\" % volume_type_id"},{"line_number":58,"context_line":"        post_body \u003d json.dumps({\u0027encryption\u0027: kwargs})"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_00ab358a","line":55,"range":{"start_line":53,"start_character":0,"end_line":55,"end_character":29},"updated":"2016-12-20 12:43:35.000000000","message":"I\u0027d use the TODO as a regular comment, like:\n\n # TODO(bkopilov)...","commit_id":"26d2be3bdfcfc1e17517477596112d206e41b615"},{"author":{"_account_id":14885,"name":"Daniel Mellado","email":"dmellado@redhat.com","username":"daniel-mellado"},"change_message_id":"fe197330d1897d889c3b08d5691312b70d2ada65","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    def create_encryption_type(self, volume_type_id, **kwargs):"},{"line_number":51,"context_line":"        \"\"\"Create encryption type."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        TODO: Current api-site doesn\u0027t contain this API description."},{"line_number":54,"context_line":"        After fixing the api-site, we need to fix here also for putting"},{"line_number":55,"context_line":"        the link to api-site."},{"line_number":56,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"1a6eadb0_b7c8e056","line":53,"range":{"start_line":53,"start_character":8,"end_line":53,"end_character":14},"updated":"2016-12-21 06:12:37.000000000","message":"Could you please modify this as per hacking guidelines? i.e. [H101] Include your name with TODOs as in # TODO(yourname). This makes it easier to find out who the author of the comment was.","commit_id":"cd4f3b63d33fe52e95f2ec758c04bd6643fd7110"}],"tempest/tests/lib/services/volume/v3/test_encryption_types_client.py":[{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"7b658332ca6f1e86cc30c518bcb51d5d23685cda","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2016 Red Hat.  All rights reserved."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_c08e9d26","line":1,"range":{"start_line":1,"start_character":3,"end_line":1,"end_character":25},"updated":"2016-12-20 12:43:35.000000000","message":"Copyright 2016 Red Hat, Inc.","commit_id":"26d2be3bdfcfc1e17517477596112d206e41b615"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"9a999808fe15b83e8058d86fc306ea240afac2cd","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2016 Red Hat, Inc.  All rights reserved."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a6eadb0_97a5b605","line":1,"range":{"start_line":1,"start_character":30,"end_line":1,"end_character":32},"updated":"2016-12-20 19:03:10.000000000","message":"new line here? see the other file.","commit_id":"cd4f3b63d33fe52e95f2ec758c04bd6643fd7110"},{"author":{"_account_id":14885,"name":"Daniel Mellado","email":"dmellado@redhat.com","username":"daniel-mellado"},"change_message_id":"fe197330d1897d889c3b08d5691312b70d2ada65","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2016 Red Hat, Inc.  All rights reserved."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a6eadb0_17def410","line":1,"range":{"start_line":1,"start_character":30,"end_line":1,"end_character":32},"in_reply_to":"1a6eadb0_97a5b605","updated":"2016-12-21 06:12:37.000000000","message":"+1","commit_id":"cd4f3b63d33fe52e95f2ec758c04bd6643fd7110"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"9a999808fe15b83e8058d86fc306ea240afac2cd","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    def setUp(self):"},{"line_number":47,"context_line":"        super(TestEncryptionTypesClient, self).setUp()"},{"line_number":48,"context_line":"        fake_auth \u003d fake_auth_provider.FakeAuthProvider()"},{"line_number":49,"context_line":"        self.client \u003d encryption_types_client.EncryptionTypesClient(fake_auth,"},{"line_number":50,"context_line":"                                                                    \u0027volume\u0027,"},{"line_number":51,"context_line":"                                                                    \u0027regionOne\u0027"},{"line_number":52,"context_line":"                                                                    )"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def _test_create_encryption(self, bytes_body\u003dFalse):"},{"line_number":55,"context_line":"        self.check_service_client_function("}],"source_content_type":"text/x-python","patch_set":3,"id":"1a6eadb0_b77f1265","line":52,"range":{"start_line":49,"start_character":68,"end_line":52,"end_character":69},"updated":"2016-12-20 19:03:10.000000000","message":"you can have this line completely at line 50","commit_id":"cd4f3b63d33fe52e95f2ec758c04bd6643fd7110"},{"author":{"_account_id":14885,"name":"Daniel Mellado","email":"dmellado@redhat.com","username":"daniel-mellado"},"change_message_id":"fe197330d1897d889c3b08d5691312b70d2ada65","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    def setUp(self):"},{"line_number":47,"context_line":"        super(TestEncryptionTypesClient, self).setUp()"},{"line_number":48,"context_line":"        fake_auth \u003d fake_auth_provider.FakeAuthProvider()"},{"line_number":49,"context_line":"        self.client \u003d encryption_types_client.EncryptionTypesClient(fake_auth,"},{"line_number":50,"context_line":"                                                                    \u0027volume\u0027,"},{"line_number":51,"context_line":"                                                                    \u0027regionOne\u0027"},{"line_number":52,"context_line":"                                                                    )"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def _test_create_encryption(self, bytes_body\u003dFalse):"},{"line_number":55,"context_line":"        self.check_service_client_function("}],"source_content_type":"text/x-python","patch_set":3,"id":"1a6eadb0_f7bed8ac","line":52,"range":{"start_line":49,"start_character":68,"end_line":52,"end_character":69},"in_reply_to":"1a6eadb0_b77f1265","updated":"2016-12-21 06:12:37.000000000","message":"+1","commit_id":"cd4f3b63d33fe52e95f2ec758c04bd6643fd7110"}]}