)]}'
{"tempest/api/compute/servers/test_list_servers_negative.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"f67ff25f0bc908e4ebfcff0624f27c240ed2a9ff","unresolved":false,"context_lines":[{"line_number":40,"context_line":"            srv \u003d cls.create_test_server(wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":41,"context_line":"            cls.existing_fixtures.append(srv)"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"        srv \u003d cls.create_test_server(wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":44,"context_line":"        cls.client.delete_server(srv[\u0027id\u0027])"},{"line_number":45,"context_line":"        waiters.wait_for_server_termination(cls.client, srv[\u0027id\u0027])"},{"line_number":46,"context_line":"        cls.deleted_fixtures.append(srv)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    @test.attr(type\u003d[\u0027negative\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_30068d86","line":45,"range":{"start_line":43,"start_character":0,"end_line":45,"end_character":66},"updated":"2016-12-05 10:07:37.000000000","message":"But server should be deleted even in error state. For this tests we need to just get a deleted server. So i feel waiting for active server is something not really needed here.","commit_id":"5d03e0441180e7af7e45f9369911c22c677a4065"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"7b406ea5bac109473ba721460c584c6769b91c5b","unresolved":false,"context_lines":[{"line_number":40,"context_line":"            srv \u003d cls.create_test_server(wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":41,"context_line":"            cls.existing_fixtures.append(srv)"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"        srv \u003d cls.create_test_server(wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":44,"context_line":"        cls.client.delete_server(srv[\u0027id\u0027])"},{"line_number":45,"context_line":"        waiters.wait_for_server_termination(cls.client, srv[\u0027id\u0027])"},{"line_number":46,"context_line":"        cls.deleted_fixtures.append(srv)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_341dca0f","line":43,"updated":"2016-12-14 11:24:05.000000000","message":"We do not strictly need a server in ACTIVE state for the test, but still it\u0027s not ok to ignore a server that goes into ERROR, which the previous code would do.\nThis forces the test to fail earlier (on the actual issues) during class setup, rather than let the error through and fail later during the tests.","commit_id":"42c14078686a428ede52865c791c6ca4043e5c44"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"efdf0c07f1c0f158b307710bcc9c1c40d3eff99a","unresolved":false,"context_lines":[{"line_number":40,"context_line":"            srv \u003d cls.create_test_server(wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":41,"context_line":"            cls.existing_fixtures.append(srv)"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"        srv \u003d cls.create_test_server(wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":44,"context_line":"        cls.client.delete_server(srv[\u0027id\u0027])"},{"line_number":45,"context_line":"        waiters.wait_for_server_termination(cls.client, srv[\u0027id\u0027])"},{"line_number":46,"context_line":"        cls.deleted_fixtures.append(srv)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_9ee878b6","line":43,"in_reply_to":"1a6eadb0_087432cd","updated":"2016-12-14 12:30:53.000000000","message":"But if we do not ignore Error state then it might be chance that wait_for_server_termination raise exception as nova might put server in error where delete request happened during boot.\n\nWhich is opposite to what we except (server should be deleted here even in any state/stage of compute)\n\nServer in Error or booting, nova should be able to delete sever.\n\nIf Error sever is not being deleted then wait_for_server_termination should timeout as server keep show up in monitoring. \n\nIf inn any scenario, if wait_for_server_termination return true even server not being deleted actually then this tests will fail and we can see actual bug in Nova. At least why server got stuck there even delete call happened(something wrong in delete logic).","commit_id":"42c14078686a428ede52865c791c6ca4043e5c44"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"92d031dbf0b9f5d6444b5fbdcf2ac8a7a22a36f3","unresolved":false,"context_lines":[{"line_number":40,"context_line":"            srv \u003d cls.create_test_server(wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":41,"context_line":"            cls.existing_fixtures.append(srv)"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"        srv \u003d cls.create_test_server(wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":44,"context_line":"        cls.client.delete_server(srv[\u0027id\u0027])"},{"line_number":45,"context_line":"        waiters.wait_for_server_termination(cls.client, srv[\u0027id\u0027])"},{"line_number":46,"context_line":"        cls.deleted_fixtures.append(srv)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_087432cd","line":43,"in_reply_to":"1a6eadb0_341dca0f","updated":"2016-12-14 11:53:15.000000000","message":"Actually if we test goes into ERROR it will be delete, so it won\u0027t fail in the tests, so the current code hides the failure in the server boot. \nBeing able to boot a server is not the primary aim of the test, but still it\u0027s ok to make sure the server can go to active. \nStill ignoring ERROR on delete is not correct.","commit_id":"42c14078686a428ede52865c791c6ca4043e5c44"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"d881517f48cc445a524b1a6e0457be791e0961d1","unresolved":false,"context_lines":[{"line_number":40,"context_line":"            srv \u003d cls.create_test_server(wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":41,"context_line":"            cls.existing_fixtures.append(srv)"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"        srv \u003d cls.create_test_server(wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":44,"context_line":"        cls.client.delete_server(srv[\u0027id\u0027])"},{"line_number":45,"context_line":"        waiters.wait_for_server_termination(cls.client, srv[\u0027id\u0027])"},{"line_number":46,"context_line":"        cls.deleted_fixtures.append(srv)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_06b4ba32","line":43,"in_reply_to":"1a6eadb0_9ee878b6","updated":"2016-12-16 09:19:28.000000000","message":"I think this change is explicit and correct way. If we want to catch a Nova bug, we should put a NOTE and/or explicit test cases.","commit_id":"42c14078686a428ede52865c791c6ca4043e5c44"}]}