)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"123806f1b8a02e69a97ef84170c18828bf8f6727","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Update create_isolated_networks logic"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Starting with Newton multitenancy was implemented in Ironic."},{"line_number":10,"context_line":"This patch fix setting create_netwroks variable to do not rely"},{"line_number":11,"context_line":"on CONF.baremetal.driver_enabled, and rely only on"},{"line_number":12,"context_line":"CONF.auth.create_isolated_networks variable."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a71b18c_e2151d40","line":9,"updated":"2016-12-05 15:49:21.000000000","message":"s/Newton/Newton,/","commit_id":"6a0da23e045367e8873410524bd6861129d2b367"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"123806f1b8a02e69a97ef84170c18828bf8f6727","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Update create_isolated_networks logic"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Starting with Newton multitenancy was implemented in Ironic."},{"line_number":10,"context_line":"This patch fix setting create_netwroks variable to do not rely"},{"line_number":11,"context_line":"on CONF.baremetal.driver_enabled, and rely only on"},{"line_number":12,"context_line":"CONF.auth.create_isolated_networks variable."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a71b18c_c223c1a5","line":10,"updated":"2016-12-05 15:49:21.000000000","message":"This patch fixes setting the create_networks variable to no rely on ...\n\ns/netwroks/networks/","commit_id":"6a0da23e045367e8873410524bd6861129d2b367"},{"author":{"_account_id":22226,"name":"Varun Gadiraju","email":"varun.gadiraju@intel.com","username":"gadirajv"},"change_message_id":"cb0d43068f73ffedbbf52775b1c370ef61096b26","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Multitenancy not restricted by Ironic anymore"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Starting with Newton multitenancy was implemented in Ironic."},{"line_number":10,"context_line":"This patch fix setting create_netwroks variable to do not rely"},{"line_number":11,"context_line":"on CONF.baremetal.driver_enabled explicitly, and rely only on"},{"line_number":12,"context_line":"CONF.auth.create_isolated_networks variable."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3a71b18c_d8fed137","line":10,"range":{"start_line":10,"start_character":23,"end_line":10,"end_character":38},"updated":"2016-12-07 23:52:52.000000000","message":"nit: spelling change from create_netwroks to create_networks \n:)","commit_id":"5a70bb5ac7806b920f411a4f4785ba5c352932f0"}],"tempest/scenario/manager.py":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"ad6391bd3c097021333b88401d82b9745dd6536f","unresolved":false,"context_lines":[{"line_number":1182,"context_line":"                        port_security_enabled\u003dTrue):"},{"line_number":1183,"context_line":"        \"\"\"Create a network with a subnet connected to a router."},{"line_number":1184,"context_line":""},{"line_number":1185,"context_line":"        The baremetal driver is a special case since all nodes are"},{"line_number":1186,"context_line":"        on the same shared network."},{"line_number":1187,"context_line":""},{"line_number":1188,"context_line":"        :param tenant_id: id of tenant to create resources in."}],"source_content_type":"text/x-python","patch_set":2,"id":"3a71b18c_89e63b13","line":1185,"updated":"2016-12-06 01:22:01.000000000","message":"Probably this comment should be removed.","commit_id":"f48b3de18e404488f50fae36967cbccc67a562aa"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"c5c79df5e44fc04e338b4923ba5667d9ec9bba8c","unresolved":false,"context_lines":[{"line_number":1183,"context_line":"        \"\"\"Create a network with a subnet connected to a router."},{"line_number":1184,"context_line":""},{"line_number":1185,"context_line":"        If create_isolated_networks is set to False and fixed_network_name is"},{"line_number":1186,"context_line":"        set to True, use existed shared network."},{"line_number":1187,"context_line":""},{"line_number":1188,"context_line":"        :param tenant_id: id of tenant to create resources in."},{"line_number":1189,"context_line":"        :param dns_nameservers: list of dns servers to send to subnet."}],"source_content_type":"text/x-python","patch_set":3,"id":"3a71b18c_f4575b23","line":1186,"range":{"start_line":1186,"start_character":25,"end_line":1186,"end_character":32},"updated":"2016-12-06 18:31:16.000000000","message":"nit: s/existed/existing/","commit_id":"7b7c4a6c09f84199985c7bfc1bd34ecb38cfe578"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"8cbf8badac00a3a50fb4b3812a4250d09217c3a5","unresolved":false,"context_lines":[{"line_number":1189,"context_line":"        :param dns_nameservers: list of dns servers to send to subnet."},{"line_number":1190,"context_line":"        :returns: network, subnet, router"},{"line_number":1191,"context_line":"        \"\"\""},{"line_number":1192,"context_line":"        if not CONF.auth.create_isolated_networks:"},{"line_number":1193,"context_line":"            if not CONF.compute.fixed_network_name:"},{"line_number":1194,"context_line":"                m \u003d \u0027fixed_network_name must be specified in config\u0027"},{"line_number":1195,"context_line":"                raise lib_exc.InvalidConfiguration(m)"}],"source_content_type":"text/x-python","patch_set":6,"id":"da4df55a_304c3470","line":1192,"updated":"2016-12-22 20:00:24.000000000","message":"This option is not the same thing as the old one. CONF.network.shared_physical_network is used to indicate whether the cloud under has a shared network for everything. (which was primarily added for ironic, but I was told wasn\u0027t limited to just ironic in usefulness) While CONF.auth.create_isolated_networks tells tempest whether it should make network resources when it creates isolated credentials for each test class. They\u0027re related things but independent, and I don\u0027t think this is the right option here.","commit_id":"b57db63eb436adefc8c0109f0d04c7bf481b7242"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"7efe6878ede69509aa4c5df60dff900a02d4b02a","unresolved":false,"context_lines":[{"line_number":1189,"context_line":"        :param dns_nameservers: list of dns servers to send to subnet."},{"line_number":1190,"context_line":"        :returns: network, subnet, router"},{"line_number":1191,"context_line":"        \"\"\""},{"line_number":1192,"context_line":"        if not CONF.auth.create_isolated_networks:"},{"line_number":1193,"context_line":"            if not CONF.compute.fixed_network_name:"},{"line_number":1194,"context_line":"                m \u003d \u0027fixed_network_name must be specified in config\u0027"},{"line_number":1195,"context_line":"                raise lib_exc.InvalidConfiguration(m)"}],"source_content_type":"text/x-python","patch_set":6,"id":"da4df55a_a62265ff","line":1192,"in_reply_to":"da4df55a_304c3470","updated":"2016-12-26 08:57:38.000000000","message":"So from tempest\u0027s point of view [0] both CONF.network.shared_physical_network and CONF.auth.create_isolated_networks are the triggers to indicate if tempest should use pre-created network or create it dynamically. I\u0027m wondered why tempest needs two variables that do the same thing, it confuses.\n\n[0] https://github.com/openstack/tempest/blob/cc6ed41498ed05ee689d9f5d1f0c4b433d0cb593/doc/source/configuration.rst#with-dynamic-credentials","commit_id":"b57db63eb436adefc8c0109f0d04c7bf481b7242"}]}