)]}'
{"tempest/lib/cmd/check_uuid.py":[{"author":{"_account_id":23184,"name":"DavidPurcell","email":"d.purcell222@gmail.com","username":"DavidPurcell"},"change_message_id":"29ee5a4c104960c710f66fe605f1f2314d27701b","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        if filename not in self.source_files:"},{"line_number":63,"context_line":"            with open(filename) as f:"},{"line_number":64,"context_line":"                self.source_files[filename] \u003d self._quote(f.read())"},{"line_number":65,"context_line":"        patch_id \u003d uuidutils.generate_uuid()"},{"line_number":66,"context_line":"        if not patch.endswith(\u0027\\n\u0027):"},{"line_number":67,"context_line":"            patch +\u003d \u0027\\n\u0027"},{"line_number":68,"context_line":"        self.patches[patch_id] \u003d self._quote(patch)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_6ffd386d","line":65,"range":{"start_line":65,"start_character":8,"end_line":65,"end_character":44},"updated":"2016-12-06 18:48:46.000000000","message":"I think this should this be done with data_utils.rand_uuid().","commit_id":"69413b91ea0f542f6be1197f0b983a28a411eb57"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"85cf83d60949134dbd638c10b4a0f2a13ec1aa5b","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        if filename not in self.source_files:"},{"line_number":63,"context_line":"            with open(filename) as f:"},{"line_number":64,"context_line":"                self.source_files[filename] \u003d self._quote(f.read())"},{"line_number":65,"context_line":"        patch_id \u003d uuidutils.generate_uuid()"},{"line_number":66,"context_line":"        if not patch.endswith(\u0027\\n\u0027):"},{"line_number":67,"context_line":"            patch +\u003d \u0027\\n\u0027"},{"line_number":68,"context_line":"        self.patches[patch_id] \u003d self._quote(patch)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_bf04c214","line":65,"range":{"start_line":65,"start_character":8,"end_line":65,"end_character":44},"in_reply_to":"3a71b18c_56ad5ee7","updated":"2016-12-07 09:45:38.000000000","message":"Yeah it\u0027s better to use code from oslo, that\u0027s what the openstack community agreed on. Eventually we should just remove all our use of data_utils.rand_uuid().","commit_id":"69413b91ea0f542f6be1197f0b983a28a411eb57"},{"author":{"_account_id":14867,"name":"Jaivish Kothari(janonymous)","email":"janonymous.codevulture@gmail.com","username":"Janonymous"},"change_message_id":"86f1368dc108bda8bf0708149528a32a5eb153b6","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        if filename not in self.source_files:"},{"line_number":63,"context_line":"            with open(filename) as f:"},{"line_number":64,"context_line":"                self.source_files[filename] \u003d self._quote(f.read())"},{"line_number":65,"context_line":"        patch_id \u003d uuidutils.generate_uuid()"},{"line_number":66,"context_line":"        if not patch.endswith(\u0027\\n\u0027):"},{"line_number":67,"context_line":"            patch +\u003d \u0027\\n\u0027"},{"line_number":68,"context_line":"        self.patches[patch_id] \u003d self._quote(patch)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_56ad5ee7","line":65,"range":{"start_line":65,"start_character":8,"end_line":65,"end_character":44},"in_reply_to":"3a71b18c_6ffd386d","updated":"2016-12-07 07:04:44.000000000","message":"Hi DavidPurcell,\nThanks for review, but this reason of replacement is just to use functions which are already defined in library used in tempest requirements nothing more.","commit_id":"69413b91ea0f542f6be1197f0b983a28a411eb57"},{"author":{"_account_id":23184,"name":"DavidPurcell","email":"d.purcell222@gmail.com","username":"DavidPurcell"},"change_message_id":"078be54b2b0cd586391074b4da9a815a2143741b","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        if filename not in self.source_files:"},{"line_number":63,"context_line":"            with open(filename) as f:"},{"line_number":64,"context_line":"                self.source_files[filename] \u003d self._quote(f.read())"},{"line_number":65,"context_line":"        patch_id \u003d uuidutils.generate_uuid()"},{"line_number":66,"context_line":"        if not patch.endswith(\u0027\\n\u0027):"},{"line_number":67,"context_line":"            patch +\u003d \u0027\\n\u0027"},{"line_number":68,"context_line":"        self.patches[patch_id] \u003d self._quote(patch)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_afc4825f","line":65,"range":{"start_line":65,"start_character":8,"end_line":65,"end_character":44},"in_reply_to":"3a71b18c_bf04c214","updated":"2016-12-07 16:00:02.000000000","message":"In that case I agree with this change.","commit_id":"69413b91ea0f542f6be1197f0b983a28a411eb57"}],"tempest/lib/common/utils/data_utils.py":[{"author":{"_account_id":23184,"name":"DavidPurcell","email":"d.purcell222@gmail.com","username":"DavidPurcell"},"change_message_id":"29ee5a4c104960c710f66fe605f1f2314d27701b","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    :return: a random UUID (e.g. \u00270b98cf96d90447bda4b46f31aeb1508c\u0027)"},{"line_number":41,"context_line":"    :rtype: string"},{"line_number":42,"context_line":"    \"\"\""},{"line_number":43,"context_line":"    return uuid.uuid4().hex"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"def rand_name(name\u003d\u0027\u0027, prefix\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_afd4b0eb","line":43,"range":{"start_line":43,"start_character":11,"end_line":43,"end_character":27},"updated":"2016-12-06 18:48:46.000000000","message":"This one should be updated as well, but with param Dashed\u003dFalse.","commit_id":"69413b91ea0f542f6be1197f0b983a28a411eb57"},{"author":{"_account_id":23184,"name":"DavidPurcell","email":"d.purcell222@gmail.com","username":"DavidPurcell"},"change_message_id":"078be54b2b0cd586391074b4da9a815a2143741b","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    :return: a random UUID (e.g. \u00270b98cf96d90447bda4b46f31aeb1508c\u0027)"},{"line_number":41,"context_line":"    :rtype: string"},{"line_number":42,"context_line":"    \"\"\""},{"line_number":43,"context_line":"    return uuid.uuid4().hex"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"def rand_name(name\u003d\u0027\u0027, prefix\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_8ae6d442","line":43,"range":{"start_line":43,"start_character":11,"end_line":43,"end_character":27},"in_reply_to":"3a71b18c_3699c2c4","updated":"2016-12-07 16:00:02.000000000","message":"It seems like the Dashed param is only in the master branch of oslo_utils.","commit_id":"69413b91ea0f542f6be1197f0b983a28a411eb57"},{"author":{"_account_id":14867,"name":"Jaivish Kothari(janonymous)","email":"janonymous.codevulture@gmail.com","username":"Janonymous"},"change_message_id":"86f1368dc108bda8bf0708149528a32a5eb153b6","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    :return: a random UUID (e.g. \u00270b98cf96d90447bda4b46f31aeb1508c\u0027)"},{"line_number":41,"context_line":"    :rtype: string"},{"line_number":42,"context_line":"    \"\"\""},{"line_number":43,"context_line":"    return uuid.uuid4().hex"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"def rand_name(name\u003d\u0027\u0027, prefix\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_3699c2c4","line":43,"range":{"start_line":43,"start_character":11,"end_line":43,"end_character":27},"in_reply_to":"3a71b18c_afd4b0eb","updated":"2016-12-07 07:04:44.000000000","message":"ditto.\nonly str(uuid.uuid4()) is present in oslo_utils.","commit_id":"69413b91ea0f542f6be1197f0b983a28a411eb57"}]}