)]}'
{"tempest/lib/exceptions.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"9fbd17a38be715e5dd05975a7e3d98bcc9f08c7e","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"class BadRequest(ClientRestClientException):"},{"line_number":75,"context_line":"    status_code \u003d 400"},{"line_number":76,"context_line":"    message \u003d \"Bad request\""},{"line_number":77,"context_line":""},{"line_number":78,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_0ce916b7","line":75,"range":{"start_line":75,"start_character":4,"end_line":75,"end_character":21},"updated":"2016-12-07 09:39:14.000000000","message":"But we may want to add status_code in self._error_string right?\n\nBTW restclient also send the resp and body while raising - https://github.com/openstack/tempest/blob/master/tempest/lib/common/rest_client.py#L751\n\nand error shows like below (code also)\n\nDetails: {u\u0027code\u0027: 400, u\u0027message\u0027: u\"Security Group 90ab28db-0653-43c5-91ad-9edba01337e8 in use.\\nNeutron server returns request_ids: [\u0027req-b7b534e4-1cb2-4459-8f94-cd8da88c443a\u0027]\"}","commit_id":"f8a0e12d5f364b2b7a8f1e99bb371d1f84214ec8"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"f26e05ad1b28636a28197c3136145a2c591b5c56","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"class BadRequest(ClientRestClientException):"},{"line_number":75,"context_line":"    status_code \u003d 400"},{"line_number":76,"context_line":"    message \u003d \"Bad request\""},{"line_number":77,"context_line":""},{"line_number":78,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_ac4ca29e","line":75,"range":{"start_line":75,"start_character":4,"end_line":75,"end_character":21},"in_reply_to":"3a71b18c_0ce916b7","updated":"2016-12-07 09:45:38.000000000","message":"Oh got it after looking into dependent patch.","commit_id":"f8a0e12d5f364b2b7a8f1e99bb371d1f84214ec8"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"f26e05ad1b28636a28197c3136145a2c591b5c56","unresolved":false,"context_lines":[{"line_number":148,"context_line":"    message \u003d \"HTTP response header is invalid\""},{"line_number":149,"context_line":""},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"class InvalidContentType(ClientRestClientException):"},{"line_number":152,"context_line":"    message \u003d \"Invalid content type provided\""},{"line_number":153,"context_line":""},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"class UnexpectedContentType(OtherRestClientException):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_2c7a52bd","line":152,"range":{"start_line":151,"start_character":0,"end_line":152,"end_character":45},"updated":"2016-12-07 09:45:38.000000000","message":"you should add here too 415","commit_id":"f8a0e12d5f364b2b7a8f1e99bb371d1f84214ec8"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"36627b91642cb6ddef9b73ae34c32e663b9790fa","unresolved":false,"context_lines":[{"line_number":148,"context_line":"    message \u003d \"HTTP response header is invalid\""},{"line_number":149,"context_line":""},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"class InvalidContentType(ClientRestClientException):"},{"line_number":152,"context_line":"    message \u003d \"Invalid content type provided\""},{"line_number":153,"context_line":""},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"class UnexpectedContentType(OtherRestClientException):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_6c3ef12a","line":152,"range":{"start_line":151,"start_character":0,"end_line":152,"end_character":45},"in_reply_to":"3a71b18c_2c7a52bd","updated":"2016-12-07 17:36:33.000000000","message":"Nice catch, I got it.","commit_id":"f8a0e12d5f364b2b7a8f1e99bb371d1f84214ec8"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"a88b2c04af9de7944c766f0eee562cccfae9c4ad","unresolved":false,"context_lines":[{"line_number":127,"context_line":""},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"class NotImplemented(ServerRestClientException):"},{"line_number":130,"context_line":"    status_code \u003d 501"},{"line_number":131,"context_line":"    message \u003d \"Got NotImplemented error\""},{"line_number":132,"context_line":""},{"line_number":133,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a71b18c_e10f582c","line":130,"updated":"2016-12-08 01:38:44.000000000","message":"@Jordan, we catch 501 in the current implementation[1], so, I think we don\u0027t need to make it generic \u0027500\u0027. Do I miss something?\n\n[1] https://github.com/openstack/tempest/blob/master/tempest/lib/common/rest_client.py#L822","commit_id":"2553e3bf70bac1e9647b19f77b502c8f78aa97f1"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"317de737bf0ba1749e69152ad270715ccc51f5e8","unresolved":false,"context_lines":[{"line_number":127,"context_line":""},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"class NotImplemented(ServerRestClientException):"},{"line_number":130,"context_line":"    status_code \u003d 501"},{"line_number":131,"context_line":"    message \u003d \"Got NotImplemented error\""},{"line_number":132,"context_line":""},{"line_number":133,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a71b18c_4f0da736","line":130,"updated":"2016-12-07 17:42:54.000000000","message":"You sure there\u0027s a status code for NotImplemented ? Shouldn\"t it be a generic \u0027500\u0027 ? I mean why 501 here ?","commit_id":"2553e3bf70bac1e9647b19f77b502c8f78aa97f1"}]}
