)]}'
{"tempest/test.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"430d9642f3c32939b6df9be386f6528474088d14","unresolved":false,"context_lines":[{"line_number":534,"context_line":"            return"},{"line_number":535,"context_line":""},{"line_number":536,"context_line":"        if keypair is None:"},{"line_number":537,"context_line":"            keypair \u003d CONF.validation.auth_method.lower() \u003d\u003d \"keypair\""},{"line_number":538,"context_line":""},{"line_number":539,"context_line":"        if floating_ip is None:"},{"line_number":540,"context_line":"            floating_ip \u003d CONF.validation.connect_method.lower() \u003d\u003d \"floating\""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_1a084b28","line":537,"range":{"start_line":537,"start_character":22,"end_line":537,"end_character":70},"updated":"2016-12-07 17:56:07.000000000","message":"Yeah, the original code seems redundant.\nBut current way also is a little bit too optimized (or tricky).\n\nCan we change here like\n\n keypair \u003d (CONF.validation.auth_method.lower() \u003d\u003d \"keypair\")","commit_id":"2df1bc918712802bcf403fec4bad86783c992ee1"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"3bd261d9609275354484e282a5d6d30193bfab7c","unresolved":false,"context_lines":[{"line_number":534,"context_line":"            return"},{"line_number":535,"context_line":""},{"line_number":536,"context_line":"        if keypair is None:"},{"line_number":537,"context_line":"            keypair \u003d CONF.validation.auth_method.lower() \u003d\u003d \"keypair\""},{"line_number":538,"context_line":""},{"line_number":539,"context_line":"        if floating_ip is None:"},{"line_number":540,"context_line":"            floating_ip \u003d CONF.validation.connect_method.lower() \u003d\u003d \"floating\""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_fad38f5d","line":537,"range":{"start_line":537,"start_character":22,"end_line":537,"end_character":70},"in_reply_to":"3a71b18c_1a084b28","updated":"2016-12-07 17:58:53.000000000","message":"Nope. Because that would simple ignore what the user supplied in the \u0027keypair\u0027 keyword arg. If user passes keypair\u003dFalse, then we need to honor that.","commit_id":"2df1bc918712802bcf403fec4bad86783c992ee1"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"430d9642f3c32939b6df9be386f6528474088d14","unresolved":false,"context_lines":[{"line_number":537,"context_line":"            keypair \u003d CONF.validation.auth_method.lower() \u003d\u003d \"keypair\""},{"line_number":538,"context_line":""},{"line_number":539,"context_line":"        if floating_ip is None:"},{"line_number":540,"context_line":"            floating_ip \u003d CONF.validation.connect_method.lower() \u003d\u003d \"floating\""},{"line_number":541,"context_line":""},{"line_number":542,"context_line":"        if security_group is None:"},{"line_number":543,"context_line":"            security_group \u003d CONF.validation.security_group"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_3a0d0738","line":540,"updated":"2016-12-07 17:56:07.000000000","message":"ditto","commit_id":"2df1bc918712802bcf403fec4bad86783c992ee1"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"7c2128c85bc3c733304f11d6b381744bb71d370a","unresolved":false,"context_lines":[{"line_number":537,"context_line":"            keypair \u003d (CONF.validation.auth_method.lower() \u003d\u003d \"keypair\")"},{"line_number":538,"context_line":""},{"line_number":539,"context_line":"        if floating_ip is None:"},{"line_number":540,"context_line":"            floating_ip \u003d (CONF.validation.connect_method.lower() \u003d\u003d \"floating\")"},{"line_number":541,"context_line":""},{"line_number":542,"context_line":"        if security_group is None:"},{"line_number":543,"context_line":"            security_group \u003d CONF.validation.security_group"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a71b18c_721f9b09","line":540,"updated":"2016-12-07 22:54:21.000000000","message":"Oops, sorry.\nHere is against pep8 rule:\n\n 2016-12-07 18:05:26.601602 | ./tempest/test.py:540:80: E501 line too long (80 \u003e 79 characters)\n 2016-12-07 18:05:26.601679 |             floating_ip \u003d (CONF.validation.connect_method.lower() \u003d\u003d \"floating\")","commit_id":"ee6a0c1fc52869bd7f80c98587ca8eeba4ad8c27"}]}