)]}'
{"tempest/api/volume/test_volumes_backup.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"832755d97f242d7232bf44d194534eb56bcf5597","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        if not CONF.volume_feature_enabled.backup:"},{"line_number":31,"context_line":"            raise cls.skipException(\"Cinder backup feature disabled\")"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def _backup_restore(self, backup_id):"},{"line_number":34,"context_line":"        # Restore a backup"},{"line_number":35,"context_line":"        restore \u003d self.backups_client.restore_backup("},{"line_number":36,"context_line":"            backup_id)[\u0027restore\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_2bfe6d6b","line":33,"updated":"2016-12-08 16:37:11.000000000","message":"You should rename this method to \u0027restore_backup\u0027 (also note: no underscore).","commit_id":"d59d09b12cb1986825587b51904c87ab2ed5ceae"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"c07f6314d74a64f8b41415066f871117ef25ad1b","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        if not CONF.volume_feature_enabled.backup:"},{"line_number":31,"context_line":"            raise cls.skipException(\"Cinder backup feature disabled\")"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def _backup_restore(self, backup_id):"},{"line_number":34,"context_line":"        # Restore a backup"},{"line_number":35,"context_line":"        restore \u003d self.backups_client.restore_backup("},{"line_number":36,"context_line":"            backup_id)[\u0027restore\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_6e1dc965","line":33,"in_reply_to":"3a71b18c_2bfe6d6b","updated":"2016-12-08 20:35:32.000000000","message":"Done","commit_id":"d59d09b12cb1986825587b51904c87ab2ed5ceae"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"832755d97f242d7232bf44d194534eb56bcf5597","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def _backup_restore(self, backup_id):"},{"line_number":34,"context_line":"        # Restore a backup"},{"line_number":35,"context_line":"        restore \u003d self.backups_client.restore_backup("},{"line_number":36,"context_line":"            backup_id)[\u0027restore\u0027]"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        # Delete backup"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_eb2ab5e6","line":35,"updated":"2016-12-08 16:37:11.000000000","message":"This variable should be named \"restored_volume\".","commit_id":"d59d09b12cb1986825587b51904c87ab2ed5ceae"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"c07f6314d74a64f8b41415066f871117ef25ad1b","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def _backup_restore(self, backup_id):"},{"line_number":34,"context_line":"        # Restore a backup"},{"line_number":35,"context_line":"        restore \u003d self.backups_client.restore_backup("},{"line_number":36,"context_line":"            backup_id)[\u0027restore\u0027]"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        # Delete backup"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_ae2521af","line":35,"in_reply_to":"3a71b18c_eb2ab5e6","updated":"2016-12-08 20:35:32.000000000","message":"Done","commit_id":"d59d09b12cb1986825587b51904c87ab2ed5ceae"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"832755d97f242d7232bf44d194534eb56bcf5597","unresolved":false,"context_lines":[{"line_number":111,"context_line":"        self.assertEqual(\u0027true\u0027, volume_details[\u0027bootable\u0027])"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        # Create a backup"},{"line_number":114,"context_line":"        backup_name \u003d data_utils.rand_name("},{"line_number":115,"context_line":"            self.__class__.__name__ + \u0027-Backup\u0027)"},{"line_number":116,"context_line":"        backup \u003d self.create_backup(volume_id\u003dvolume[\u0027id\u0027],"},{"line_number":117,"context_line":"                                    name\u003dbackup_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_eb78f5fa","line":114,"updated":"2016-12-08 16:37:11.000000000","message":"Why did you give the backup an explicit name ? You are not reusing the name anywhere else.","commit_id":"d59d09b12cb1986825587b51904c87ab2ed5ceae"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"c07f6314d74a64f8b41415066f871117ef25ad1b","unresolved":false,"context_lines":[{"line_number":111,"context_line":"        self.assertEqual(\u0027true\u0027, volume_details[\u0027bootable\u0027])"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        # Create a backup"},{"line_number":114,"context_line":"        backup_name \u003d data_utils.rand_name("},{"line_number":115,"context_line":"            self.__class__.__name__ + \u0027-Backup\u0027)"},{"line_number":116,"context_line":"        backup \u003d self.create_backup(volume_id\u003dvolume[\u0027id\u0027],"},{"line_number":117,"context_line":"                                    name\u003dbackup_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_8e5dc517","line":114,"in_reply_to":"3a71b18c_eb78f5fa","updated":"2016-12-08 20:35:32.000000000","message":"I\u0027m using it in L119","commit_id":"d59d09b12cb1986825587b51904c87ab2ed5ceae"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"31e7525aa1e403c4e23dce3dd65997bae232cbc9","unresolved":false,"context_lines":[{"line_number":116,"context_line":"            self.__class__.__name__ + \u0027-Backup\u0027)"},{"line_number":117,"context_line":"        backup \u003d self.create_backup(volume_id\u003dvolume[\u0027id\u0027],"},{"line_number":118,"context_line":"                                    name\u003dbackup_name)"},{"line_number":119,"context_line":"        self.assertEqual(backup_name, backup[\u0027name\u0027])"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        # Restore the backup"},{"line_number":122,"context_line":"        restored_volume_id \u003d self.restore_backup(backup[\u0027id\u0027])[\u0027volume_id\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a71b18c_c744e91c","line":119,"updated":"2016-12-09 10:28:52.000000000","message":"This assertion is already made in test test_backup_create_attached_volume and test_volume_backup_create_get_detailed_list_restore_delete, why test it another time ?","commit_id":"f0c8efec2f4413d92e2027a6d2fbaa011b71185c"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"07a05d289d8fdd9ba1bdc4a8056ce0a9893a102c","unresolved":false,"context_lines":[{"line_number":116,"context_line":"            self.__class__.__name__ + \u0027-Backup\u0027)"},{"line_number":117,"context_line":"        backup \u003d self.create_backup(volume_id\u003dvolume[\u0027id\u0027],"},{"line_number":118,"context_line":"                                    name\u003dbackup_name)"},{"line_number":119,"context_line":"        self.assertEqual(backup_name, backup[\u0027name\u0027])"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        # Restore the backup"},{"line_number":122,"context_line":"        restored_volume_id \u003d self.restore_backup(backup[\u0027id\u0027])[\u0027volume_id\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a71b18c_4bd4371f","line":119,"in_reply_to":"3a71b18c_c744e91c","updated":"2016-12-11 07:57:39.000000000","message":"Ok, I\u0027ll remove it","commit_id":"f0c8efec2f4413d92e2027a6d2fbaa011b71185c"}]}