)]}'
{"tempest/test.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"2d2cba699b528d3dbf9c8d805b152bcad7a7a445","unresolved":false,"context_lines":[{"line_number":508,"context_line":"                                      service\u003dcls._service)"},{"line_number":509,"context_line":"        # NOTE(andreaf) Ensure credentials have user and project id fields."},{"line_number":510,"context_line":"        # It may not be the case when using pre-provisioned credentials."},{"line_number":511,"context_line":"        _manager.auth_provider.set_auth()"},{"line_number":512,"context_line":"        return _manager"},{"line_number":513,"context_line":""},{"line_number":514,"context_line":"    @classmethod"},{"line_number":515,"context_line":"    def clear_credentials(cls):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_689c8f6a","line":512,"range":{"start_line":511,"start_character":0,"end_line":512,"end_character":23},"updated":"2016-12-12 02:14:42.000000000","message":"Nice. \n\nBut as credential object will be created without fill_in for pre_prov cred, it would not have project_*/tenant_* cross attr on v2/v3 cred resp. \n\nI suspected that might have causing failure for sec group tests but this job use v2 cred.\n-https://github.com/openstack/tempest/blob/master/tempest/scenario/test_security_groups_basic_ops.py#L178","commit_id":"d92d80d0549174ea51f3d45d518f419f1728ad89"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"284daf034dab4cd683ff8d8ba1e26ceab7c7c22d","unresolved":false,"context_lines":[{"line_number":508,"context_line":"                                      service\u003dcls._service)"},{"line_number":509,"context_line":"        # NOTE(andreaf) Ensure credentials have user and project id fields."},{"line_number":510,"context_line":"        # It may not be the case when using pre-provisioned credentials."},{"line_number":511,"context_line":"        _manager.auth_provider.set_auth()"},{"line_number":512,"context_line":"        return _manager"},{"line_number":513,"context_line":""},{"line_number":514,"context_line":"    @classmethod"},{"line_number":515,"context_line":"    def clear_credentials(cls):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6eadb0_14abc08a","line":512,"range":{"start_line":511,"start_character":0,"end_line":512,"end_character":23},"in_reply_to":"3a71b18c_59ef98b0","updated":"2016-12-12 23:39:20.000000000","message":"but those being set when kwargs has tenant_id and project_id etc.\n\nAnyways let\u0027s not mix those into this. may be m missing something.","commit_id":"d92d80d0549174ea51f3d45d518f419f1728ad89"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"88711c6dda7e085a88579acb4597dc9119f3c202","unresolved":false,"context_lines":[{"line_number":508,"context_line":"                                      service\u003dcls._service)"},{"line_number":509,"context_line":"        # NOTE(andreaf) Ensure credentials have user and project id fields."},{"line_number":510,"context_line":"        # It may not be the case when using pre-provisioned credentials."},{"line_number":511,"context_line":"        _manager.auth_provider.set_auth()"},{"line_number":512,"context_line":"        return _manager"},{"line_number":513,"context_line":""},{"line_number":514,"context_line":"    @classmethod"},{"line_number":515,"context_line":"    def clear_credentials(cls):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_59ef98b0","line":512,"range":{"start_line":511,"start_character":0,"end_line":512,"end_character":23},"in_reply_to":"3a71b18c_689c8f6a","updated":"2016-12-12 11:08:00.000000000","message":"The credentials object should have both tenant_id and project_id because of the way the Credentials class works. However the scenario tests class looks for credentials from manager.credentials, and those credentials are not filled in. I think it\u0027s not a valid assumption that the credentials in the manager will have the IDs set so that should be fixed in the scenario tests.","commit_id":"d92d80d0549174ea51f3d45d518f419f1728ad89"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"fa60d1c209c79e0b46f62ad75cce91a5fafabe28","unresolved":false,"context_lines":[{"line_number":504,"context_line":"            else:"},{"line_number":505,"context_line":"                raise lib_exc.InvalidCredentials("},{"line_number":506,"context_line":"                    \"Invalid credentials type %s\" % credential_type)"},{"line_number":507,"context_line":"        _manager \u003d cls.client_manager(credentials\u003dcreds.credentials,"},{"line_number":508,"context_line":"                                      service\u003dcls._service)"},{"line_number":509,"context_line":"        # NOTE(andreaf) Ensure credentials have user and project id fields."},{"line_number":510,"context_line":"        # It may not be the case when using pre-provisioned credentials."}],"source_content_type":"text/x-python","patch_set":2,"id":"3a71b18c_9d3d992d","line":507,"updated":"2016-12-12 11:47:19.000000000","message":"Any reason why you had to prefix this with an \u0027_\u0027  ?","commit_id":"37fcea21aad39c545e864b3181756da6c8b9bfa0"}]}