)]}'
{"tempest/api/compute/volumes/test_attach_volume.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"dcb3ef6a3c32216db7b82292fa85208fdb1553c6","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    def _detach_volume(self, server_id, volume_id):"},{"line_number":65,"context_line":"        test_utils.call_and_ignore_notfound_exc("},{"line_number":66,"context_line":"            self.servers_client.detach_volume, server_id, volume_id)"},{"line_number":67,"context_line":"        waiters.wait_for_volume_status(self.volumes_client,"},{"line_number":68,"context_line":"                                       volume_id, \u0027available\u0027)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    def _attach_volume(self, server_id, volume_id, device\u003dNone):"},{"line_number":71,"context_line":"        # Attach the volume to the server"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6eadb0_a62bb42f","line":68,"range":{"start_line":67,"start_character":0,"end_line":68,"end_character":62},"updated":"2016-12-13 08:57:15.000000000","message":"actually NotFound can be raised in multiple scenario like if volume also not found. So we should have both these operation under NotFound ignore.\n\nI will suggest current code is ok.","commit_id":"bf0c003d2f5692c1ae2b0ecc918d69f3bb95df7d"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"693e25e445f18859e754ec017314b1d5dfe67ba6","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    def _detach_volume(self, server_id, volume_id):"},{"line_number":65,"context_line":"        test_utils.call_and_ignore_notfound_exc("},{"line_number":66,"context_line":"            self.servers_client.detach_volume, server_id, volume_id)"},{"line_number":67,"context_line":"        waiters.wait_for_volume_status(self.volumes_client,"},{"line_number":68,"context_line":"                                       volume_id, \u0027available\u0027)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    def _attach_volume(self, server_id, volume_id, device\u003dNone):"},{"line_number":71,"context_line":"        # Attach the volume to the server"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6eadb0_a37721d3","line":68,"range":{"start_line":67,"start_character":0,"end_line":68,"end_character":62},"in_reply_to":"1a6eadb0_a62bb42f","updated":"2016-12-13 10:19:42.000000000","message":"Hi Ghanshyam ,\nThe current detach will ignore exceptions.NotFound , What do you suggest ? can you please share ?\n\nBenny","commit_id":"bf0c003d2f5692c1ae2b0ecc918d69f3bb95df7d"}]}