)]}'
{"etc/tempest.conf.sample":[{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"34de9af69096e7404224a4abd3eff48a25bf125a","unresolved":false,"context_lines":[{"line_number":134,"context_line":"# The name of a region for compute. If empty or commented-out, the value of"},{"line_number":135,"context_line":"# identity.region is used instead. If no such region is found in the service"},{"line_number":136,"context_line":"# catalog, the first found one is used."},{"line_number":137,"context_line":"region \u003d RegionOne"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"# Does the Compute API support creation of images?"},{"line_number":140,"context_line":"create_image_enabled \u003d true"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"AAAAS3%2F%2F8fY%3D","line":137,"updated":"2013-09-16 19:17:53.000000000","message":"I wonder wouldn\u0027t be better to use commented regions for the other services ?\n \u0027#region \u003d RegionOne\u0027\n(without space after the #)","commit_id":"5b5ba602f760256a45cf53fd28ea66a66ff8d384"},{"author":{"_account_id":1192,"name":"David Kranz","email":"dkranz@redhat.com","username":"david-kranz"},"change_message_id":"fd0d34b306436d82905260bbf0d8214eca34e06f","unresolved":false,"context_lines":[{"line_number":134,"context_line":"# The name of a region for compute. If empty or commented-out, the value of"},{"line_number":135,"context_line":"# identity.region is used instead. If no such region is found in the service"},{"line_number":136,"context_line":"# catalog, the first found one is used."},{"line_number":137,"context_line":"region \u003d RegionOne"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"# Does the Compute API support creation of images?"},{"line_number":140,"context_line":"create_image_enabled \u003d true"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"AAAAS3%2F%2F8bA%3D","line":137,"in_reply_to":"AAAAS3%2F%2F8fY%3D","updated":"2013-09-16 19:43:22.000000000","message":"We don\u0027t have a lot of commented out values. I think this is OK as is and this patch has been waiting since Aug 9.","commit_id":"5b5ba602f760256a45cf53fd28ea66a66ff8d384"}],"tempest/common/rest_client.py":[{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"f547904a100121b1e2ad243538e98134b6197f61","unresolved":false,"context_lines":[{"line_number":57,"context_line":"            if not catalog_type:"},{"line_number":58,"context_line":"                continue"},{"line_number":59,"context_line":"            service_region \u003d self.config.identity.region"},{"line_number":60,"context_line":"            self.region[catalog_type] \u003d service_region"},{"line_number":61,"context_line":"        self.endpoint_url \u003d \u0027publicURL\u0027"},{"line_number":62,"context_line":"        self.headers \u003d {\u0027Content-Type\u0027: \u0027application/%s\u0027 % self.TYPE,"},{"line_number":63,"context_line":"                        \u0027Accept\u0027: \u0027application/%s\u0027 % self.TYPE}"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAQ3%2F%2F6NQ%3D","line":60,"updated":"2013-08-13 05:30:27.000000000","message":"So setting an entry in identity.region will now register the region to all services. There is no way to change the region for any service. Why not get the region directly out of identity.region instead of using this dict at all?","commit_id":"a67115c26fe54d9d70d0bdf8d8d6d3c47d049d0f"},{"author":{"_account_id":3068,"name":"Arata Notsu","email":"notsu@virtualtech.jp","username":"arata776"},"change_message_id":"20569dc2e3de33bc04bcc3d03b987fb8e295bf33","unresolved":false,"context_lines":[{"line_number":57,"context_line":"            if not catalog_type:"},{"line_number":58,"context_line":"                continue"},{"line_number":59,"context_line":"            service_region \u003d self.config.identity.region"},{"line_number":60,"context_line":"            self.region[catalog_type] \u003d service_region"},{"line_number":61,"context_line":"        self.endpoint_url \u003d \u0027publicURL\u0027"},{"line_number":62,"context_line":"        self.headers \u003d {\u0027Content-Type\u0027: \u0027application/%s\u0027 % self.TYPE,"},{"line_number":63,"context_line":"                        \u0027Accept\u0027: \u0027application/%s\u0027 % self.TYPE}"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAARH%2F%2F5Z4%3D","line":60,"in_reply_to":"AAAAQ3%2F%2F6NQ%3D","updated":"2013-08-15 15:40:35.000000000","message":"I suppose using the dict is to allow RestClient\u0027s subclasses to control the selection of the target endpoint by changing the dict members. I would like to leave this behavior unchanged just because this patch is not focusing on changing this behavior.","commit_id":"a67115c26fe54d9d70d0bdf8d8d6d3c47d049d0f"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"a86a9f8e78946e0a3ebd5c74a90eaeef505c11f6","unresolved":false,"context_lines":[{"line_number":57,"context_line":"            if not catalog_type:"},{"line_number":58,"context_line":"                continue"},{"line_number":59,"context_line":"            service_region \u003d self.config.identity.region"},{"line_number":60,"context_line":"            self.region[catalog_type] \u003d service_region"},{"line_number":61,"context_line":"        self.endpoint_url \u003d \u0027publicURL\u0027"},{"line_number":62,"context_line":"        self.headers \u003d {\u0027Content-Type\u0027: \u0027application/%s\u0027 % self.TYPE,"},{"line_number":63,"context_line":"                        \u0027Accept\u0027: \u0027application/%s\u0027 % self.TYPE}"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAARH%2F%2F2EQ%3D","line":60,"in_reply_to":"AAAARH%2F%2F2ZM%3D","updated":"2013-08-16 11:41:20.000000000","message":"Just to be more precise on that - IMHO the dict can be useful and your patch is useful if it\u0027s used. I think my confusion is more due to a terminology thing since the configured region becomes a \"default\" region. I think you could solve that with just a comment for what this dict can be used in the future.","commit_id":"a67115c26fe54d9d70d0bdf8d8d6d3c47d049d0f"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"629999dda10a9721a93a2b8c9f0c4ca136f0f6c1","unresolved":false,"context_lines":[{"line_number":57,"context_line":"            if not catalog_type:"},{"line_number":58,"context_line":"                continue"},{"line_number":59,"context_line":"            service_region \u003d self.config.identity.region"},{"line_number":60,"context_line":"            self.region[catalog_type] \u003d service_region"},{"line_number":61,"context_line":"        self.endpoint_url \u003d \u0027publicURL\u0027"},{"line_number":62,"context_line":"        self.headers \u003d {\u0027Content-Type\u0027: \u0027application/%s\u0027 % self.TYPE,"},{"line_number":63,"context_line":"                        \u0027Accept\u0027: \u0027application/%s\u0027 % self.TYPE}"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAARH%2F%2F2ZM%3D","line":60,"in_reply_to":"AAAARH%2F%2F5Z4%3D","updated":"2013-08-16 09:27:44.000000000","message":"For me this no really obvious. In the config you can configure only one region and now it\u0027s assigned to all services and this can be manipulated but only in the code and not from configuration. Could you point me an example where this dict is used? I only see it inside the RestClient.","commit_id":"a67115c26fe54d9d70d0bdf8d8d6d3c47d049d0f"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"35dd095bb8176022f28148c2944f8c99d48a6dc7","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        self.service \u003d None"},{"line_number":50,"context_line":"        self.token \u003d None"},{"line_number":51,"context_line":"        self.base_url \u003d None"},{"line_number":52,"context_line":"        self.region \u003d {}"},{"line_number":53,"context_line":"        for cfgname in dir(self.config):"},{"line_number":54,"context_line":"            # Find all config.FOO.catalog_type and assume FOO is a service"},{"line_number":55,"context_line":"            cfg \u003d getattr(self.config, cfgname)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FEKA%3D","line":52,"updated":"2013-09-12 16:45:45.000000000","message":"I would prefer to keep the default of using the identity region. That way, if you reach a continue below, you will still have the region set to something...","commit_id":"f137a89e7e67776273cf972b3a91a77d8bb90f5c"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"a6c7301e5eebfeb359d9a0eba9db18bf4cab301a","unresolved":false,"context_lines":[{"line_number":58,"context_line":"                continue"},{"line_number":59,"context_line":"            service_region \u003d getattr(cfg, \u0027region\u0027, None)"},{"line_number":60,"context_line":"            if not service_region:"},{"line_number":61,"context_line":"                service_region \u003d self.config.identity.region"},{"line_number":62,"context_line":"            self.region[catalog_type] \u003d service_region"},{"line_number":63,"context_line":"        self.endpoint_url \u003d \u0027publicURL\u0027"},{"line_number":64,"context_line":"        self.headers \u003d {\u0027Content-Type\u0027: \u0027application/%s\u0027 % self.TYPE,"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAASn%2F%2FAgw%3D","line":61,"updated":"2013-09-13 16:17:45.000000000","message":"This is fine. Also note you can also do:\n\n service_region \u003d getattr(cfg, \u0027region\u0027, self.config.identity.region)\n\nto accomplish the same thing in a shorter format.","commit_id":"5b5ba602f760256a45cf53fd28ea66a66ff8d384"}]}