)]}'
{"tempest/scenario/test_volume_boot_pattern.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"95af02bd30ebb809ec97e59ba33185d5013f04ea","unresolved":false,"context_lines":[{"line_number":180,"context_line":"        # boot instance from EBS image"},{"line_number":181,"context_line":"        instance \u003d self.create_server("},{"line_number":182,"context_line":"            image_id\u003dimage[\u0027id\u0027],"},{"line_number":183,"context_line":"            wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":184,"context_line":"        # just ensure that instance booted"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"        # delete instance"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a6eadb0_a29fe4b2","line":183,"updated":"2016-12-14 09:33:02.000000000","message":"Please add a code comment just before that line to justify why we need to wait in that case.","commit_id":"94eeb9d89362c10a5c947e29990da7d1e358314b"},{"author":{"_account_id":10224,"name":"Feodor Tersin","email":"ftersin@hotmail.com","username":"ftersin"},"change_message_id":"887b52d7e37e8ea836c41fd5b67b28a5f5309ee7","unresolved":false,"context_lines":[{"line_number":180,"context_line":"        # boot instance from EBS image"},{"line_number":181,"context_line":"        instance \u003d self.create_server("},{"line_number":182,"context_line":"            image_id\u003dimage[\u0027id\u0027],"},{"line_number":183,"context_line":"            wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":184,"context_line":"        # just ensure that instance booted"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"        # delete instance"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a6eadb0_aee18bd2","line":183,"in_reply_to":"1a6eadb0_a29fe4b2","updated":"2016-12-14 10:50:45.000000000","message":"Done.\n\nThe comment is probably too long, i\u0027d be glad if you help me to reduce it.","commit_id":"94eeb9d89362c10a5c947e29990da7d1e358314b"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"f52e401d42f76050cdfcea267ea5653baf98237a","unresolved":false,"context_lines":[{"line_number":187,"context_line":"            # on bdm stage (which creation may continue to work inside Cinder"},{"line_number":188,"context_line":"            # backend despite the instance has been terminated) and the source"},{"line_number":189,"context_line":"            # snapshot deletion during test cleanup."},{"line_number":190,"context_line":"            wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":191,"context_line":"        # just ensure that instance booted"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"        # delete instance"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a6eadb0_9927b7b5","line":190,"updated":"2016-12-14 10:59:52.000000000","message":"You are just hiding a potential race condition by expecting the client (here Tempest) to wait nicely and be polite. The best fix will be to fix Cinder or your storage backend so that the snapshot deletion is properly handled.\nI am not going to +2 this, but not -1 either.","commit_id":"0ec36d9c0cf0f82b4ebba7aeb3597e7dcd7956bc"}]}