)]}'
{"tempest/api/volume/base.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"41db4aa9fb681042cf0c5c36c4a3499052cf6d49","unresolved":false,"context_lines":[{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    def attach_volume(self, server_id, volume_id, device\u003dNone):"},{"line_number":175,"context_line":"        \"\"\"Attachs a volume to a server\"\"\""},{"line_number":176,"context_line":"        if device is None:"},{"line_number":177,"context_line":"            device \u003d \u0027/dev/%s\u0027 % CONF.compute.volume_device_name"},{"line_number":178,"context_line":"        self.servers_client.attach_volume("},{"line_number":179,"context_line":"            server_id, volumeId\u003dvolume_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6eadb0_392f1aa2","line":176,"range":{"start_line":176,"start_character":8,"end_line":176,"end_character":26},"updated":"2016-12-16 07:57:06.000000000","message":"actually device is optional to pass in nova attach request. if you are making device optional in args then it this function should not to pass device to attach API if it is None and tests using this function can pass their device.\n\nOnly use case for making device optional is if any tests want to tests attach volume without passing device but it would not happen with this code.\n\nI suggest \n- Either leave device setting as it is or\n- Set only if it is not None and pass device name from all existing tests and new tests with no device.\n\nI prefer the first one as we already have compute tests without passing device. Same can be done if there is any specific tests in volume want to do so.","commit_id":"80b179c45b7cc67e19a7aaea5cef81f226caae4a"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"41db4aa9fb681042cf0c5c36c4a3499052cf6d49","unresolved":false,"context_lines":[{"line_number":183,"context_line":"        self.addCleanup(waiters.wait_for_volume_status, self.volumes_client,"},{"line_number":184,"context_line":"                        volume_id, \u0027available\u0027)"},{"line_number":185,"context_line":"        self.addCleanup(self.servers_client.detach_volume, server_id,"},{"line_number":186,"context_line":"                        volume_id)"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    @classmethod"},{"line_number":189,"context_line":"    def clear_volumes(cls):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6eadb0_991e6e6e","line":186,"range":{"start_line":186,"start_character":24,"end_line":186,"end_character":33},"updated":"2016-12-16 07:57:06.000000000","message":"nice.","commit_id":"80b179c45b7cc67e19a7aaea5cef81f226caae4a"}]}