)]}'
{"tempest/api/object_storage/base.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"af668ac7f168e221fedd0e74ec387c8b4a7a45f4","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    :param object_client: Client to be used to delete objects"},{"line_number":42,"context_line":"    \"\"\""},{"line_number":43,"context_line":"    for cont in containers:"},{"line_number":44,"context_line":"        try:"},{"line_number":45,"context_line":"            params \u003d {\u0027limit\u0027: 9999, \u0027format\u0027: \u0027json\u0027}"},{"line_number":46,"context_line":"            resp, objlist \u003d container_client.list_container_contents("},{"line_number":47,"context_line":"                cont, params)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_d0ba3d71","line":44,"range":{"start_line":44,"start_character":0,"end_line":44,"end_character":12},"updated":"2016-12-19 00:56:54.000000000","message":"it is better to move this \"try\" to line55 after time.sleep() because the delete_object() is already wrapped with call_and_ignore_notfound_exc..","commit_id":"2abcc2ab5670e9258196dcc56f06f7cb684a5051"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"35d6e8488f3748a3831e82c502d808d4d0763999","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    :param object_client: Client to be used to delete objects"},{"line_number":42,"context_line":"    \"\"\""},{"line_number":43,"context_line":"    for cont in containers:"},{"line_number":44,"context_line":"        try:"},{"line_number":45,"context_line":"            params \u003d {\u0027limit\u0027: 9999, \u0027format\u0027: \u0027json\u0027}"},{"line_number":46,"context_line":"            resp, objlist \u003d container_client.list_container_contents("},{"line_number":47,"context_line":"                cont, params)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_2e0948de","line":44,"range":{"start_line":44,"start_character":0,"end_line":44,"end_character":12},"in_reply_to":"1a6eadb0_d0ba3d71","updated":"2016-12-19 08:35:41.000000000","message":"Sure I could to that, but I don\u0027t think it would be in scope of this patch, I just moved the original code to a separate method.","commit_id":"2abcc2ab5670e9258196dcc56f06f7cb684a5051"}],"tempest/api/object_storage/test_account_bulk.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"216ccb007676c8a51eeb2a9afa10ca632838f29f","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class BulkTest(base.BaseObjectTest):"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    def delete_containers(self):"},{"line_number":26,"context_line":"        # NOTE(andreaf) BulkTests needs to cleanup containers after each"},{"line_number":27,"context_line":"        # test is executed. To achieve that override the delete_containers"},{"line_number":28,"context_line":"        # from the base class to use self.containers (not cls.containers)."}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_b425950b","line":25,"updated":"2016-12-19 15:35:43.000000000","message":"Why do you have to overwrite this method. BulkTest inherits from BaseObjectTest, so delete_containers() should be available already.","commit_id":"2abcc2ab5670e9258196dcc56f06f7cb684a5051"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"d65c27c6849520ecaf4a26da1cd213ef70e31812","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class BulkTest(base.BaseObjectTest):"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    def delete_containers(self):"},{"line_number":26,"context_line":"        # NOTE(andreaf) BulkTests needs to cleanup containers after each"},{"line_number":27,"context_line":"        # test is executed. To achieve that override the delete_containers"},{"line_number":28,"context_line":"        # from the base class to use self.containers (not cls.containers)."}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_96715847","line":25,"in_reply_to":"1a6eadb0_0989cfca","updated":"2016-12-20 09:28:39.000000000","message":"My concern here is that we now have 3 callables \u0027delete_containers\u0027 (function, static method, instance method). It\u0027s too tricky.\n\nMaybe remove this one and replace L39 with:\n  base.delete_containers(self.containers, self.container_client, self.object_client)","commit_id":"2abcc2ab5670e9258196dcc56f06f7cb684a5051"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"1dfdc685b062dd6af22bf023fc753dbb6bf532b7","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class BulkTest(base.BaseObjectTest):"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    def delete_containers(self):"},{"line_number":26,"context_line":"        # NOTE(andreaf) BulkTests needs to cleanup containers after each"},{"line_number":27,"context_line":"        # test is executed. To achieve that override the delete_containers"},{"line_number":28,"context_line":"        # from the base class to use self.containers (not cls.containers)."}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_8228ff34","line":25,"in_reply_to":"1a6eadb0_96715847","updated":"2016-12-21 08:46:39.000000000","message":"yeah sounds good","commit_id":"2abcc2ab5670e9258196dcc56f06f7cb684a5051"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"12ffeed929ec3f261d552f67f34b11943b787abb","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class BulkTest(base.BaseObjectTest):"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    def delete_containers(self):"},{"line_number":26,"context_line":"        # NOTE(andreaf) BulkTests needs to cleanup containers after each"},{"line_number":27,"context_line":"        # test is executed. To achieve that override the delete_containers"},{"line_number":28,"context_line":"        # from the base class to use self.containers (not cls.containers)."}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_0989cfca","line":25,"in_reply_to":"1a6eadb0_b425950b","updated":"2016-12-19 16:51:03.000000000","message":"delete_containers in the base class is designed for use with class fixtures, and it uses cls.containers.\n\nThis test stores the list of containers in self.containers instead. Instead of this I could update tearDown instead, we do not really need the extra helper.","commit_id":"2abcc2ab5670e9258196dcc56f06f7cb684a5051"}]}