)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"7607171ea19c5fc8919942c681f80b48f2cfd2b1","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2017-01-05 19:12:47 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"add cleanup to volume created from image"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ib89f13b5271041a684ffb12ef668c6226bdd2859"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ba5201f7_389d780a","line":8,"updated":"2017-01-05 23:44:47.000000000","message":"It would be nice to write the reason why we need to a dd this cleanup even though create_volume() registers the same thing at the end of test.","commit_id":"db70480c4fb09191f302445547a4a6400f5e1845"}],"tempest/api/volume/test_volumes_backup.py":[{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"474ec12697eb8016990d987fa774715d58bdbfbf","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        # Create volume from image"},{"line_number":110,"context_line":"        img_uuid \u003d CONF.compute.image_ref"},{"line_number":111,"context_line":"        volume \u003d self.create_volume(imageRef\u003dimg_uuid)"},{"line_number":112,"context_line":"        self.addCleanup(self.volumes_client.delete_volume,"},{"line_number":113,"context_line":"                        volume[\u0027id\u0027])"},{"line_number":114,"context_line":"        volume_details \u003d self.volumes_client.show_volume("},{"line_number":115,"context_line":"            volume[\u0027id\u0027])[\u0027volume\u0027]"},{"line_number":116,"context_line":"        self.assertEqual(\u0027true\u0027, volume_details[\u0027bootable\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"da4df55a_1679f9fc","line":113,"range":{"start_line":112,"start_character":0,"end_line":113,"end_character":37},"updated":"2016-12-22 14:43:34.000000000","message":"Volumes are already scheduled for cleanup by the create_volume, however the create volume will only kick in at the end of the test class.\nI do prefer this type of cleanup, however it should than wait for deletion as well.\nAs it is, it solves no issue (cleanup is done already) and it does not introduce a new proper cleanup.","commit_id":"cf64ff193f511fef2f85ff5b8067e6ef3421d362"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"e531627ab49591113a86c4f8ae56c02f961069a5","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        # Create volume from image"},{"line_number":110,"context_line":"        img_uuid \u003d CONF.compute.image_ref"},{"line_number":111,"context_line":"        volume \u003d self.create_volume(imageRef\u003dimg_uuid)"},{"line_number":112,"context_line":"        self.addCleanup(self.volumes_client.delete_volume,"},{"line_number":113,"context_line":"                        volume[\u0027id\u0027])"},{"line_number":114,"context_line":"        volume_details \u003d self.volumes_client.show_volume("},{"line_number":115,"context_line":"            volume[\u0027id\u0027])[\u0027volume\u0027]"},{"line_number":116,"context_line":"        self.assertEqual(\u0027true\u0027, volume_details[\u0027bootable\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5201f7_f0866012","line":113,"range":{"start_line":112,"start_character":8,"end_line":113,"end_character":37},"updated":"2016-12-29 03:34:48.000000000","message":"you can use self.addCleanup(self.delete_volume, volume[\u0027id\u0027]) here, which will wait for volume deletion.","commit_id":"cf64ff193f511fef2f85ff5b8067e6ef3421d362"},{"author":{"_account_id":13047,"name":"Isaac Beckman","email":"beckmani@gmail.com","username":"isaacb"},"change_message_id":"ed6d4d79023bf9b3e6d72e5c72ce6e01b86ce050","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        # Create volume from image"},{"line_number":110,"context_line":"        img_uuid \u003d CONF.compute.image_ref"},{"line_number":111,"context_line":"        volume \u003d self.create_volume(imageRef\u003dimg_uuid)"},{"line_number":112,"context_line":"        self.addCleanup(self.volumes_client.delete_volume,"},{"line_number":113,"context_line":"                        volume[\u0027id\u0027])"},{"line_number":114,"context_line":"        volume_details \u003d self.volumes_client.show_volume("},{"line_number":115,"context_line":"            volume[\u0027id\u0027])[\u0027volume\u0027]"},{"line_number":116,"context_line":"        self.assertEqual(\u0027true\u0027, volume_details[\u0027bootable\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5201f7_f00a3c89","line":113,"range":{"start_line":112,"start_character":8,"end_line":113,"end_character":37},"in_reply_to":"ba5201f7_f0866012","updated":"2017-01-05 14:34:05.000000000","message":"Done","commit_id":"cf64ff193f511fef2f85ff5b8067e6ef3421d362"},{"author":{"_account_id":13047,"name":"Isaac Beckman","email":"beckmani@gmail.com","username":"isaacb"},"change_message_id":"f0ae18471eea60dce8d389c08613992e292a2c7d","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        # Create volume from image"},{"line_number":110,"context_line":"        img_uuid \u003d CONF.compute.image_ref"},{"line_number":111,"context_line":"        volume \u003d self.create_volume(imageRef\u003dimg_uuid)"},{"line_number":112,"context_line":"        self.addCleanup(self.volumes_client.delete_volume,"},{"line_number":113,"context_line":"                        volume[\u0027id\u0027])"},{"line_number":114,"context_line":"        volume_details \u003d self.volumes_client.show_volume("},{"line_number":115,"context_line":"            volume[\u0027id\u0027])[\u0027volume\u0027]"},{"line_number":116,"context_line":"        self.assertEqual(\u0027true\u0027, volume_details[\u0027bootable\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"da4df55a_965be02d","line":113,"range":{"start_line":112,"start_character":0,"end_line":113,"end_character":37},"in_reply_to":"da4df55a_1679f9fc","updated":"2016-12-25 09:02:39.000000000","message":"Andrea thanks for your comment.\nI understand that create_volume should trigger cleanup at the end of the test class.\nI also saw on my environment that there is 1 volume created by this test case that is not cleaned up.\nMoreover, any call to create_volume within this class is always followed by addcleanup (see lines  53, 88)","commit_id":"cf64ff193f511fef2f85ff5b8067e6ef3421d362"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"7607171ea19c5fc8919942c681f80b48f2cfd2b1","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        # Create volume from image"},{"line_number":110,"context_line":"        img_uuid \u003d CONF.compute.image_ref"},{"line_number":111,"context_line":"        volume \u003d self.create_volume(imageRef\u003dimg_uuid)"},{"line_number":112,"context_line":"        self.addCleanup(self.delete_volume, self.volumes_client, volume[\u0027id\u0027])"},{"line_number":113,"context_line":"        volume_details \u003d self.volumes_client.show_volume("},{"line_number":114,"context_line":"            volume[\u0027id\u0027])[\u0027volume\u0027]"},{"line_number":115,"context_line":"        self.assertEqual(\u0027true\u0027, volume_details[\u0027bootable\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba5201f7_f864d022","line":112,"updated":"2017-01-05 23:44:47.000000000","message":"The NOTE also could be helpful in long-term maintenance.","commit_id":"db70480c4fb09191f302445547a4a6400f5e1845"}]}