)]}'
{"tempest/lib/services/identity/v2/token_client.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"2ae4392251e5b809bb5bea3d188768d07c824ed7","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        \"\"\""},{"line_number":36,"context_line":"        dscv \u003d disable_ssl_certificate_validation"},{"line_number":37,"context_line":"        for unwanted_kwargs in [\u0027region\u0027, \u0027service\u0027, \u0027auth_provider\u0027]:"},{"line_number":38,"context_line":"            kwargs.pop(unwanted_kwargs, None)"},{"line_number":39,"context_line":"        super(TokenClient, self).__init__("},{"line_number":40,"context_line":"            None, None, None, disable_ssl_certificate_validation\u003ddscv,"},{"line_number":41,"context_line":"            ca_certs\u003dca_certs, trace_requests\u003dtrace_requests, **kwargs)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5201f7_120eef3a","line":38,"range":{"start_line":38,"start_character":12,"end_line":38,"end_character":45},"updated":"2017-01-11 23:28:02.000000000","message":"It would be nice to put some NOTE here for explaining why we need to remove them.","commit_id":"498baba831f3f4253c2e929db5ad9460a0e28665"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"213c5ffc7d6db7e1bfd520f4fea7ce305b577380","unresolved":false,"context_lines":[{"line_number":34,"context_line":"               as they are not meaningful for token client"},{"line_number":35,"context_line":"        \"\"\""},{"line_number":36,"context_line":"        dscv \u003d disable_ssl_certificate_validation"},{"line_number":37,"context_line":"        for unwanted_kwargs in [\u0027region\u0027, \u0027service\u0027, \u0027auth_provider\u0027]:"},{"line_number":38,"context_line":"            kwargs.pop(unwanted_kwargs, None)"},{"line_number":39,"context_line":"        super(TokenClient, self).__init__("},{"line_number":40,"context_line":"            None, None, None, disable_ssl_certificate_validation\u003ddscv,"},{"line_number":41,"context_line":"            ca_certs\u003dca_certs, trace_requests\u003dtrace_requests, **kwargs)"}],"source_content_type":"text/x-python","patch_set":3,"id":"da4df55a_3ba09d9f","line":38,"range":{"start_line":37,"start_character":0,"end_line":38,"end_character":45},"updated":"2016-12-22 17:03:31.000000000","message":"this might be implemented as a decorator.","commit_id":"498baba831f3f4253c2e929db5ad9460a0e28665"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"390b7549140f43880c930276be31b28607c7a5bf","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        \"\"\""},{"line_number":36,"context_line":"        dscv \u003d disable_ssl_certificate_validation"},{"line_number":37,"context_line":"        for unwanted_kwargs in [\u0027region\u0027, \u0027service\u0027, \u0027auth_provider\u0027]:"},{"line_number":38,"context_line":"            kwargs.pop(unwanted_kwargs, None)"},{"line_number":39,"context_line":"        super(TokenClient, self).__init__("},{"line_number":40,"context_line":"            None, None, None, disable_ssl_certificate_validation\u003ddscv,"},{"line_number":41,"context_line":"            ca_certs\u003dca_certs, trace_requests\u003dtrace_requests, **kwargs)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a3c09a3_58d57941","line":38,"range":{"start_line":38,"start_character":12,"end_line":38,"end_character":45},"in_reply_to":"9a57fde8_43ff6634","updated":"2017-01-13 13:28:03.000000000","message":"Yes, you may get duplicate parameter error","commit_id":"498baba831f3f4253c2e929db5ad9460a0e28665"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"11013c0c39827507dd22284e3305c4c594d0e871","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        \"\"\""},{"line_number":36,"context_line":"        dscv \u003d disable_ssl_certificate_validation"},{"line_number":37,"context_line":"        for unwanted_kwargs in [\u0027region\u0027, \u0027service\u0027, \u0027auth_provider\u0027]:"},{"line_number":38,"context_line":"            kwargs.pop(unwanted_kwargs, None)"},{"line_number":39,"context_line":"        super(TokenClient, self).__init__("},{"line_number":40,"context_line":"            None, None, None, disable_ssl_certificate_validation\u003ddscv,"},{"line_number":41,"context_line":"            ca_certs\u003dca_certs, trace_requests\u003dtrace_requests, **kwargs)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a57fde8_43ff6634","line":38,"range":{"start_line":38,"start_character":12,"end_line":38,"end_character":45},"in_reply_to":"ba5201f7_120eef3a","updated":"2017-01-12 09:45:51.000000000","message":"Also, what happens if we don\"t pop those kwargs ? The instantiation fails ?","commit_id":"498baba831f3f4253c2e929db5ad9460a0e28665"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"390b7549140f43880c930276be31b28607c7a5bf","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        \"\"\""},{"line_number":36,"context_line":"        dscv \u003d disable_ssl_certificate_validation"},{"line_number":37,"context_line":"        for unwanted_kwargs in [\u0027region\u0027, \u0027service\u0027, \u0027auth_provider\u0027]:"},{"line_number":38,"context_line":"            kwargs.pop(unwanted_kwargs, None)"},{"line_number":39,"context_line":"        super(TokenClient, self).__init__("},{"line_number":40,"context_line":"            None, None, None, disable_ssl_certificate_validation\u003ddscv,"},{"line_number":41,"context_line":"            ca_certs\u003dca_certs, trace_requests\u003dtrace_requests, **kwargs)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a3c09a3_98f8c1e7","line":38,"range":{"start_line":38,"start_character":12,"end_line":38,"end_character":45},"in_reply_to":"ba5201f7_120eef3a","updated":"2017-01-13 13:28:03.000000000","message":"Yeah, that note is in L33 and L34","commit_id":"498baba831f3f4253c2e929db5ad9460a0e28665"}],"tempest/lib/services/identity/v3/token_client.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"2ae4392251e5b809bb5bea3d188768d07c824ed7","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        \"\"\""},{"line_number":36,"context_line":"        dscv \u003d disable_ssl_certificate_validation"},{"line_number":37,"context_line":"        for unwanted_kwargs in [\u0027region\u0027, \u0027service\u0027, \u0027auth_provider\u0027]:"},{"line_number":38,"context_line":"            kwargs.pop(unwanted_kwargs, None)"},{"line_number":39,"context_line":"        super(V3TokenClient, self).__init__("},{"line_number":40,"context_line":"            None, None, None, disable_ssl_certificate_validation\u003ddscv,"},{"line_number":41,"context_line":"            ca_certs\u003dca_certs, trace_requests\u003dtrace_requests, **kwargs)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5201f7_5204f716","line":38,"range":{"start_line":38,"start_character":12,"end_line":38,"end_character":45},"updated":"2017-01-11 23:28:02.000000000","message":"ditto","commit_id":"498baba831f3f4253c2e929db5ad9460a0e28665"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"6daac11545f05ce62875d9dde62c67c6536cf559","unresolved":false,"context_lines":[{"line_number":34,"context_line":"               as they are not meaningful for token client"},{"line_number":35,"context_line":"        \"\"\""},{"line_number":36,"context_line":"        dscv \u003d disable_ssl_certificate_validation"},{"line_number":37,"context_line":"        for unwanted_kwargs in [\u0027region\u0027, \u0027service\u0027, \u0027auth_provider\u0027]:"},{"line_number":38,"context_line":"            kwargs.pop(unwanted_kwargs, None)"},{"line_number":39,"context_line":"        super(V3TokenClient, self).__init__("},{"line_number":40,"context_line":"            None, None, None, disable_ssl_certificate_validation\u003ddscv,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a3c09a3_60efcce8","line":37,"updated":"2017-01-13 17:57:08.000000000","message":"nice to have the same NOTE here but this is a small thing, and it is not worth to block this change.","commit_id":"8b8db534ddb9814e62d58ab66baa2ff27e2f0a43"}]}