)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"5fa7418de3c1f0bf5f156c10daf9d97f8ac15332","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Allow not the same sequence in container_formats and disk_formats"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In get_container_and_disk_format, if container_format is one of"},{"line_number":10,"context_line":"[\u0027ami\u0027, \u0027ari\u0027, \u0027aki\u0027], then disk_format must be the same. But"},{"line_number":11,"context_line":"if CONF.image.disk_formats has the items of different sequence"},{"line_number":12,"context_line":"with container_formats, the testcase will fail unexpectedly."},{"line_number":13,"context_line":"This is to allow the different item sequence in container_formats"},{"line_number":14,"context_line":"and disk_formats in tempest.conf."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"ba5201f7_2950335e","line":12,"range":{"start_line":10,"start_character":58,"end_line":12,"end_character":60},"updated":"2017-01-03 20:43:43.000000000","message":"This seems just a wrong configuration for me, and this change makes the code difficult to be understood.\nAre there any use cases for this change?","commit_id":"423919ded2fbf0aa0ec3d885464b2e4a6cabd3b5"}],"tempest/api/image/v1/test_images.py":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"7dbd3283a7036910857f76a064740952cb9187fc","unresolved":false,"context_lines":[{"line_number":41,"context_line":"                   {\u0027container\u0027: container_format, \u0027disk\u0027: disk_format})"},{"line_number":42,"context_line":"            raise exceptions.InvalidConfiguration(msg)"},{"line_number":43,"context_line":"    else:"},{"line_number":44,"context_line":"        disk_format \u003d CONF.image.disk_formats[0]"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    return container_format, disk_format"},{"line_number":47,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da4df55a_83a29cfb","line":44,"updated":"2016-12-27 07:01:26.000000000","message":"I think we don\u0027t need this because we already set the same value at L.33.","commit_id":"ba4ac0eac38fcf982f514e8f9548d4220846b713"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"b21826ec3c7fbee3b89cb2621c5a92ccc8a81052","unresolved":false,"context_lines":[{"line_number":26,"context_line":"CONF \u003d config.CONF"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"def get_container_and_disk_format():"},{"line_number":30,"context_line":"    a_formats \u003d [\u0027ami\u0027, \u0027ari\u0027, \u0027aki\u0027]"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    container_format \u003d CONF.image.container_formats[0]"}],"source_content_type":"text/x-python","patch_set":4,"id":"da4df55a_eb32445d","line":29,"updated":"2016-12-28 06:52:49.000000000","message":"I\u0027m actually not sure why we need this method.. In the v2 tests, we use config values directly[1]. So how about removing this method and make v1 same as v2?\n[1] https://github.com/openstack/tempest/blob/463d62a05f70632e7db48ce94e80db4fdab7b914/tempest/api/image/v2/test_images.py#L45","commit_id":"58268cea2b066241529afc70e28f0827ea1f6f38"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"b21826ec3c7fbee3b89cb2621c5a92ccc8a81052","unresolved":false,"context_lines":[{"line_number":40,"context_line":"                   {\u0027container\u0027: container_format, \u0027disk\u0027: disk_format})"},{"line_number":41,"context_line":"            raise exceptions.InvalidConfiguration(msg)"},{"line_number":42,"context_line":"    else:"},{"line_number":43,"context_line":"        disk_format \u003d CONF.image.disk_formats[0]"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    return container_format, disk_format"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"da4df55a_0b38683c","line":43,"updated":"2016-12-28 06:52:49.000000000","message":"I\u0027d actually prefer removing this. It\u0027s not a critical thing, though.","commit_id":"58268cea2b066241529afc70e28f0827ea1f6f38"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"fe9b85aaec69220aed1bff20300dc827ed435433","unresolved":false,"context_lines":[{"line_number":45,"context_line":"            msg \u003d (\"The container format and the disk format don\u0027t match. \""},{"line_number":46,"context_line":"                   \"Container format: %(container)s, Disk format: %(disk)s.\" %"},{"line_number":47,"context_line":"                   {\u0027container\u0027: container_format, \u0027disk\u0027: disk_format})"},{"line_number":48,"context_line":"            raise exceptions.InvalidConfiguration(msg)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    return container_format, disk_format"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"ba5201f7_4397b239","line":48,"updated":"2017-01-05 22:08:24.000000000","message":"Thanks for your explanation, I got the point.\n\ndisk_format value which is set at line 33 is used only if container_format not in a_formats. So how about moving line 33 to line 49 like\n\n else:\n     disk_format \u003d CONF.image.disk_formats[0]","commit_id":"61fb40a7f299fa211ebc1d98db0d38a77c4415c4"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"d508bdb045a928852868fe19d8e384f940974b16","unresolved":false,"context_lines":[{"line_number":45,"context_line":"                   \"Container format: %(container)s, Disk format: %(disk)s.\" %"},{"line_number":46,"context_line":"                   {\u0027container\u0027: container_format, \u0027disk\u0027: disk_format})"},{"line_number":47,"context_line":"            raise exceptions.InvalidConfiguration(msg)"},{"line_number":48,"context_line":"    else:"},{"line_number":49,"context_line":"        disk_format \u003d CONF.image.disk_formats[0]"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    return container_format, disk_format"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"ba5201f7_2d6b3cb8","line":49,"range":{"start_line":48,"start_character":0,"end_line":49,"end_character":48},"updated":"2017-01-09 01:38:44.000000000","message":"Done","commit_id":"5aba18f1638070b99eaadd184d2c400bad01999c"}]}