)]}'
{"tempest/api/compute/base.py":[{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"f4a3eed741310d1b999a667749ee7d9b5be72ee5","unresolved":false,"context_lines":[{"line_number":396,"context_line":"                                       volume[\u0027id\u0027], \u0027available\u0027)"},{"line_number":397,"context_line":"        return volume"},{"line_number":398,"context_line":""},{"line_number":399,"context_line":"    def create_snapshot(self, client, **kwargs):"},{"line_number":400,"context_line":"        \"\"\"Wrapper utility that returns a test snapshot.\"\"\""},{"line_number":401,"context_line":"        snapshot \u003d client.create_snapshot(**kwargs)[\u0027snapshot\u0027]"},{"line_number":402,"context_line":"        waiters.wait_for_snapshot_status(client, snapshot[\u0027id\u0027], \u0027available\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5201f7_3099cfc4","line":399,"range":{"start_line":399,"start_character":8,"end_line":399,"end_character":23},"updated":"2017-01-09 05:47:52.000000000","message":"Better to rename to create_volume_snapshot? Because the term \"snapshot\" in compute tests may let person having misunderstanding of \"server snapshot\"","commit_id":"8b3bfd95da01eba521ae2a5558a12562b85cbb18"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"4aad65165016f6ad1020aba4c284622a825140ca","unresolved":false,"context_lines":[{"line_number":396,"context_line":"                                       volume[\u0027id\u0027], \u0027available\u0027)"},{"line_number":397,"context_line":"        return volume"},{"line_number":398,"context_line":""},{"line_number":399,"context_line":"    def create_snapshot(self, client, **kwargs):"},{"line_number":400,"context_line":"        \"\"\"Wrapper utility that returns a test snapshot.\"\"\""},{"line_number":401,"context_line":"        snapshot \u003d client.create_snapshot(**kwargs)[\u0027snapshot\u0027]"},{"line_number":402,"context_line":"        waiters.wait_for_snapshot_status(client, snapshot[\u0027id\u0027], \u0027available\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5201f7_b794d136","line":399,"range":{"start_line":399,"start_character":8,"end_line":399,"end_character":23},"in_reply_to":"ba5201f7_3099cfc4","updated":"2017-01-09 09:50:49.000000000","message":"Right, thanks","commit_id":"8b3bfd95da01eba521ae2a5558a12562b85cbb18"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"89a5fb685e531ab7bc8d889e544506b68617351c","unresolved":false,"context_lines":[{"line_number":396,"context_line":"                                       volume[\u0027id\u0027], \u0027available\u0027)"},{"line_number":397,"context_line":"        return volume"},{"line_number":398,"context_line":""},{"line_number":399,"context_line":"    def create_volume_snapshot(self, client, **kwargs):"},{"line_number":400,"context_line":"        \"\"\"Wrapper utility that returns a test volume snapshot.\"\"\""},{"line_number":401,"context_line":"        snapshot \u003d client.create_snapshot(**kwargs)[\u0027snapshot\u0027]"},{"line_number":402,"context_line":"        waiters.wait_for_snapshot_status(client, snapshot[\u0027id\u0027], \u0027available\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba5201f7_61f28071","line":399,"range":{"start_line":399,"start_character":37,"end_line":399,"end_character":43},"updated":"2017-01-10 01:40:51.000000000","message":"better to set client\u003dNone?\nthen,\nif client is None:\n    client \u003d self.snapshots_extensions_client","commit_id":"5164cbbe71fe3bbdc6879bc8c4a3aecc6ae7bed8"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"d210e363d55391e75458872091d2e5c5f20c913a","unresolved":false,"context_lines":[{"line_number":396,"context_line":"                                       volume[\u0027id\u0027], \u0027available\u0027)"},{"line_number":397,"context_line":"        return volume"},{"line_number":398,"context_line":""},{"line_number":399,"context_line":"    def create_volume_snapshot(self, client, **kwargs):"},{"line_number":400,"context_line":"        \"\"\"Wrapper utility that returns a test volume snapshot.\"\"\""},{"line_number":401,"context_line":"        snapshot \u003d client.create_snapshot(**kwargs)[\u0027snapshot\u0027]"},{"line_number":402,"context_line":"        waiters.wait_for_snapshot_status(client, snapshot[\u0027id\u0027], \u0027available\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba5201f7_22dcf317","line":399,"range":{"start_line":399,"start_character":37,"end_line":399,"end_character":43},"in_reply_to":"ba5201f7_61f28071","updated":"2017-01-10 06:13:42.000000000","message":"Right, thanks","commit_id":"5164cbbe71fe3bbdc6879bc8c4a3aecc6ae7bed8"}],"tempest/api/compute/servers/test_servers.py":[{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"f4a3eed741310d1b999a667749ee7d9b5be72ee5","unresolved":false,"context_lines":[{"line_number":141,"context_line":"        self.assertEqual(\u00272001:2001::3\u0027, server[\u0027accessIPv6\u0027])"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"    @test.idempotent_id(\u002705795fb2-b2a7-4c9f-8fac-ff25aedb1489\u0027)"},{"line_number":144,"context_line":"    def test_create_server_from_volume_snapshot(self):"},{"line_number":145,"context_line":"        # Create volume from image"},{"line_number":146,"context_line":"        img_uuid \u003d CONF.compute.image_ref"},{"line_number":147,"context_line":"        boot_volume \u003d self.create_volume(image_ref\u003dimg_uuid)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5201f7_50949389","line":144,"range":{"start_line":144,"start_character":8,"end_line":144,"end_character":47},"updated":"2017-01-09 05:47:52.000000000","message":"should check CONF.volume_feature_enabled.snapshot","commit_id":"8b3bfd95da01eba521ae2a5558a12562b85cbb18"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"f4a3eed741310d1b999a667749ee7d9b5be72ee5","unresolved":false,"context_lines":[{"line_number":168,"context_line":"        created_volume \u003d server_info[\u0027os-extended-volumes:volumes_attached\u0027]"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"        # Delete the created volume at the end of test"},{"line_number":171,"context_line":"        self.addCleanup(self.volumes_client.delete_volume,"},{"line_number":172,"context_line":"                        created_volume[0][\u0027id\u0027])"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"        created_volume_info \u003d self.volumes_client.show_volume("}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5201f7_30c70f97","line":171,"range":{"start_line":171,"start_character":24,"end_line":171,"end_character":57},"updated":"2017-01-09 05:47:52.000000000","message":"self.delete_volume","commit_id":"8b3bfd95da01eba521ae2a5558a12562b85cbb18"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"4aad65165016f6ad1020aba4c284622a825140ca","unresolved":false,"context_lines":[{"line_number":168,"context_line":"        created_volume \u003d server_info[\u0027os-extended-volumes:volumes_attached\u0027]"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"        # Delete the created volume at the end of test"},{"line_number":171,"context_line":"        self.addCleanup(self.volumes_client.delete_volume,"},{"line_number":172,"context_line":"                        created_volume[0][\u0027id\u0027])"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"        created_volume_info \u003d self.volumes_client.show_volume("}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5201f7_5302d6b5","line":171,"range":{"start_line":171,"start_character":24,"end_line":171,"end_character":57},"in_reply_to":"ba5201f7_30c70f97","updated":"2017-01-09 09:50:49.000000000","message":"Done","commit_id":"8b3bfd95da01eba521ae2a5558a12562b85cbb18"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"f4a3eed741310d1b999a667749ee7d9b5be72ee5","unresolved":false,"context_lines":[{"line_number":181,"context_line":"                         created_volume_info[\u0027snapshot_id\u0027])"},{"line_number":182,"context_line":"        self.assertEqual(server[\u0027id\u0027],"},{"line_number":183,"context_line":"                         created_volume_info[\u0027attachments\u0027][0][\u0027server_id\u0027])"},{"line_number":184,"context_line":"        self.assertEqual(created_volume[0][\u0027id\u0027],"},{"line_number":185,"context_line":"                         created_volume_info[\u0027attachments\u0027][0][\u0027volume_id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5201f7_f0dbc74c","line":185,"range":{"start_line":184,"start_character":0,"end_line":185,"end_character":76},"updated":"2017-01-09 05:47:52.000000000","message":"What is the relationship between this check and \"Verify the server was created from the snapshot\"? It seems test_get_volume_attachment does the same check","commit_id":"8b3bfd95da01eba521ae2a5558a12562b85cbb18"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"4aad65165016f6ad1020aba4c284622a825140ca","unresolved":false,"context_lines":[{"line_number":181,"context_line":"                         created_volume_info[\u0027snapshot_id\u0027])"},{"line_number":182,"context_line":"        self.assertEqual(server[\u0027id\u0027],"},{"line_number":183,"context_line":"                         created_volume_info[\u0027attachments\u0027][0][\u0027server_id\u0027])"},{"line_number":184,"context_line":"        self.assertEqual(created_volume[0][\u0027id\u0027],"},{"line_number":185,"context_line":"                         created_volume_info[\u0027attachments\u0027][0][\u0027volume_id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5201f7_133e8e29","line":185,"range":{"start_line":184,"start_character":0,"end_line":185,"end_character":76},"in_reply_to":"ba5201f7_f0dbc74c","updated":"2017-01-09 09:50:49.000000000","message":"When booting a server from a volume snapshot, a bootable volume is created to boot from, as a result that volume is attached to the server, therefore it is useful to verify it.","commit_id":"8b3bfd95da01eba521ae2a5558a12562b85cbb18"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"89a5fb685e531ab7bc8d889e544506b68617351c","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    def setup_clients(cls):"},{"line_number":31,"context_line":"        super(ServersTestJSON, cls).setup_clients()"},{"line_number":32,"context_line":"        cls.client \u003d cls.servers_client"},{"line_number":33,"context_line":"        cls.snapshots_client \u003d cls.snapshots_extensions_client"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def tearDown(self):"},{"line_number":36,"context_line":"        self.clear_servers()"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba5201f7_0149b4d0","line":33,"range":{"start_line":33,"start_character":8,"end_line":33,"end_character":62},"updated":"2017-01-10 01:40:51.000000000","message":"if base.create_volume_snapshot has default client, this can be removed","commit_id":"5164cbbe71fe3bbdc6879bc8c4a3aecc6ae7bed8"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"d210e363d55391e75458872091d2e5c5f20c913a","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    def setup_clients(cls):"},{"line_number":31,"context_line":"        super(ServersTestJSON, cls).setup_clients()"},{"line_number":32,"context_line":"        cls.client \u003d cls.servers_client"},{"line_number":33,"context_line":"        cls.snapshots_client \u003d cls.snapshots_extensions_client"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def tearDown(self):"},{"line_number":36,"context_line":"        self.clear_servers()"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba5201f7_82ebdfaf","line":33,"range":{"start_line":33,"start_character":8,"end_line":33,"end_character":62},"in_reply_to":"ba5201f7_0149b4d0","updated":"2017-01-10 06:13:42.000000000","message":"Done","commit_id":"5164cbbe71fe3bbdc6879bc8c4a3aecc6ae7bed8"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"89a5fb685e531ab7bc8d889e544506b68617351c","unresolved":false,"context_lines":[{"line_number":143,"context_line":"    @test.idempotent_id(\u002705795fb2-b2a7-4c9f-8fac-ff25aedb1489\u0027)"},{"line_number":144,"context_line":"    @testtools.skipUnless(CONF.volume_feature_enabled.snapshot,"},{"line_number":145,"context_line":"                          \u0027Cinder volume snapshots are disabled\u0027)"},{"line_number":146,"context_line":"    @test.services(\u0027image\u0027, \u0027volume\u0027)"},{"line_number":147,"context_line":"    def test_create_server_from_volume_snapshot(self):"},{"line_number":148,"context_line":"        # Create a volume from an image"},{"line_number":149,"context_line":"        img_uuid \u003d CONF.compute.image_ref"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba5201f7_01f2949a","line":146,"range":{"start_line":146,"start_character":19,"end_line":146,"end_character":26},"updated":"2017-01-10 01:40:51.000000000","message":"Where do we need \u0027image\u0027?","commit_id":"5164cbbe71fe3bbdc6879bc8c4a3aecc6ae7bed8"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"d210e363d55391e75458872091d2e5c5f20c913a","unresolved":false,"context_lines":[{"line_number":143,"context_line":"    @test.idempotent_id(\u002705795fb2-b2a7-4c9f-8fac-ff25aedb1489\u0027)"},{"line_number":144,"context_line":"    @testtools.skipUnless(CONF.volume_feature_enabled.snapshot,"},{"line_number":145,"context_line":"                          \u0027Cinder volume snapshots are disabled\u0027)"},{"line_number":146,"context_line":"    @test.services(\u0027image\u0027, \u0027volume\u0027)"},{"line_number":147,"context_line":"    def test_create_server_from_volume_snapshot(self):"},{"line_number":148,"context_line":"        # Create a volume from an image"},{"line_number":149,"context_line":"        img_uuid \u003d CONF.compute.image_ref"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba5201f7_4230179f","line":146,"range":{"start_line":146,"start_character":19,"end_line":146,"end_character":26},"in_reply_to":"ba5201f7_01f2949a","updated":"2017-01-10 06:13:42.000000000","message":"L150 - create a volume from an image, there is an api call to image service.","commit_id":"5164cbbe71fe3bbdc6879bc8c4a3aecc6ae7bed8"},{"author":{"_account_id":20382,"name":"YuYang","email":"yuyangwang1985@gmail.com","username":"YuYangWang"},"change_message_id":"772a5c764149d5a6182ebc8caf6feb6fa5d28543","unresolved":false,"context_lines":[{"line_number":170,"context_line":"        created_volume \u003d server_info[\u0027os-extended-volumes:volumes_attached\u0027]"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"        # Delete the created volume at the end of test"},{"line_number":173,"context_line":"        self.addCleanup(self.delete_volume, created_volume[0][\u0027id\u0027])"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"        created_volume_info \u003d self.volumes_client.show_volume("},{"line_number":176,"context_line":"            created_volume[0][\u0027id\u0027])[\u0027volume\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba5201f7_e2fbcb45","line":173,"range":{"start_line":173,"start_character":7,"end_line":173,"end_character":68},"updated":"2017-01-10 06:28:02.000000000","message":"this why not delete in the first create boot_volume?thanks!","commit_id":"fffa403fcf0a0c897d69845da6f519d277dd5b58"}],"tempest/scenario/test_volume_boot_pattern.py":[{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"71895470c6acc7dc87d317c4219ca508ddc1292b","unresolved":false,"context_lines":[{"line_number":203,"context_line":""},{"line_number":204,"context_line":"        # Verify the server was created from the snapshot"},{"line_number":205,"context_line":"        self.assertEqual("},{"line_number":206,"context_line":"            self.img_uuid,"},{"line_number":207,"context_line":"            created_volume_info[\u0027volume_image_metadata\u0027][\u0027image_id\u0027])"},{"line_number":208,"context_line":"        self.assertEqual(boot_snapshot[\u0027id\u0027],"},{"line_number":209,"context_line":"                         created_volume_info[\u0027snapshot_id\u0027])"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a3c09a3_22e60b15","line":206,"range":{"start_line":206,"start_character":12,"end_line":206,"end_character":26},"updated":"2017-01-18 02:34:50.000000000","message":"if you use boot_volume[\u0027volume_image_metadata\u0027][\u0027image_id\u0027], maybe you will be able to avoid setting image_uuid as an instance variable?","commit_id":"6d8e7a431c2f68f79a00c1dfa6ea7e3ae0b6a885"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"11bc61ac94a975626c9dc6e4838c873348ccaf58","unresolved":false,"context_lines":[{"line_number":203,"context_line":""},{"line_number":204,"context_line":"        # Verify the server was created from the snapshot"},{"line_number":205,"context_line":"        self.assertEqual("},{"line_number":206,"context_line":"            self.img_uuid,"},{"line_number":207,"context_line":"            created_volume_info[\u0027volume_image_metadata\u0027][\u0027image_id\u0027])"},{"line_number":208,"context_line":"        self.assertEqual(boot_snapshot[\u0027id\u0027],"},{"line_number":209,"context_line":"                         created_volume_info[\u0027snapshot_id\u0027])"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a3c09a3_217c3fb4","line":206,"range":{"start_line":206,"start_character":12,"end_line":206,"end_character":26},"in_reply_to":"7a3c09a3_22e60b15","updated":"2017-01-18 08:51:29.000000000","message":"Thanks","commit_id":"6d8e7a431c2f68f79a00c1dfa6ea7e3ae0b6a885"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"b66c4dcf2a38379d390f3d847a62ee9a3930d888","unresolved":false,"context_lines":[{"line_number":180,"context_line":""},{"line_number":181,"context_line":"    @test.idempotent_id(\u002705795fb2-b2a7-4c9f-8fac-ff25aedb1489\u0027)"},{"line_number":182,"context_line":"    @test.services(\u0027compute\u0027, \u0027image\u0027, \u0027volume\u0027)"},{"line_number":183,"context_line":"    def test_create_server_from_volume_snapshot(self):"},{"line_number":184,"context_line":"        # Create a volume from an image"},{"line_number":185,"context_line":"        boot_volume \u003d self._create_volume_from_image()"},{"line_number":186,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"5a3905b3_5196d43f","line":183,"updated":"2017-01-21 11:09:39.000000000","message":"I am wondering if we really need a new test. Maybe we can just delete L163 and change L166 so that it boot directly from the snapshot.","commit_id":"8789c5545f516135a48d40d2db8ea96f262ed3f8"},{"author":{"_account_id":23184,"name":"DavidPurcell","email":"d.purcell222@gmail.com","username":"DavidPurcell"},"change_message_id":"e94f174688b3668ae9d7726506e2c1e7e77f4d57","unresolved":false,"context_lines":[{"line_number":180,"context_line":""},{"line_number":181,"context_line":"    @test.idempotent_id(\u002705795fb2-b2a7-4c9f-8fac-ff25aedb1489\u0027)"},{"line_number":182,"context_line":"    @test.services(\u0027compute\u0027, \u0027image\u0027, \u0027volume\u0027)"},{"line_number":183,"context_line":"    def test_create_server_from_volume_snapshot(self):"},{"line_number":184,"context_line":"        # Create a volume from an image"},{"line_number":185,"context_line":"        boot_volume \u003d self._create_volume_from_image()"},{"line_number":186,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"3a461143_5c0a6d7a","line":183,"in_reply_to":"5a3905b3_5196d43f","updated":"2017-01-27 21:18:38.000000000","message":"I somewhat like having it as two separate tests.  The above test does so many things that it can be somewhat difficult to determine exactly what failed.","commit_id":"8789c5545f516135a48d40d2db8ea96f262ed3f8"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"f60ba10f1dd206cb4b146971570eb6a2a2aac793","unresolved":false,"context_lines":[{"line_number":196,"context_line":"        server_info \u003d self.servers_client.show_server(server[\u0027id\u0027])[\u0027server\u0027]"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"        # The created volume when creating a server from a snapshot"},{"line_number":199,"context_line":"        created_volume \u003d server_info[\u0027os-extended-volumes:volumes_attached\u0027]"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"        created_volume_info \u003d self.volumes_client.show_volume("},{"line_number":202,"context_line":"            created_volume[0][\u0027id\u0027])[\u0027volume\u0027]"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a461143_b19ecf04","line":199,"range":{"start_line":199,"start_character":74,"end_line":199,"end_character":76},"updated":"2017-01-31 10:12:23.000000000","message":"we should check whether there are attachment or not, otherwise it will be index error @L202. So you add below checks:\n\nself.assertNotEmpty(created_volume, \"No volume attachment found.\")\nself.assertEqual(\n            boot_volume[\u0027id\u0027],\n            created_volume[0][\u0027id\u0027])\n\nI am ok to add those check in follow up patch also.","commit_id":"8789c5545f516135a48d40d2db8ea96f262ed3f8"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"cc88a6d2692282f474bf45d67c318f6c81441749","unresolved":false,"context_lines":[{"line_number":196,"context_line":"        server_info \u003d self.servers_client.show_server(server[\u0027id\u0027])[\u0027server\u0027]"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"        # The created volume when creating a server from a snapshot"},{"line_number":199,"context_line":"        created_volume \u003d server_info[\u0027os-extended-volumes:volumes_attached\u0027]"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"        created_volume_info \u003d self.volumes_client.show_volume("},{"line_number":202,"context_line":"            created_volume[0][\u0027id\u0027])[\u0027volume\u0027]"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a430d35_49e82de3","line":199,"range":{"start_line":199,"start_character":74,"end_line":199,"end_character":76},"in_reply_to":"3a461143_b19ecf04","updated":"2017-02-05 14:10:38.000000000","message":"Hi Ghanshyam,\nI\u0027ve uploaded a patch checking whether there is an attachment or not -\u003e https://review.openstack.org/#/c/429384/.\nThe second check is not correct since boot_volume[\u0027id\u0027] is the parent volume of the snapshot and created_volume[0][\u0027id\u0027] is the volume that was created when creating a server from snapshot to boot from.","commit_id":"8789c5545f516135a48d40d2db8ea96f262ed3f8"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"74fdf7103fc9ff6ef936bddd903c2470edd0c382","unresolved":false,"context_lines":[{"line_number":196,"context_line":"        server_info \u003d self.servers_client.show_server(server[\u0027id\u0027])[\u0027server\u0027]"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"        # The created volume when creating a server from a snapshot"},{"line_number":199,"context_line":"        created_volume \u003d server_info[\u0027os-extended-volumes:volumes_attached\u0027]"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"        created_volume_info \u003d self.volumes_client.show_volume("},{"line_number":202,"context_line":"            created_volume[0][\u0027id\u0027])[\u0027volume\u0027]"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a461143_6f6722b7","line":199,"range":{"start_line":199,"start_character":74,"end_line":199,"end_character":76},"in_reply_to":"3a461143_b19ecf04","updated":"2017-01-31 10:41:35.000000000","message":"thanks I\u0027ll do it","commit_id":"8789c5545f516135a48d40d2db8ea96f262ed3f8"}]}